Commit Graph

35841 Commits

Author SHA1 Message Date
cf3043fc08 Only show "development build" footer on debug releases 2021-01-06 23:20:26 +09:00
cb4e6ac0b3 Merge pull request #11429 from peppy/fix-transform-carousel 2021-01-06 14:22:06 +01:00
7651d4554a Merge branch 'master' into fix-transform-carousel 2021-01-06 13:49:05 +01:00
43b9fde457 Add some nullability annotations for good measure 2021-01-06 13:15:15 +01:00
99701a6d9b Add null check on beatmapContainer for safety 2021-01-06 21:06:33 +09:00
ffafdf2209 Merge branch 'master' into fix-transform-carousel 2021-01-06 21:03:22 +09:00
ddfa3254b3 Merge pull request #11425 from peppy/fix-transform-mutation-from-background
Fix transform mutation on background screens
2021-01-06 20:01:42 +09:00
25b4628672 Merge branch 'master' into fix-transform-mutation-from-background 2021-01-06 11:04:51 +01:00
04cdbc9a03 Merge pull request #11428 from peppy/fix-transform-mutation-display-settings 2021-01-06 10:46:07 +01:00
07cff70387 Add specific messaging for when there's no background stack available 2021-01-06 18:19:03 +09:00
6572bb18de Merge branch 'master' into fix-transform-mutation-display-settings 2021-01-06 10:09:14 +01:00
550ef3f133 Aggressively dispose ownedBackground if it was not used, because we can 2021-01-06 15:28:01 +09:00
e9d4e4d1d5 Add xmldoc and throw a local exception on null background 2021-01-06 15:26:44 +09:00
11a0c637bc Mark background properties as nullable 2021-01-06 15:26:00 +09:00
15dd7a87a6 Move gameplay preview event binding to LoadComplete 2021-01-06 15:19:12 +09:00
1f0af747ad Merge pull request #11426 from peppy/fix-transform-mutation-loading-layer 2021-01-05 23:45:17 +01:00
52687fc37c Merge branch 'master' into fix-transform-mutation-loading-layer 2021-01-05 23:10:51 +01:00
0880e76da8 Mark background dim layer as possibly-null 2021-01-05 22:56:53 +01:00
ac1d6d4444 Make auto-property get-only 2021-01-05 22:56:53 +01:00
2b253f6d01 Remove now-unused fields & locals 2021-01-05 22:56:53 +01:00
e9282e9a2b Merge pull request #11405 from peppy/fix-carousel-centering-on-window-resize 2021-01-05 22:03:40 +01:00
fbbc26d7d8 Merge branch 'master' into fix-carousel-centering-on-window-resize 2021-01-05 21:30:39 +01:00
11e228b781 Merge pull request #11419 from peppy/fix-transform-mutation-from-disposal-thread
Fix RemoveBlockingOverlay causing transform mutation from disposal threads
2021-01-05 20:45:32 +01:00
847d2d8deb Merge branch 'master' into fix-transform-mutation-from-disposal-thread 2021-01-05 19:52:10 +01:00
4b539b01c1 Match code between updateSelectedBeatmap/Ruleset 2021-01-05 20:38:58 +09:00
83dbba3cbf Fix carousel beatmap set panels applying transforms to difficulties while they are loading 2021-01-05 18:41:45 +09:00
d0d2e41b28 Fix display settings binding to configuration bindables in async load 2021-01-05 18:19:28 +09:00
0639429a23 Fix test (and remove no longer valid test) 2021-01-05 18:10:39 +09:00
3b98782964 Merge pull request #11420 from kyekiller/master
Fix to toolbar tooltips
2021-01-05 17:43:32 +09:00
0b1ee2e267 Remove unused dispose logic 2021-01-05 17:42:19 +09:00
54982dcdd7 Refactor LoadingLayer to avoid applying effects to external drawables
In theory this seemed like a good idea (and an optimisation in some
cases, due to lower fill rate), but in practice this leads to weird edge
cases.

This aims to do away with the operations on external drawables by
applying a dim to the area behind the `LoadingLayer` when required.
I went over each usage and ensured they look as good or better than
previously.

The specific bad usage here was the restoration of the colour on dispose
(if the `LoadingLayer` was disposed in a still-visible state).

I'm aware that the `BeatmapListingOverlay` will now dim completely during
load. I think this is fine for the time being.
2021-01-05 17:31:45 +09:00
5904e426eb Remove unused variable 2021-01-05 16:00:25 +09:00
60fc60fa00 Merge pull request #11415 from frenzibyte/fix-ready-button-crash
Fix multiplayer ready button crashing when deleting selected beatmap set
2021-01-05 15:58:09 +09:00
b3f08b29ca Ensure that all changes to screen backgrounds are on the correct thread 2021-01-05 15:22:50 +09:00
a3e4e2f6c3 Switch ResultsScreen and SongSelect inheritance and remove local implementation 2021-01-05 15:22:50 +09:00
ed6ffe2ef1 Remove hacky code 2021-01-05 14:54:59 +09:00
81355652fa Add simple test coverage 2021-01-05 06:00:15 +03:00
77e660e426 Should pass all checks again now. 2021-01-04 22:11:52 +00:00
1234d0fa04 Applied all tooltips to the right 2021-01-04 22:01:12 +00:00
254698d9a2 Merge branch 'master' into master 2021-01-04 21:07:12 +00:00
0e42d415c1 Hit another oopie 2021-01-04 21:05:28 +00:00
3468df840b Moved tooltip to the left to stop the overflow 2021-01-04 21:04:30 +00:00
73f5e5aaf9 Moved "ToolbarSocialButton" back 2021-01-04 21:03:51 +00:00
a86a7b08df Merge pull request #11418 from peppy/fix-storyboard-skip-starttime-regression 2021-01-04 20:08:59 +01:00
2e2b3ab5d4 Should remove codeFactor error 2021-01-04 17:26:42 +00:00
2d1b52be0d Moved "ToolbarSocialButton"
This will remove it from coming off the screen.
2021-01-04 17:21:31 +00:00
3b08faa0ea Fix RemoveBlockingOverlay causing transform mutation from disposal threads 2021-01-04 17:49:11 +09:00
485a57776b Fix hasBeatmap potentially checking on outdated DeletePending value 2021-01-04 10:28:41 +03:00
ea38b00b29 Schedule all calls to updateBeatmapState() 2021-01-04 10:27:08 +03:00
9e0c490141 Remove unused using 2021-01-04 15:40:22 +09:00