Commit Graph

7133 Commits

Author SHA1 Message Date
cfe3218239 Move scheduler call to inside method itself for added safety 2020-11-04 10:23:06 +09:00
29e8e5ab94 Merge branch 'master' into fix-load-async-after-disposal-beatmap-wedge 2020-11-04 10:23:05 +09:00
3bb86ce127 Merge branch 'master' into editor-waveform-opacity 2020-11-03 23:04:19 +01:00
13f729916a Merge branch 'master' into editor-timeline-scroll-mousewheel 2020-11-03 22:27:35 +01:00
ddf0d75c38 Don't fall through to seek if handling zoom 2020-11-03 21:49:21 +01:00
4b528e80d0 Use AltPressed shorthand 2020-11-03 21:49:04 +01:00
18428dff8e Ensure hotkey actions are executable in handler 2020-11-03 18:01:12 +01:00
83c004bbde Add key bindings for flip and reverse patterns 2020-11-03 21:10:31 +09:00
d788931661 Fix LoadComponentAsync calls potentially occuring after beatmap wedge disposal
As seen in https://ci.appveyor.com/project/peppy/osu/builds/36109658/tests.

Also adds cancellation logic for good measure.
2020-11-03 19:53:45 +09:00
c2ffc18379 Change editor timeline mouse wheel handling to scroll by default (and zoom with alt held) 2020-11-03 16:30:11 +09:00
0dcb4ea441 Add handling of opacity to timeline waveform display 2020-11-03 16:07:01 +09:00
7e4314684b Add editor waveform opacity selection to menu 2020-11-03 16:01:14 +09:00
6bf35d5767 Fix editor menu not supporting stateful item drawables 2020-11-03 16:00:07 +09:00
ab308d28d2 Debounce calls to UpdateTernaryStates
Just something I noticed in passing recently which may help with
reducing performance overhead of some batch operations.
2020-11-03 01:08:36 +09:00
3956a0669a Fix editor seek transform seeking too much 2020-11-02 21:08:58 +09:00
6f623d8cca Rename IsUserPaused -> UserPauseRequested 2020-11-02 16:08:59 +09:00
8adf146f53 Merge pull request #10640 from bdach/fix-music-paused-on-multi-exit 2020-11-02 15:46:19 +09:00
ab9e0aac58 Merge pull request #10258 from Game4all/results-dynamic-pp-calc 2020-11-02 15:40:55 +09:00
8f2cd0e8c5 Add matching requestedByUser parameter to Play method 2020-11-02 15:01:30 +09:00
d2f6303988 Change default value of requestedByUser to false 2020-11-02 14:56:50 +09:00
ecad85b5f5 Merge branch 'master' into fix-music-paused-on-multi-exit 2020-11-02 14:55:15 +09:00
04178e9458 Merge branch 'master' into spectator-replay-watcher 2020-11-02 14:54:51 +09:00
73b290aca3 Merge branch 'master' into results-dynamic-pp-calc 2020-11-02 14:47:33 +09:00
bd7c3d0d9f Merge branch 'master' into results-screen-applause 2020-11-02 13:38:19 +09:00
1b53e6c782 Merge branch 'master' into sample-lookup-improvements 2020-11-02 13:04:35 +09:00
8a768669ad Merge pull request #10606 from FamousPig/fix-timeline-drag-select-weirdness
Fix timeline zoom during drag-select causing unexpected behaviour
2020-11-02 13:04:26 +09:00
6cfaee0f0b Merge pull request #10631 from bdach/shift-delete-all-selected 2020-11-02 12:04:58 +09:00
6e2d722b8a Merge pull request #10649 from ppy/dependabot/nuget/Microsoft.CodeAnalysis.FxCopAnalyzers-3.3.1 2020-11-02 11:52:38 +09:00
5ae3da9399 Merge branch 'master' into fix-timeline-drag-select-weirdness 2020-11-02 11:18:37 +09:00
61c9bb3245 Merge branch 'master' into dependabot/nuget/Microsoft.CodeAnalysis.FxCopAnalyzers-3.3.1 2020-11-02 10:56:09 +09:00
b1b52f9073 Merge branch 'master' into fix-resume-beatmap-options-edit 2020-11-02 10:46:31 +09:00
ba726c6291 Merge pull request #10623 from cadon0/fix-beatmap-details-metadata-bounce
Fix "bounce" when metadata container text is empty in song select
2020-11-02 10:45:14 +09:00
71d55f16f3 Fix edit beatmap options button not resuming back to song select 2020-11-01 13:50:38 -08:00
432282e8de Use alternative solution to avoid storing last zoom 2020-11-01 21:25:05 +01:00
3090b6ccb5 Resolve CA2249 inspections
"Use `string.Contains` instead of `string.IndexOf` to improve
readability"
2020-11-01 18:54:44 +01:00
716458344f Ensure spectator player is unsubscribed to prevent leak 2020-11-01 16:13:19 +01:00
23d9fa4dfa Merge branch 'master' into spectator-replay-watcher 2020-11-01 15:53:37 +01:00
b7696c85ad Add more xmldocs 2020-11-01 15:23:03 +01:00
1f8d627af4 Merge branch 'master' into shift-delete-all-selected 2020-11-01 23:03:01 +09:00
e1b8875553 Merge pull request #10634 from bdach/fix-leftover-selection-box-tooltip
Fix selection box action tooltips still being visible after object deletion
2020-11-01 23:02:29 +09:00
6bfff43634 Extract StatisticCounter to a separate class and use it instead. 2020-11-01 13:25:36 +01:00
f3e0480e77 Merge branch 'master' into fix-beatmap-details-metadata-bounce 2020-10-31 17:36:40 +01:00
19023e7d43 Fix player restart invoking user-level pause 2020-10-31 16:08:15 +01:00
a9a3489e92 Fix potential null reference when loading background
As seen in
https://discordapp.com/channels/188630481301012481/188630652340404224/772094427342569493.
Caused due to async load of the loader, which means it may not be ready
before Next() is called.
2020-10-31 22:51:35 +09:00
007c27d3ff Schedule visibility update once per frame 2020-10-31 14:45:11 +01:00
d74c19e2d7 Shorten show/hide code 2020-10-31 13:54:02 +01:00
3322b8a7ea Run OnSelectionChanged() on each change 2020-10-31 13:54:02 +01:00
003994ab75 Bind UpdateVisibility() directly to source of truth 2020-10-31 13:54:02 +01:00
129b1bc6d3 Delete all selected objects if shift-clicked on one 2020-10-31 11:46:25 +01:00
6a293dd536 Add missing ctor parameters back 2020-10-31 18:56:30 +09:00