Commit Graph

49717 Commits

Author SHA1 Message Date
d0cc68bc97 Add test coverage 2022-03-18 07:26:10 +03:00
98b420ee6f Remove no longer correct crown fade animation
Since the host is pinned to the top without any animation, it would look
jarring for the crown to fade away from the old panel (and at a 50ms
duration).
2022-03-18 07:25:12 +03:00
1c899d00b9 Pin multiplayer host panel to the top of the list 2022-03-18 07:25:03 +03:00
4adb8c205f Add step to switch hosts randomly in TestManyUsers 2022-03-18 07:18:49 +03:00
e3cbde5099 Merge pull request #17282 from peppy/skin-editor-reset-position
Add "Reset position" menu item in skin editor
2022-03-17 14:20:24 +09:00
e8886e4c50 Merge pull request #17286 from frenzibyte/rewrite-mod-instantiation-method
Update mod instantiation utility method inline with `APIMod.ToMod` changes
2022-03-17 14:19:55 +09:00
1eac0f41bf Remove unused using 2022-03-17 13:44:54 +09:00
07433d0540 Merge pull request #17278 from peppy/skin-editor-multiple-component-settings
Show settings for multiple skin components in a selection
2022-03-17 13:43:59 +09:00
e0a06bf5d9 Update mod instantiation utility method inline with APIMod.ToMod changes 2022-03-17 06:28:10 +03:00
83189d1f07 Revert "Update mod instantiaton utility method to no longer check for validity"
This reverts commit 1a04260807.
2022-03-17 06:24:55 +03:00
1a04260807 Update mod instantiaton utility method to no longer check for validity 2022-03-17 05:51:12 +03:00
52d1c0cc15 Merge pull request #17274 from peppy/skin-editor-toolbox-ui
Update skin editor toolbox design to suck less
2022-03-16 20:54:00 +01:00
38d15145ac Merge branch 'master' into skin-editor-multiple-component-settings 2022-03-16 22:23:53 +09:00
3f61b0d968 Add missing OverlayColourProvider to SkinEditor test 2022-03-16 22:23:19 +09:00
6df36171b5 Merge branch 'master' into skin-editor-toolbox-ui 2022-03-16 22:21:10 +09:00
fa8058e025 Merge pull request #17277 from peppy/skin-editor-sidebars
Update skin editor to use `EditorSidebar`
2022-03-16 21:41:29 +09:00
7f65f6adcc Merge branch 'master' into skin-editor-sidebars 2022-03-16 21:12:18 +09:00
36c97e5a8d Merge pull request #17273 from peppy/skin-editor-scene-library
Add a basic scene library to skin editor
2022-03-16 21:12:05 +09:00
b9387c7ff1 Merge branch 'master' into skin-editor-scene-library 2022-03-16 20:42:30 +09:00
7faa35950a Merge pull request #17272 from peppy/skin-editor-hide-toolbar
Hide the game toolbar (and overlays) when entering the skin editor
2022-03-16 20:42:20 +09:00
7e52623645 Add "Reset position" menu item in skin editor 2022-03-16 20:02:52 +09:00
27122c17c9 Show settings for multiple components in a selection 2022-03-16 19:35:45 +09:00
424698e216 Merge pull request #17271 from peppy/fix-chat-highlighting-single-or-default
Fix potential crash when highlighting chat messages
2022-03-16 19:31:20 +09:00
54e351efe9 Convert top level skin editor layout to use grid container
Fix `SkinEditor`'s initial target not being a `Screen`
2022-03-16 19:30:51 +09:00
4525ed645c Update skin editor to use EditorSidebar 2022-03-16 19:30:51 +09:00
59cb1ac126 Order components by name for now 2022-03-16 19:21:15 +09:00
e4a6b7ae91 Expand toolbox component items on hover 2022-03-16 19:21:15 +09:00
fdb411c0f3 Update skin editor toolbox design to suck less 2022-03-16 19:21:15 +09:00
b08d4bb8eb Move SceneLibrary implementation to its own file 2022-03-16 19:13:52 +09:00
ee3715f5cf Use OverlayColourProvider and adjust metrics to roughly match new designs 2022-03-16 19:13:52 +09:00
aff6a5a428 Better align scene selector with menu bar 2022-03-16 19:13:52 +09:00
c6aa32a003 Add basic song select setup for skinnability 2022-03-16 19:12:06 +09:00
8d85723a62 Split out SceneLibrary into its own component 2022-03-16 19:12:06 +09:00
d062810ff2 Add basic scene selector 2022-03-16 19:12:06 +09:00
c807ad7e4e Ensure toolbar is hidden even when the active screen is changed while the editor is open 2022-03-16 19:11:22 +09:00
86960c791f Close overlays and toolbar on entering the skin editor 2022-03-16 19:00:23 +09:00
99e3161cf0 Fix SkinEditor's initial target not being a Screen 2022-03-16 18:57:47 +09:00
2452d84e98 Add missing Schedule call to allow individual tests from TestSceneMessageNotifier to pass 2022-03-16 18:44:30 +09:00
603527d72d Fix potential crash when highlighting chat messages
Test failed locally in `TestPublicChannelMention`. This test seems to
specify that the same message may arrive twice with the same ID, so
rather than overthinking this one I propose we just use `FirstOrDefault`.

```csharp
TearDown : System.AggregateException : One or more errors occurred.
(Sequence contains more than one matching element)
  ----> System.InvalidOperationException : Sequence contains more than
one matching element
--TearDown
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean
includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout,
CancellationToken cancellationToken)
   at osu.Framework.Extensions.TaskExtensions.WaitSafely(Task task)
   at osu.Framework.Testing.TestScene.checkForErrors()
--InvalidOperationException
   at System.Linq.ThrowHelper.ThrowMoreThanOneMatchException()
   at System.Linq.Enumerable.TryGetSingle[TSource](IEnumerable`1 source,
Func`2 predicate, Boolean& found)
   at System.Linq.Enumerable.SingleOrDefault[TSource](IEnumerable`1
source, Func`2 predicate)
   at
osu.Game.Overlays.Chat.DrawableChannel.<processMessageHighlighting>b__14_0()
in
/Users/dean/Projects/osu/osu.Game/Overlays/Chat/DrawableChannel.cs:line
102
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
```
2022-03-16 18:38:06 +09:00
7e8aa77b2b Merge pull request #17260 from peppy/editor-sidebar
Add `EditorSidebar` component
2022-03-16 18:20:18 +09:00
ba1642a680 Allow section headers to wrap 2022-03-16 17:19:08 +09:00
d80830b415 Merge pull request #17226 from peppy/skin-component-settings
Allow skin components to have settings
2022-03-16 17:12:11 +09:00
3884044219 Merge pull request #17263 from jai-x/fix-playlist-resultscreen-test
Fix `PlaylistResultsScreen` test failures
2022-03-16 10:24:10 +09:00
1c79083f96 Move all PlaylistResultScreen test state initialisation into SetUpSteps 2022-03-15 22:15:35 +00:00
c56df80106 Fix PlaylistResultsScreen test failures
As seen: https://github.com/ppy/osu/pull/17252/checks?check_run_id=5545717506

The `PlaylistsResultsScreen` takes a lease on the `Beatmap` bindable
when entered. During `SetUp`, the `Beatmap` bindable is reassigned but
fails in cases where an existing test instance of the screen hasn't been
exited yet. This fix moves the assignment into the `SetUpSteps` function
after `base.SetUpSteps` is called which will exit the existing screens
first.
2022-03-15 20:38:04 +00:00
a0a033520f Rider no add licence headers 2022-03-15 16:48:14 +09:00
4ab5d6e3f0 Remove unnecessary FillFlowContainer from section 2022-03-15 16:47:08 +09:00
9e476ced63 Add EditorSidebar component 2022-03-15 16:38:00 +09:00
7aa3a52ef7 Merge pull request #17259 from peppy/remove-broken-check
Remove current screen check from skin editor changes
2022-03-15 16:09:49 +09:00
2b02a6555b Remove current screen check from skin editor changes 2022-03-15 15:40:26 +09:00