Commit Graph

22262 Commits

Author SHA1 Message Date
d2b76ec688 Make LabelledTextBox use the new LabelledComponent class (#6188)
Make LabelledTextBox use the new LabelledComponent class

Co-authored-by: Dean Herbert <pe@ppy.sh>
2019-09-24 19:37:12 +09:00
f493f1c71d Move new components to v2 namespace 2019-09-24 19:00:26 +09:00
551b66ccec Update framework (#6234)
Update framework

Co-authored-by: null <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2019-09-24 18:54:47 +09:00
4dde0e172d Merge branch 'master' into labelled-textbox-improvements 2019-09-24 18:54:02 +09:00
9c4ff6d935 Make LabelledComponent generic (#6237)
Make LabelledComponent generic
2019-09-24 18:52:02 +09:00
1e70b83fd3 Merge branch 'master' into update-framework 2019-09-24 18:27:38 +09:00
6b702eb6de Update with generic labelledcomponent 2019-09-24 18:25:17 +09:00
5212c50654 Merge branch 'generic-labelledcomponent' into labelled-textbox-improvements 2019-09-24 18:23:01 +09:00
df692b091c Make LabelledComponent generic 2019-09-24 18:22:02 +09:00
79b64bdaa1 Merge pull request #6211 from peppy/tournament-setup
Add an onboarding screen for tournament client
2019-09-24 17:44:45 +09:00
45015fc4ba Merge branch 'master' into tournament-setup 2019-09-24 17:27:17 +09:00
9ea876eb36 Merge remote-tracking branch 'upstream/dependabot/nuget/ppy.osu.Framework-2019.924.0' into update-framework 2019-09-24 16:23:06 +09:00
6b4d45c36a Merge remote-tracking branch 'upstream/dependabot/nuget/ppy.osu.Framework.Android-2019.924.0' into update-framework 2019-09-24 16:22:54 +09:00
1860c2f9ce Update framework 2019-09-24 16:22:30 +09:00
50efb4414f Bump ppy.osu.Framework.Android from 2019.921.0 to 2019.924.0
Bumps [ppy.osu.Framework.Android](https://github.com/ppy/osu-framework) from 2019.921.0 to 2019.924.0.
- [Release notes](https://github.com/ppy/osu-framework/releases)
- [Commits](https://github.com/ppy/osu-framework/compare/2019.921.0...2019.924.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-09-24 06:35:31 +00:00
6e619fbd71 Bump ppy.osu.Framework from 2019.921.0 to 2019.924.0
Bumps [ppy.osu.Framework](https://github.com/ppy/osu-framework) from 2019.921.0 to 2019.924.0.
- [Release notes](https://github.com/ppy/osu-framework/releases)
- [Commits](https://github.com/ppy/osu-framework/compare/2019.921.0...2019.924.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-09-24 06:35:04 +00:00
9219aadf76 Merge pull request #6210 from peppy/menu-key-support
Allow top-level menu key pressed to progress the osu! logo
2019-09-24 15:21:34 +09:00
b67b594036 Merge branch 'master' into menu-key-support 2019-09-24 15:09:38 +09:00
4555ecc5e0 Check for exact key 2019-09-24 15:09:08 +09:00
ac1abfc9c5 Merge pull request #6220 from EVAST9919/fix-changelog-margin
Fix incorrect icon margin in ChangelogOverlay
2019-09-24 13:49:28 +09:00
615e300bc9 Merge branch 'master' into fix-changelog-margin 2019-09-24 13:39:17 +09:00
4705b5aff8 Bump System.IO.Packaging from 4.5.0 to 4.6.0 (#6225)
Bump System.IO.Packaging from 4.5.0 to 4.6.0

Co-authored-by: null <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Dean Herbert <pe@ppy.sh>
2019-09-24 12:15:43 +09:00
b63a3dc2f8 Merge pull request #6222 from ppy/dependabot/nuget/System.ComponentModel.Annotations-4.6.0
Bump System.ComponentModel.Annotations from 4.5.0 to 4.6.0
2019-09-24 12:15:13 +09:00
0820e23097 Merge branch 'master' into dependabot/nuget/System.IO.Packaging-4.6.0 2019-09-24 11:17:07 +09:00
8321ad13fc Bump Microsoft.Win32.Registry from 4.5.0 to 4.6.0 (#6227)
Bump Microsoft.Win32.Registry from 4.5.0 to 4.6.0

Co-authored-by: null <27856297+dependabot-preview[bot]@users.noreply.github.com>
2019-09-24 09:55:37 +09:00
50dcb70342 Bump Microsoft.Win32.Registry from 4.5.0 to 4.6.0
Bumps [Microsoft.Win32.Registry](https://github.com/dotnet/corefx) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/dotnet/corefx/releases)
- [Commits](https://github.com/dotnet/corefx/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-09-23 21:04:20 +00:00
78ce62b187 Bump System.IO.Packaging from 4.5.0 to 4.6.0
Bumps [System.IO.Packaging](https://github.com/dotnet/corefx) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/dotnet/corefx/releases)
- [Commits](https://github.com/dotnet/corefx/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-09-23 20:29:36 +00:00
53603b5591 Bump System.ComponentModel.Annotations from 4.5.0 to 4.6.0
Bumps [System.ComponentModel.Annotations](https://github.com/dotnet/corefx) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/dotnet/corefx/releases)
- [Commits](https://github.com/dotnet/corefx/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-09-23 20:15:51 +00:00
5c4dfe0809 Apply suggested change 2019-09-23 17:05:19 +03:00
ffbab25358 Fix incorrect icon margin in ChangelogOverlay 2019-09-23 16:12:43 +03:00
a39a27d0df Song select filter improvements (#6206)
Song select filter improvements
2019-09-23 18:21:12 +09:00
9a6d748498 Merge branch 'master' into add-creator-artist-filters 2019-09-23 12:31:51 +09:00
bafb429e9b Don't show video background 2019-09-23 04:49:31 +09:00
4b7a421191 Set setup screen as default when opening 2019-09-23 04:47:51 +09:00
b41ac543c5 Allow changing logged in user 2019-09-23 04:46:50 +09:00
e07aa94fc8 Allow reloading ipc source 2019-09-23 04:22:50 +09:00
96c0c80dc5 Factor out methods in FilterQueryParser
Factor FilterQueryParser.ApplyQueries into shorter methods to reduce
method complexity.
2019-09-22 21:20:50 +02:00
47a89231ad Read from (and allow reloading) IPC source 2019-09-23 03:17:14 +09:00
3b52e7c724 Add boilerplate logic 2019-09-23 03:17:14 +09:00
d6ec6b1eda Merge branch 'master' into labelled-textbox-improvements 2019-09-23 00:39:29 +09:00
9fe7675be8 Add a base class for all future labelled components (#6187)
Add a base class for all future labelled components
2019-09-23 00:38:51 +09:00
e5b14ce74d Add null check for safety
Co-Authored-By: Salman Ahmed <slmanarendo1950@gmail.com>
2019-09-22 21:42:32 +09:00
fc1d49631a Allow top-level menu key pressed to progress the osu! logo 2019-09-22 20:31:53 +09:00
cdf29b0952 Specify model name on initialize and fail import notification m… (#6192)
Specify model name on initialize and fail import notification messages
2019-09-22 15:54:04 +09:00
70842f71f4 Fix floating point handling in filter intervals
Due to floating-point rounding and representation errors, filters could
wrongly display results incongruous with the wedge display text (ie.
a beatmap with the BPM of 139.99999 would be displayed as having 140
BPM and also pass the bpm<140 filter).

Apply tolerance when parsing floating-point constraints. The tolerance
chosen is half of what the UI displays for the particular values (so
for example half of 0.1 for AR/DR/CS, 0.01 for stars, etc.)

Tests updated accordingly.
2019-09-22 00:20:55 +02:00
b262ba13cd Add creator= and artist= filters
To match stable, add creator= and artist= filters to the beatmap
carousel on song select screen. Contrary to stable, this implementation
supports phrase queries with spaces within using double quotes.

The quote handling is not entirely correct (can't nest), but quotes
should rarely happen within names, and it is an edge case of an edge
case - leaving best-effort as is. Test coverage also included.
2019-09-22 00:20:55 +02:00
51509f6be0 Add filter steps to carousel visual test
Just a couple of steps for added coverage in visual tests. Very
on-the-surface, the unit tests are supposed to cover the gory details.
2019-09-22 00:20:54 +02:00
41569fd2b6 Add filter evaluating unit tests
Introduce unit tests covering the actual evaluation of filters for
beatmaps. Partially covers most scenarios.
2019-09-22 00:20:54 +02:00
d11d932a87 Add filter parsing tests
Introduce unit tests covering parsing for the originally introduced
filtering features. The introduced improvements (lower and upper
interval and decimal point support) also tested.
2019-09-22 00:20:54 +02:00
f5f5094611 Take culture into account when parsing filters
Culture was not taken into account when parsing filters, which meant
that in cultures that use the comma (,) as a decimal delimiter, it would
conflict with the comma used to delimit search criteria. To remove
any ambiguity, introduce local helper functions that allow the decimal
point to be utilised, using the invariant culture. This also matches
stable behaviour.

The decision to not reuse osu.Game.Beatmaps.Formats.Parsing was
deliberate due to differing semantics (it's not really sane to throw
exceptions on receiving user-facing input).
2019-09-22 00:18:53 +02:00