Commit Graph

49938 Commits

Author SHA1 Message Date
d3a957d64e Fix test client not receiving initial value 2022-03-24 20:24:09 +09:00
0d88af19ae Fix local setting not being updated 2022-03-24 20:23:58 +09:00
f80692f342 Add missing TestMultiplayerClient coverage 2022-03-24 20:19:05 +09:00
5fe46a73cb Update room state in more situations 2022-03-24 20:17:16 +09:00
209de886ce Add method to stop countdown 2022-03-24 20:17:16 +09:00
ea9de0199d Split countdown start into separate method 2022-03-24 20:09:32 +09:00
40eca0fbe2 Merge branch 'master' into multiplayer-auto-countdown 2022-03-24 18:11:51 +09:00
d7faff15c0 Merge pull request #17326 from smoogipoo/multiplayer-countdown-timers-2
Implement multiplayer countdown timers
2022-03-24 17:50:53 +09:00
0275e974e5 Merge branch 'master' into multiplayer-countdown-timers-2 2022-03-24 17:24:00 +09:00
e3f8bc0588 Revert Availability to private 2022-03-24 17:15:17 +09:00
528ffea38d Fix incorrect event binding 2022-03-24 17:11:08 +09:00
dfa076c169 Refactor cancellation logic 2022-03-24 16:29:59 +09:00
4c0d76573c Asserate code is running on update thread 2022-03-24 15:51:30 +09:00
f0d132b16e Rename FinishCountdown() -> SkipToEndOfCountdown() 2022-03-24 15:21:46 +09:00
d2ecc100e5 Revert unnecessary async change 2022-03-24 15:07:24 +09:00
8f3a4df70a Add explanation for try-catch 2022-03-24 15:07:24 +09:00
d36944ac95 Dispose token manually
Cover more branches with cancellation source disposal
2022-03-24 15:07:24 +09:00
96a447f68b Rename Multiplayer prefix to button classes 2022-03-24 14:28:38 +09:00
90c7945bca Re-remove PopoverButton class with better test fix 2022-03-24 14:26:31 +09:00
3b97de04b7 Merge pull request #17419 from peppy/fix-hitsound-regresssssssion
Fix hitsounds not always playing when they should
2022-03-24 11:53:18 +09:00
547418e47e Revert "Remove PopoverButton class"
This reverts commit 6b712be97d.
2022-03-24 11:15:51 +09:00
c079a9cd32 Add comment regarding equality check importance in LegacyHitSampleInfo 2022-03-23 20:18:44 +09:00
997c091a8d Revert "Remove IsLayered from LegacyHitSampleInfo comparison"
This reverts commit 4523393208.
2022-03-23 20:15:17 +09:00
2ea9e5245c Revert "Remove IsLayered from GetHasCode implementation"
This reverts commit 16ee6b5fc7.
2022-03-23 20:15:13 +09:00
34a367b369 Merge branch 'master' into multiplayer-countdown-timers-2 2022-03-23 15:40:50 +09:00
a83a90e675 Rename countdown Delay -> Duration 2022-03-23 15:21:16 +09:00
f7c0047206 Send time remaining in countdowns instead 2022-03-23 15:19:43 +09:00
999ddff3d4 Merge pull request #17414 from peppy/update-localisation-analyser
Update LocalisationAnalyser to support .net6
2022-03-23 11:41:11 +09:00
657daf07d7 Update LocalisationAnalyser to support .net6 2022-03-23 11:03:24 +09:00
d4ad4ac9db Limit countdown updates to once per second 2022-03-23 10:50:05 +09:00
6b712be97d Remove PopoverButton class 2022-03-23 10:40:38 +09:00
9138aaf780 Split MultiplayerReadyButton 2022-03-23 10:38:56 +09:00
1ffa1e1219 Merge pull request #17400 from nagilson/screen-mod-retention
Fix mods from single player carrying over to multiplayer
2022-03-23 08:36:15 +09:00
cda46ec8a3 Merge pull request #17403 from peppy/editor-exit-harsh-blocking
Disallow exiting the editor without saving (unless explicitly confirming)
2022-03-23 07:45:31 +09:00
8591630e5c Merge branch 'master' into editor-exit-harsh-blocking 2022-03-23 07:06:25 +09:00
d84865ff76 Merge pull request #17384 from peppy/hold-to-discard-changes
Add hold-to-confirm flow for discarding editor changes
2022-03-23 07:05:56 +09:00
51a1721bc9 Fix unprotected access to potentially-null DI'd dialog overlay 2022-03-22 22:10:05 +01:00
f3aad77239 Remove unused local variable 2022-03-22 22:00:24 +01:00
a38bafab91 Remove unused using directive 2022-03-22 22:00:05 +01:00
8647bebdca Merge branch 'master' into hold-to-discard-changes 2022-03-22 20:37:43 +01:00
2f01129322 Merge pull request #17386 from peppy/skin-editor-eat-input
Fix keyboard controls not working to adjust skin settings
2022-03-22 19:52:01 +01:00
8192fb47fe Merge branch 'master' into skin-editor-eat-input 2022-03-22 19:22:48 +01:00
c8d48f89e8 Remove unnecessary local 2022-03-22 19:13:22 +01:00
94c5207f36 Fix test not actually testing desired scenario anymore
The test was checking the test scene's own `SelectedMods` bindable
rather than the multiplayer screen's, and the former was never actually
being mutated by anything. Therefore the case would pass even on
`master` with the fix reverted.
2022-03-22 19:04:32 +01:00
6e55d7df02 Merge pull request #17406 from mcpower/vscode-recommended-extensions
Add C# extension to recommended VS Code extensions
2022-03-22 19:18:05 +09:00
5631726164 Add C# extension to recommended VS Code extensions
The [official C# extension] is maintained by Microsoft and enables
IDE-like support for C# in VS Code.

If a user opens this repository in VS Code, they will be prompted to
install it if they haven't already installed it. After installation, the
extension will also prompt the user to install the .NET SDK if it's not
found.

[official C# extension]: https://marketplace.visualstudio.com/items?itemName=ms-dotnettools.csharp
2022-03-22 20:33:27 +11:00
804e856160 Move and refactor test in line with functionality changes 2022-03-22 17:38:43 +09:00
ff8352b749 Merge branch 'master' into screen-mod-retention 2022-03-22 17:27:26 +09:00
483fb84b56 Fix typo in FinishCountdown method 2022-03-22 16:50:13 +09:00
2c4a6c2465 Add missing async safeties to new tests 2022-03-22 16:46:42 +09:00