a746cbc6ed
Fix failSample still playing after player left FailOverlay
2023-01-22 01:14:33 -03:00
da03abc812
Fix comment editor text boxes not having sound feedback
2023-01-21 17:32:42 -08:00
1c1c9915bb
Split saving new and existing beatmaps into separate flows
2023-01-22 10:27:33 +09:00
718cbf9382
Fix SegmentedGraph draw node calculating segment colours in unsafe manner
...
The `SegmentedGraph`'s draw node would call `getSegmentColour()`
on the drawable, which would query the `DrawColourInfo` and
`tierColours` properties of the drawable. This is a cross-thread access
and as such completely unsafe, as due to being cross-thread it can die
on invalidations or out-of-bounds accesses.
Fix by transferring everything to the draw node first before attempting
to draw. `SegmentedGraph.TierColours` setter already correctly
invalidates the draw node via `graphNeedsUpdate`, so no further
intervention was required there.
Closes #22326 .
2023-01-21 23:19:34 +01:00
d4e5d7a873
Move fixed scroll speed change out of classic mod for taiko
2023-01-21 22:29:28 +01:00
a1b5c9d910
Don't transfer MD5 hashes in collections when copying beatmaps
...
Fixes #22306 .
Changes beatmap saving so that by default it does not transfer
the hashes in collections, and only transfers them when saving the same
difficulty in the editor.
Issue seems to have been introduced in https://github.com/ppy/osu/pull/20641 .
2023-01-22 01:14:18 +09:00
292fd345bc
Merge pull request #22302 from ekrctb/fix-infinity-spm
...
Fix spinners potentially displaying incorrect SPM numbers
2023-01-21 16:56:34 +03:00
ce64ba471a
Merge branch 'master' into fix-infinity-spm
2023-01-21 15:42:48 +03:00
c2e1c91b58
Merge pull request #22315 from frenzibyte/fix-test-browser-broken
...
Fix test browsers on longer working after framework update
2023-01-21 21:34:08 +09:00
c48af79588
Fix test browsers on longer working after framework update
2023-01-21 14:49:47 +03:00
2a9b1ea9fc
Merge pull request #22310 from peppy/fix-threading-tournament-save
...
Fix incorrect async continuation causing tournament client to not enable save button
2023-01-21 15:31:56 +09:00
0fb12508f0
Fix incorrect async continuation causing tournament client to not enable save button
2023-01-21 11:28:56 +09:00
2075583313
Merge pull request #22303 from peppy/update-framework
...
Update framework
2023-01-21 00:30:59 +09:00
154c258248
Fix TournamentGameBase calling AddInternal
2023-01-20 23:53:30 +09:00
19450bfe12
Update framework
2023-01-20 23:23:25 +09:00
7e466e1eba
Fix SPM calculation division by zero
2023-01-20 21:00:01 +09:00
e86748626a
Merge pull request #22296 from frenzibyte/actually-fix-beatmap-options
2023-01-20 10:21:55 +09:00
684d05e9aa
Merge pull request #22297 from frenzibyte/fix-playlists-match-test-failure
2023-01-20 10:19:45 +09:00
8174ef06c3
Fix intermittent failure in playlists match loading test
2023-01-20 01:18:41 +03:00
f0464b0340
Actually fix intermittent failure in beatmap options state test
2023-01-19 22:47:35 +03:00
5a1940facf
Merge pull request #22290 from mk56-spn/judgement_fix
...
Fix JudgementCounterDisplay.cs max judgement not hiding upon display mode change
2023-01-19 20:00:44 +09:00
2ce32e3209
Refactor update logic to be easier to follow
2023-01-19 19:27:05 +09:00
b22363ed8c
Fix JudgementCounterDisplay.cs max judgement always showing upon changing display mode
2023-01-19 10:31:02 +01:00
c6dfbab702
Merge pull request #22283 from Feodor0090/comment-reply
...
Add ability to leave replies to comments
2023-01-19 16:41:05 +09:00
4916a742d5
Immediately focus the textbox when clicking to reply to a comment
2023-01-19 16:08:27 +09:00
81e6c3792c
Remove unused method
2023-01-19 16:03:46 +09:00
56ce8504ae
Merge branch 'master' into comment-reply
2023-01-19 16:01:47 +09:00
07af18b8a7
Remove ReplyCommentEditor into its own class
2023-01-19 16:01:37 +09:00
db8084570d
Merge pull request #22285 from bdach/segmented-graph-tint
...
Apply draw colour to segmented graph
2023-01-19 13:36:19 +09:00
e58abf7d1a
Merge pull request #22284 from bdach/judgement-counter-broken
...
Fix "show max judgement" setting not applying initially on judgement counter display
2023-01-19 09:09:06 +09:00
83c38a8960
Merge pull request #22233 from peppy/osu-ruleset-multi-touch-basic
...
Add basic multi-touch support for osu! ruleset
2023-01-19 00:59:45 +01:00
2fba80dfd3
Merge branch 'master' into osu-ruleset-multi-touch-basic
2023-01-19 00:26:57 +01:00
593f5f6d56
Merge pull request #22144 from ItsShamed/skin/argon-song-progress-cleaner
...
Add "argon" variant of song progress display
2023-01-19 00:25:39 +01:00
a0fe71c706
Use alternative segment colour computation method
2023-01-19 00:08:32 +01:00
b62ff8d644
Merge branch 'master' into skin/argon-song-progress-cleaner
2023-01-18 23:52:12 +01:00
b8b7442eb8
Make SongProgressInfo.ShowProgress init-only (and remove duplicate init)
2023-01-18 23:35:40 +01:00
903c37bf32
Apply draw colour to segmented graph segments
2023-01-18 23:17:57 +01:00
e09b768a99
Add test steps demonstrating failure
2023-01-18 23:07:40 +01:00
f8d8a627b8
change property name
2023-01-18 22:00:39 +01:00
769f8c6190
Fix ShowMaxJudgement callback conflicting with JudgementCounter.Pop{In,Out}
...
Both `JudgementCounterDisplay` (via the `ShowMaxJudgement` callback)
and the `JudgementCounter.Pop{In,Out}` methods were operating on the
alpha of the `JudgementCounter`. This meant that if the counter display
was created with max judgement initially hidden, it would be hidden
by the `ShowMaxJudgement` callback first, but then _unhidden_
by `PopIn()`.
2023-01-18 21:46:28 +01:00
40e99069fc
fix typos and newlines
2023-01-18 21:43:09 +01:00
7299d227d1
Add failing test case
2023-01-18 21:42:22 +01:00
06212bca51
Restructure test scene to demonstrate failure
2023-01-18 21:41:00 +01:00
ab78dd0436
add collection of selection points.
2023-01-18 21:34:23 +01:00
7f4d8bdcaa
Add test
2023-01-18 21:27:42 +03:00
77bc4fbf70
Integrate editor into comment
2023-01-18 20:50:07 +03:00
0d91277ea5
Add ability to change number on replies button
2023-01-18 20:49:30 +03:00
c74500b4b4
Add reply editor
2023-01-18 20:49:07 +03:00
761298cd8e
Merge pull request #22275 from peppy/fix-legacy-old-judgement-animation
...
Fix legacy judgement animation not matching perfectly
2023-01-18 18:27:13 +01:00
150195b887
use extension method to check accuracy impact
2023-01-18 12:24:41 -05:00
