Commit Graph

49943 Commits

Author SHA1 Message Date
def2ce243f Merge pull request #17431 from peppy/fix-participants-panel-null-ref
Guard against potential null `CurrentItem` in `ParticipantPanel`
2022-03-25 11:47:43 +09:00
e58b742728 Merge pull request #17429 from peppy/fix-old-legacy-replays
Fix replays set on old beatmaps having incorrect timing
2022-03-24 23:45:42 +01:00
5f730c0cd4 Merge branch 'master' into fix-old-legacy-replays 2022-03-24 23:21:50 +01:00
959f200638 Merge pull request #17425 from peppy/fix-realm-import-test-assert-failure
Fix realm potentially not being refreshed in time for test asserts in `BeatmapImporterTests`
2022-03-24 22:16:25 +01:00
878e8d21a3 Remove assertion to fix "expression always true" inspection 2022-03-24 21:51:10 +01:00
b76cd2beae Merge branch 'master' into fix-realm-import-test-assert-failure 2022-03-24 21:48:10 +01:00
2d58feebb1 Guard against potential null CurrentItem in ParticipantPanel 2022-03-24 17:54:21 +09:00
e889d93441 Add asserts of playlist being non-empty after client operations 2022-03-24 17:52:20 +09:00
d7faff15c0 Merge pull request #17326 from smoogipoo/multiplayer-countdown-timers-2
Implement multiplayer countdown timers
2022-03-24 17:50:53 +09:00
0275e974e5 Merge branch 'master' into multiplayer-countdown-timers-2 2022-03-24 17:24:00 +09:00
e3f8bc0588 Revert Availability to private 2022-03-24 17:15:17 +09:00
528ffea38d Fix incorrect event binding 2022-03-24 17:11:08 +09:00
d6fc53579e Split out shared code for encode-decode cycle (and remove unrelated culture set) 2022-03-24 17:00:49 +09:00
a7554dcdf7 Use a constant for the early version timing offset 2022-03-24 16:43:41 +09:00
2efae031c9 Add test coverage of decode specifically 2022-03-24 16:39:56 +09:00
59a7eb5322 Add test coverage ensuring offsets are correct before and after legacy replay encode 2022-03-24 16:34:21 +09:00
dfa076c169 Refactor cancellation logic 2022-03-24 16:29:59 +09:00
a7d5f2281c Apply beatmap offsets to legacy replay frame handling 2022-03-24 16:16:40 +09:00
4c0d76573c Asserate code is running on update thread 2022-03-24 15:51:30 +09:00
f0d132b16e Rename FinishCountdown() -> SkipToEndOfCountdown() 2022-03-24 15:21:46 +09:00
d2ecc100e5 Revert unnecessary async change 2022-03-24 15:07:24 +09:00
8f3a4df70a Add explanation for try-catch 2022-03-24 15:07:24 +09:00
d36944ac95 Dispose token manually
Cover more branches with cancellation source disposal
2022-03-24 15:07:24 +09:00
96a447f68b Rename Multiplayer prefix to button classes 2022-03-24 14:28:38 +09:00
90c7945bca Re-remove PopoverButton class with better test fix 2022-03-24 14:26:31 +09:00
4d0b4c2541 Fix realm potentially not being refreshed in time for test asserts in BeatmapImporterTests
As seen at https://github.com/ppy/osu/runs/5659368512?check_suite_focus=true

Went through every usage of `.Import` and added either an
`EnsureLoaded`, or where that provides too many checks, an explicit
`realm.Refresh()`.
2022-03-24 12:59:17 +09:00
3b97de04b7 Merge pull request #17419 from peppy/fix-hitsound-regresssssssion
Fix hitsounds not always playing when they should
2022-03-24 11:53:18 +09:00
547418e47e Revert "Remove PopoverButton class"
This reverts commit 6b712be97d.
2022-03-24 11:15:51 +09:00
c079a9cd32 Add comment regarding equality check importance in LegacyHitSampleInfo 2022-03-23 20:18:44 +09:00
997c091a8d Revert "Remove IsLayered from LegacyHitSampleInfo comparison"
This reverts commit 4523393208.
2022-03-23 20:15:17 +09:00
2ea9e5245c Revert "Remove IsLayered from GetHasCode implementation"
This reverts commit 16ee6b5fc7.
2022-03-23 20:15:13 +09:00
34a367b369 Merge branch 'master' into multiplayer-countdown-timers-2 2022-03-23 15:40:50 +09:00
a83a90e675 Rename countdown Delay -> Duration 2022-03-23 15:21:16 +09:00
f7c0047206 Send time remaining in countdowns instead 2022-03-23 15:19:43 +09:00
999ddff3d4 Merge pull request #17414 from peppy/update-localisation-analyser
Update LocalisationAnalyser to support .net6
2022-03-23 11:41:11 +09:00
657daf07d7 Update LocalisationAnalyser to support .net6 2022-03-23 11:03:24 +09:00
d4ad4ac9db Limit countdown updates to once per second 2022-03-23 10:50:05 +09:00
6b712be97d Remove PopoverButton class 2022-03-23 10:40:38 +09:00
9138aaf780 Split MultiplayerReadyButton 2022-03-23 10:38:56 +09:00
1ffa1e1219 Merge pull request #17400 from nagilson/screen-mod-retention
Fix mods from single player carrying over to multiplayer
2022-03-23 08:36:15 +09:00
cda46ec8a3 Merge pull request #17403 from peppy/editor-exit-harsh-blocking
Disallow exiting the editor without saving (unless explicitly confirming)
2022-03-23 07:45:31 +09:00
8591630e5c Merge branch 'master' into editor-exit-harsh-blocking 2022-03-23 07:06:25 +09:00
d84865ff76 Merge pull request #17384 from peppy/hold-to-discard-changes
Add hold-to-confirm flow for discarding editor changes
2022-03-23 07:05:56 +09:00
51a1721bc9 Fix unprotected access to potentially-null DI'd dialog overlay 2022-03-22 22:10:05 +01:00
f3aad77239 Remove unused local variable 2022-03-22 22:00:24 +01:00
a38bafab91 Remove unused using directive 2022-03-22 22:00:05 +01:00
8647bebdca Merge branch 'master' into hold-to-discard-changes 2022-03-22 20:37:43 +01:00
2f01129322 Merge pull request #17386 from peppy/skin-editor-eat-input
Fix keyboard controls not working to adjust skin settings
2022-03-22 19:52:01 +01:00
8192fb47fe Merge branch 'master' into skin-editor-eat-input 2022-03-22 19:22:48 +01:00
c8d48f89e8 Remove unnecessary local 2022-03-22 19:13:22 +01:00