Commit Graph

10088 Commits

Author SHA1 Message Date
1ce0e83e59 Merge branch 'master' into skinnable-score-display 2020-10-15 19:16:03 +09:00
93dfbd5d9e Merge pull request #10505 from peppy/skin-disabler-refactor
Move ISampleDisabler implementation to Player and FrameStabilityContainer
2020-10-15 19:14:52 +09:00
70806deba1 Add support for bottom-anchored hit error display 2020-10-15 19:14:02 +09:00
d76365ed1b Make container readonly 2020-10-15 18:38:41 +09:00
5640d33d1a Merge branch 'master' into skin-disabler-refactor 2020-10-15 18:32:50 +09:00
6983978c98 Correct top-right element offset by finding the lower top anchor element 2020-10-15 18:30:44 +09:00
b31a3fbabb Add test 2020-10-15 18:11:30 +09:00
254eba9008 Add and consume skinnable accuracy counter 2020-10-15 17:53:16 +09:00
90ff8ff050 Merge branch 'skinnable-combo-counter' into skinnable-score-display 2020-10-15 17:52:06 +09:00
37e9f331ad Simplify score font lookup 2020-10-15 17:49:55 +09:00
43e5cb90e2 Merge branch 'skinnable-combo-counter' into skinnable-score-display 2020-10-15 17:30:29 +09:00
9f51327e4b Fix completely incorrect default positioning logic 2020-10-15 17:29:40 +09:00
5b5ba7df93 Remove unused offset 2020-10-15 17:22:34 +09:00
d8d085ede9 Align top-right elements with lowest point in score display 2020-10-15 17:14:42 +09:00
74c031cfbb Fix ModOverlay not including "UNRANKED" text in size 2020-10-15 17:14:42 +09:00
b210147c2e Update combo counter to read from default score display's position correctly 2020-10-15 17:14:42 +09:00
950c47287c Fix positioning of score display in HUD overlay 2020-10-15 17:14:42 +09:00
e1da64398e Add and consume skinnable score counter 2020-10-15 17:14:42 +09:00
219cbec6bd Split out DefaultScoreCounter and make ScoreCounter abstract 2020-10-15 16:32:30 +09:00
d5f2aab52e Tidy up SkinnableComboCounter class slightly 2020-10-15 15:37:40 +09:00
e0210f5c4c Ignore failed casts to make tests happy 2020-10-14 23:52:58 +09:00
e3eaba7b2c Move ISampleDisabler implementation to Player and FrameStabilityContainer 2020-10-14 19:39:48 +09:00
ac4f56403d Adjust size/position 2020-10-14 19:16:34 +09:00
7f5ea57bd4 Clean-up pass (best effort) on LegacyComboCounter 2020-10-14 19:16:34 +09:00
9bb8a43bce Combine LegacyComboCounter and ComboCounter classes 2020-10-14 19:16:34 +09:00
fbbea48c8c Add score text skinnability 2020-10-14 19:16:34 +09:00
2fce064e32 Add basic legacy combo counter and updating positioning logic 2020-10-14 19:16:34 +09:00
6a6718ebab Allow bypassing origin/anchor setting of skinnable components
It makes little sense to set these when using RelativeSizeAxes.Both
2020-10-14 19:16:34 +09:00
899bac6ca5 Rename catch combo counter for clarity 2020-10-14 19:16:34 +09:00
f5623ee21e Setup skinnable combo counter component with default implementation 2020-10-14 19:16:34 +09:00
60603d2918 Add skin components and interfaces 2020-10-14 19:16:34 +09:00
98acf1e31d Make field read only 2020-10-14 19:16:25 +09:00
a7f8e26e35 Adjust bottom-right elements positions based on song progress display 2020-10-14 18:51:53 +09:00
0cf3e90904 Update SongProgress height based on its dynamic height during resize 2020-10-14 18:44:22 +09:00
ace9fbc8d3 Confine available area for HUD components to excluse the song progress area 2020-10-14 18:44:22 +09:00
30e1fce7a4 Reduce alloc overhead of DrawableCarouselBeatmapSet using new function-based ctor 2020-10-14 15:10:50 +09:00
07e6609e6d Disable difficulty calculation for set-level difficulty icons 2020-10-14 14:16:22 +09:00
e662dc5342 Add missing licence headers 2020-10-13 20:57:26 +09:00
8057ea1097 Fix formatting issues 2020-10-13 20:50:36 +09:00
3d416f4d64 Clean up beatmapSet resolution in DrawableCarouselBeatmapSet 2020-10-13 19:31:29 +09:00
75b6a5e17e Remove unnecessary hack (fixed via framework update) 2020-10-13 19:31:29 +09:00
5d11db7753 Locallise ChildItems to DrawableCarouselBeatmapSet for clarity 2020-10-13 19:31:29 +09:00
37daefc2b5 Remove outdated comment 2020-10-13 19:12:33 +09:00
8eca28e8bc Add comment about off-screen loading 2020-10-13 19:10:35 +09:00
834b0186f4 Adjust fade duration to be slightly shorter 2020-10-13 18:50:10 +09:00
2346644c04 Switch DelayedLoadUnloadWrappers to DelayedLoadWrappers
Due to pooling usage, there is no time we need to unload. Switching to
DelayedLoadWrapper cleans up the code and reduces overhead
substantially.
2020-10-13 18:47:40 +09:00
a1801f8ae4 Unmark todo for now 2020-10-13 18:47:36 +09:00
40a0ab7aaa Avoid allocating CarouselItems for bounds checks 2020-10-13 18:33:31 +09:00
4f4f222514 Remove unnecessary fade (already applied by base DrawableCarouselItem) 2020-10-13 18:28:28 +09:00
83358d487f Remove logging 2020-10-13 18:18:22 +09:00