Commit Graph

1266 Commits

Author SHA1 Message Date
e097b6e61c Add ScalingContainer back
Don't want to set DHO.Scale or DHO.Rotation because because DHO may be transformed by mods.
DHO.Size is also assigned for drawable visualizer
2020-12-10 19:42:01 +09:00
ac91f0e270 Add extended limits to difficulty adjustment mod 2020-12-10 00:37:19 +09:00
a8e2f35b62 Remove unneeded check of caught object removal
The logic was public but now it is private
so the condition is ensured by the caller
2020-12-09 10:50:35 +09:00
775c4bad97 Remove unneeded lifetime assignment 2020-12-09 10:47:04 +09:00
da2f3d4473 Move classes to separate files 2020-12-09 10:40:42 +09:00
b52e279702 Reword exception message 2020-12-09 10:38:11 +09:00
86445e7c23 Remove unnecessary copy 2020-12-09 10:36:54 +09:00
c8b0934573 Rename caughtFruitContainer -> caughtObjectContainer 2020-12-09 10:35:36 +09:00
ccca7e0b25 more specific type droppedObjectContainer 2020-12-09 10:35:01 +09:00
df9de7a8dd Remove null check that is not required anymore 2020-12-09 10:28:42 +09:00
b80204642e Revert rename error 2020-12-09 10:25:35 +09:00
1212ffd24f Rename to CopyStateFrom, and add comment 2020-12-08 23:35:24 +09:00
5ca98b0033 Add doc comments a bit 2020-12-08 23:11:22 +09:00
1f36bbecd1 Fix dropped objects not removed on revert result 2020-12-08 23:07:30 +09:00
749d5380ca Pool caught objects and dropped objects 2020-12-08 22:38:10 +09:00
a32dac00dd Introduce IHasCatchObjectState implemented by DHO and CaughtObject 2020-12-08 21:29:26 +09:00
c301223d8c Make object on the catcher plate separate CaughtObject class 2020-12-08 21:11:40 +09:00
94a59ac3b2 Make catch hit lighting logic not dependent on caught object 2020-12-08 20:41:26 +09:00
004c705aa9 Remove ScaleContainer and flatten the Drawable tree of catch DHO 2020-12-08 20:37:08 +09:00
56721a6fa9 Compute object position in stack via a pure function 2020-12-08 20:36:59 +09:00
0739f09930 Merge pull request #11110 from ekrctb/fruit-piece-in-place
Implement in-place update of catch DrawableHitObject
2020-12-08 18:36:20 +09:00
c3241f163d Merge pull request #11126 from ekrctb/fix-catcher-trail-sprite-pooled
Clear all transforms of catcher trail sprite before returned to pool
2020-12-08 17:59:23 +09:00
1757b9c3e7 Merge branch 'master' into fruit-piece-in-place 2020-12-08 17:42:34 +09:00
22a5df6309 Clear all transforms of catcher trail sprite before returned to pool 2020-12-08 17:31:00 +09:00
4d5c242d35 Use virtual property instead of a field for optional pieces 2020-12-08 17:15:40 +09:00
603cecb2eb Make CatchHitObjectPiece abstract class 2020-12-08 17:02:57 +09:00
17d48c82f6 Use switch statement instead of an array 2020-12-08 16:59:06 +09:00
02571ec7ae Remove hit explosion on revert result 2020-12-08 15:43:17 +09:00
1a66d8f2bc Remove caught objects on revert result 2020-12-08 15:24:39 +09:00
100b365c98 Restore hyper dash state on revert judgement result 2020-12-08 15:21:47 +09:00
cb76a2d7b5 Restore catcher state on revert judgement result 2020-12-08 15:03:03 +09:00
0213f77b4b Move catcher state changing logic to OnNewResult method 2020-12-08 14:28:30 +09:00
4da6717d0e Rename things in PulpFormation 2020-12-08 10:33:18 +09:00
3cbdaf5960 Make resolved properties protected 2020-12-08 10:30:23 +09:00
b2e5658d23 Merge branch 'master' into fruit-piece-in-place 2020-12-07 18:57:42 +09:00
fb599e0746 Merge pull request #11114 from ekrctb/pool-catcher-trail
Pool catcher trail sprite
2020-12-07 18:48:08 +09:00
12c6b3c1fb Pool catcher trail sprite 2020-12-07 18:12:55 +09:00
c1d39b6401 Don't inherit Fruit from Banana 2020-12-07 14:10:17 +09:00
7f1ad1040d Don't inherit DrawableFruit from DrawableBanana
- A banana cannot be hyper
2020-12-07 14:08:50 +09:00
c0f39514b9 Fix legacy droplet scale 2020-12-07 14:00:22 +09:00
b8f1c499a4 Allow PulpFormation to update formation dynamically
Pulps are lazily allocated but never deallocated for a DrawableFruit
2020-12-07 13:56:22 +09:00
0d73bf8488 Refactor catch default piece to allow reuse
But Fruit in-place update is still incomplete,
as child drawables are recreated when reused.
2020-12-07 13:14:00 +09:00
d51d2c5331 Don't recreate pieces when catch DHO is reused 2020-12-07 12:59:03 +09:00
87189452d1 Refactor legacy skin piece to allow texture update 2020-12-07 12:57:24 +09:00
d18397acad Adjust namespace 2020-12-07 12:35:24 +09:00
b4b9312e0f Move piece files of Catch ruleset 2020-12-07 12:34:38 +09:00
d3a17b65d5 Move public methods upwards 2020-12-04 14:36:40 +09:00
8988023407 Tidy up code formatting and remove unnecessarily publicly exposed methods 2020-12-04 14:35:56 +09:00
aa24890aff Merge branch 'master' into caught-object-refactor 2020-12-04 14:12:33 +09:00
0134ac94a7 Merge pull request #11055 from ekrctb/catch-stateless-rng 2020-12-04 13:08:30 +09:00