Commit Graph

45886 Commits

Author SHA1 Message Date
e5d229f005 Merge branch 'beatmap-refactor/remove-online-info' into beatmap-refactor/to-model-removal-2 2021-11-05 01:16:43 +09:00
630d63101d Merge branch 'master' into beatmap-refactor/to-model-removal-2 2021-11-05 01:16:42 +09:00
7049d0de66 Merge branch 'master' into beatmap-refactor/remove-online-info 2021-11-05 01:16:11 +09:00
78ed77805f Merge pull request #15468 from smoogipoo/upgrade-nvika
Use official nvika package again
2021-11-04 15:16:03 +03:00
9846596c02 Merge branch 'master' into upgrade-nvika 2021-11-04 14:48:42 +03:00
66509264ff Merge pull request #15467 from peppy/update-framework
Update framework
2021-11-04 20:19:56 +09:00
4b46833ee9 Merge branch 'master' into upgrade-nvika 2021-11-04 13:53:30 +03:00
aa2711e6ec Merge branch 'master' into update-framework 2021-11-04 13:51:57 +03:00
f12a2c7767 Merge pull request #15458 from peppy/beatmap-refactor/playlist-use-api-beatmap-extended
Refactor `PlaylistItem` to allow `Beatmap` to be an interfaced type
2021-11-04 19:23:33 +09:00
30635fb476 Use official nvika package again 2021-11-04 19:19:00 +09:00
28e9b9a25f Update framework 2021-11-04 19:01:39 +09:00
45dcf187b9 Merge branch 'master' into beatmap-refactor/playlist-use-api-beatmap-extended 2021-11-04 18:59:04 +09:00
df3c3a32ce Fix unintentionally broken background update logic 2021-11-04 18:07:39 +09:00
388c074c15 Merge pull request #15464 from peppy/fix-crash-on-gameplay
Fix crash on gameplay startup if beatmap has no background
2021-11-04 18:07:10 +09:00
b80c02b757 Fix crash on gameplay startup if beatmap has no background 2021-11-04 17:24:40 +09:00
eb17d897a3 Finally, remove the To* methods as they have no usages 2021-11-04 17:09:53 +09:00
08d94f864f Update ScoresContainer to not use ToBeatmapInfo 2021-11-04 17:09:53 +09:00
7bab487621 Remove usage of ToBeatmapInfo in APIScoreInfo.CreateScoreInfo 2021-11-04 17:09:53 +09:00
8a873bd6b1 Merge branch 'beatmap-refactor/playlist-use-api-beatmap-extended' into beatmap-refactor/to-model-removal-2 2021-11-04 17:09:51 +09:00
d2831b1152 Merge branch 'beatmap-refactor/remove-online-info' into beatmap-refactor/to-model-removal-2 2021-11-04 17:09:50 +09:00
77be610b26 Revert "Clean up DirectDownloadButton test scene"
This reverts commit baabe99f78.
2021-11-04 17:09:20 +09:00
5a078da4d9 Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues 2021-11-04 16:50:14 +09:00
c820d445ad Merge pull request #15461 from peppy/fix-more-computationally-expensive
Fix a few more "maybe null" inspections
2021-11-04 16:49:38 +09:00
e50c961185 Merge pull request #15312 from jaswon/editor-context-menu-on-select
Fix editor context menu requiring two right-clicks to display
2021-11-04 16:49:19 +09:00
a9eef4199a Merge pull request #15460 from smoogipoo/upgrade-nvika
Upgrade to nvika 1.0.4
2021-11-04 16:47:23 +09:00
8f459e6ce8 Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues 2021-11-04 16:44:17 +09:00
baabe99f78 Clean up DirectDownloadButton test scene 2021-11-04 16:28:29 +09:00
317506d4d7 Fix a few more "maybe null" inspections 2021-11-04 16:11:23 +09:00
63cfa69bd1 Merge branch 'master' into upgrade-nvika 2021-11-04 16:10:23 +09:00
0c14d8af23 Upgrade to nvika 1.0.4 2021-11-04 16:03:59 +09:00
09701d0af1 Use explicit primitive type specification 2021-11-04 16:02:37 +09:00
0f4f1349db Merge branch 'master' into editor-context-menu-on-select 2021-11-04 15:59:06 +09:00
222c3e552b Merge pull request #15456 from peppy/beatmap-refactor/beatmap-metadata-nullable-enable
Enable nullable support on `BeatmapMetadata`
2021-11-04 15:47:18 +09:00
a5a7181915 Fix unintentionally broken background update logic 2021-11-04 15:35:32 +09:00
4b1b92cde6 Stop BeatmapInfo from implementing IBeatmapOnlineInfo and remove all usages 2021-11-04 15:23:04 +09:00
9c926e5514 Remove BeatmapSetInfo.OnlineInfo and all usages 2021-11-04 15:23:04 +09:00
66f4516eee Allow creating sample API models without specifying a ruleset 2021-11-04 15:23:04 +09:00
e3a9fbecfe Add method to create sample APIBeatmap (with BeatmapSet populated) 2021-11-04 15:23:04 +09:00
0d0eab90bc Merge branch 'beatmap-refactor/playlist-use-api-beatmap-extended' into beatmap-refactor/remove-online-info 2021-11-04 15:23:02 +09:00
8733767416 Merge branch 'beatmap-refactor/beatmap-metadata-nullable-enable' into beatmap-refactor/remove-online-info 2021-11-04 15:23:02 +09:00
84d36cbae7 Add fallback for cases where BeatmapSet may be null
Seems to only happen in tests, but better safe than sorry.
2021-11-04 15:22:33 +09:00
e43d91ad5d Fix another case of incorrect null checking in editor verification processing 2021-11-04 15:18:10 +09:00
09f9731d74 Add temporary disable of failing r# inspection 2021-11-04 15:09:04 +09:00
d1e6d1cb98 Update some other missed incorrect null/empty usages 2021-11-04 14:50:43 +09:00
a49366ff84 Remove nullability from IBeatmapInfo.Metadata 2021-11-04 14:28:39 +09:00
1e73b09e57 Fix another couple of cases of incorrect string null/empty checking 2021-11-04 14:22:28 +09:00
41854f2e16 Fix incorrect check on AudioFile presence 2021-11-04 14:02:09 +09:00
67d9590a79 Fix new inspections 2021-11-04 14:02:09 +09:00
0df339d0b8 Fix incorrect invocation of download method in SoloSpectator 2021-11-04 13:50:04 +09:00
0ab50f1cc9 Add inline comment explaining why we are manually populating beatmap.BeatmapSet 2021-11-04 13:45:59 +09:00