Commit Graph

38441 Commits

Author SHA1 Message Date
298989ffd2 Merge branch 'master' into sample-set-controls 2023-05-24 14:03:04 +09:00
067328233c Remove OsuScreen.ApplyLogoArrivingDefaults() 2023-05-23 13:17:43 -07:00
adf9a596b5 Fix weird state when attempting to enter gameplay skin editor scene from multiplayer
Closes https://github.com/ppy/osu/issues/23626.
2023-05-23 17:58:44 +09:00
ff5dde0ebe Merge pull request #23575 from Joehuu/fix-inverted-video-only-check
Fix old widescreen videos with black bars not correctly filling screen (again)
2023-05-23 16:47:52 +09:00
7c039b0b67 Merge pull request #23618 from bdach/fix-taiko-swells-drumrolls-silent
Fix hitsounds not playing before and during taiko drum rolls and swells
2023-05-23 16:44:04 +09:00
38b4bd8aef Fix undo not behaving as expected sometimes 2023-05-22 22:45:39 +02:00
e0b7539c2a Fix sample changes not being applied in patcher 2023-05-22 22:45:23 +02:00
f253d17a7f Fix slider velocity changes not being applied in patcher 2023-05-22 22:19:10 +02:00
7742904d2a Merge pull request #23593 from Dimmitsaras/unfocused-notifications
Always show chat message notifications if window is unfocused
2023-05-22 14:17:20 +09:00
09c66bea8f Merge pull request #23606 from Joehuu/fix-news-sidebar-link-clicking-area
Fix clicking area of news sidebar post links
2023-05-22 14:17:08 +09:00
7392109bce Apply same behavioral changes to NewsCard 2023-05-21 19:28:12 -07:00
2279aad360 Apply NRT to NewsCard 2023-05-21 19:27:20 -07:00
b3527b92b6 Handle case in tests where current display becomes null 2023-05-22 09:25:44 +09:00
19816ae013 Update framework 2023-05-21 20:38:27 +02:00
6df1d29862 Merge branch 'master' into use-atomic-ReplaceRange 2023-05-21 20:32:59 +02:00
88c112612f Remove hardcoded website url
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-05-21 10:35:22 -07:00
5229cf7343 Add failing test cases for drum roll/swell sample playback 2023-05-21 18:57:01 +02:00
8aefb62532 Rename PostButton to PostLink 2023-05-20 16:38:56 -07:00
ec5f0bbf42 Fix clicking area of news sidebar post links
Side effect is that the hover color is yellow and pressing it opens an external dialog, but those are temporary (pending implementation of link underline to make `Light1` hover more readable and set at a higher level and news pages).
2023-05-20 16:32:04 -07:00
de5917b645 Merge branch 'master' into unfocused-notifications 2023-05-20 19:32:52 +02:00
a677d87d39 Touch up inline comments 2023-05-20 19:29:59 +02:00
8e0a97ca49 Remove usage of HasSubmenu
Property has been removed in the appropriate framework-side PR and
instead folded into `IsActionable`.

See: https://github.com/ppy/osu-framework/pull/5658#discussion_r1114834647
2023-05-20 18:02:12 +02:00
67c044773b Merge branch 'master' into fix-menu-state-display 2023-05-20 17:57:00 +02:00
afdddb0195 Merge pull request #23582 from peppy/placement-blueprint-timeline-combo-fixes
Fix timeline blueprint display not showing correct combo number / colour during placement
2023-05-20 15:02:55 +02:00
0e11adaaac Merge pull request #23564 from peppy/fix-missing-sample-additions
Fix sample banks not transferring when adjusting via editor
2023-05-20 14:36:45 +02:00
ee522253cb Remove a couple of unnecessary volume declarations 2023-05-18 14:12:57 +09:00
9ca1c7f7b7 Merge pull request #23580 from peppy/fix-profile-button-depth
Ensure scroll-to-top button is displayed above all overlay content
2023-05-17 21:23:46 +02:00
7ac6688a0f Chat message notifications always play on unfocused window 2023-05-17 18:34:39 +03:00
b58ab28765 Make EditorClock non-nullable in PlacementBlueprint 2023-05-17 21:40:52 +09:00
214d7e07fa Add TODO regarding failing stack display code 2023-05-17 17:52:17 +09:00
0b25818bd2 Update combo information on placement blueprint 2023-05-17 17:26:19 +09:00
9563d4f730 Fix weird purple tint on placement object in timeline 2023-05-17 17:26:19 +09:00
8d925c8a8a Move combo information updating to an interface level helper method 2023-05-17 17:26:19 +09:00
e43f2c2c43 Improve previous hitobject lookup efficient and correctness 2023-05-17 17:19:29 +09:00
7d7d402d4e Apply NRT to PlacementBlueprint 2023-05-17 17:19:29 +09:00
79e1d978e7 Ensure scroll-to-top button is displayed above all overlay content 2023-05-17 15:42:38 +09:00
764f0323f4 Show "rewind" text on random button when beginning a right mouse press 2023-05-17 14:51:40 +09:00
94b184712d Fix random button hover state not correctly being reset on right click 2023-05-17 14:51:40 +09:00
dc421bd2af Revert "Merge pull request #23570 from huoyaoyuan/inspect-code-cs11"
This reverts commit ab2bd123e7, reversing
changes made to 267e63320f.
2023-05-17 14:49:47 +09:00
510ebe1f23 Fix weird optional usage in HitSampleInfo.With 2023-05-17 14:11:52 +09:00
dc51d5ecf3 Rename GetSampleInfo to better describe what method does
Also add full xmldoc
2023-05-17 14:07:48 +09:00
a8bc337006 Change default volume when constructing a HitSampleInfo to non-zero 2023-05-17 14:06:02 +09:00
fec47fa690 Merge branch 'master' into use-atomic-ReplaceRange
This reverts 0dcf1b540e
2023-05-17 06:56:54 +02:00
d6fa44240d Fix storyboard video-only check being inverted 2023-05-16 21:51:32 -07:00
0d3c64dc32 Merge pull request #23572 from bdach/avoid-display-settings-feedback
Work around issues with bindable/event feedback in layout settings
2023-05-17 12:03:45 +09:00
2d7fe68311 Prevent feedback by using atomic .ReplaceRange()
`display.NewValue` will never be null, checked on SDL + osuTK/Android.

On Android it's a 0x0 display, importantly not null.
2023-05-16 21:57:31 +02:00
0dcf1b540e Attempt to preserve old resolution when switching displays 2023-05-16 21:14:09 +02:00
88ce627c8e Avoid bindable/event feedback when changing resolution 2023-05-16 21:02:23 +02:00
ddfdd712bd Update InspectCode to 2022.3.3 and enable C# 11 2023-05-17 00:07:06 +08:00
d9ae822966 Fix bank not correctly being assigned when adding sample additions in editor 2023-05-16 18:52:52 +09:00