22264f2ffe
Merge branch 'dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson-3.1.10' into dependency-updates
2021-01-01 21:22:38 +01:00
6cd838fd4b
Bump Microsoft.CodeAnalysis.BannedApiAnalyzers from 3.3.1 to 3.3.2
...
Bumps [Microsoft.CodeAnalysis.BannedApiAnalyzers](https://github.com/dotnet/roslyn-analyzers ) from 3.3.1 to 3.3.2.
- [Release notes](https://github.com/dotnet/roslyn-analyzers/releases )
- [Changelog](https://github.com/dotnet/roslyn-analyzers/blob/master/PostReleaseActivities.md )
- [Commits](https://github.com/dotnet/roslyn-analyzers/compare/v3.3.1...v3.3.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2021-01-01 17:55:04 +00:00
652b0ccd8f
Bump Microsoft.AspNetCore.SignalR.Client from 3.1.9 to 3.1.10
...
Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/aspnet/AspNetCore ) from 3.1.9 to 3.1.10.
- [Release notes](https://github.com/aspnet/AspNetCore/releases )
- [Commits](https://github.com/aspnet/AspNetCore/compare/v3.1.9...v3.1.10 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2021-01-01 17:54:11 +00:00
0fd2e368c1
Bump Microsoft.NET.Test.Sdk from 16.8.0 to 16.8.3
...
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest ) from 16.8.0 to 16.8.3.
- [Release notes](https://github.com/microsoft/vstest/releases )
- [Commits](https://github.com/microsoft/vstest/compare/v16.8.0...v16.8.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2021-01-01 17:53:41 +00:00
7441cfd94e
Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
...
Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/aspnet/AspNetCore ) from 3.1.9 to 3.1.10.
- [Release notes](https://github.com/aspnet/AspNetCore/releases )
- [Commits](https://github.com/aspnet/AspNetCore/compare/v3.1.9...v3.1.10 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2021-01-01 17:53:29 +00:00
988f9b98a1
Split button mods updating to private method
2021-01-01 16:16:00 +03:00
c1a1e3acc5
Revert drive-by changes
2021-01-01 15:40:40 +03:00
a031c8e0b6
Apply documentation suggestions
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2021-01-01 15:34:09 +03:00
ee664ad571
Add test coverage
2021-01-01 03:47:18 +03:00
2ce9599957
Copy selected mods properties into overlay's buttons
2021-01-01 03:47:13 +03:00
b4df2d6d43
Add method for copying properties from another mod
2021-01-01 03:46:09 +03:00
faed776112
Merge pull request #11382 from mcendu/move-health-meter
2020-12-31 22:39:49 +09:00
79755e1826
Merge branch 'master' into master
2020-12-31 14:36:16 +01:00
1e02f450a6
Merge branch 'master' into move-health-meter
2020-12-31 13:59:37 +01:00
17abe90c27
move SkinnableHealthDisplay
...
Similar components are in osu.Game.Screens.Play.HUD while this is not
2020-12-31 20:23:13 +08:00
7d9a61fbc1
Handle unobserved exceptions from ready button properly
2020-12-31 11:57:13 +01:00
2d279350ad
Catch multiplayer client-related unobserved exceptions better
...
Silencing an exception from a task continuation requires accessing
`task.Exception` in any way, which was not done previously if
`logOnError` was false.
To resolve without having to worry whether the compiler will optimise
away a useless access or now, just always log, but switch the logging
level. The unimportant errors will be logged as debug and therefore
essentially silenced on release builds (but could still be potentially
useful in debugging).
2020-12-31 11:39:42 +01:00
ec75efe124
Merge pull request #11379 from peppy/fix-perform-from-menu-nullref
...
Fix PerformFromMenuRunner failing if CurrentScreen is null
2020-12-31 19:10:21 +09:00
1b1447eb35
Merge branch 'master' into fix-perform-from-menu-nullref
2020-12-31 10:33:05 +01:00
00c6703c51
Inline complete method as well
...
For better guarantees that `finalAction` is actually called on the same
screen that `checkCanComplete()` was (uses result of one
`getCurrentScreen()` call throughout instead of calling multiple times).
2020-12-31 10:27:42 +01:00
f9196ae976
Fix PerformFromMenuRunner failing if CurrentScreen is null
2020-12-31 16:36:20 +09:00
6ebb267c66
Merge pull request #11346 from bdach/fix-changelog-regression
...
Fix changelog header staying dimmed after build show
2020-12-31 16:15:25 +09:00
8e7877a2a7
Merge branch 'master' into master
2020-12-30 23:36:39 +01:00
9b40334830
Merge pull request #1 from Susko3/fix-android-file-associations
...
Remove duplicate application/octet-stream
2020-12-30 23:35:36 +01:00
eb64e6bf4d
Remove duplicate application/octet-stream
2020-12-30 23:35:07 +01:00
f800448c87
Move game start logic to a higher level
2020-12-30 18:15:48 +01:00
d34609b98e
Rename On{ToggleReady -> ReadyClick}
2020-12-30 16:29:36 +01:00
dd87478690
Add helper IsHost property to Client
2020-12-30 16:29:19 +01:00
59f2017a13
Move BindValueChanged subscriptions to LoadComplete
2020-12-30 16:22:11 +01:00
669c42a38d
add remarks explaining HR SV multiplier
2020-12-30 20:57:41 +06:00
a45f9b63b9
Merge pull request #11373 from peppy/move-out-thread-safety
...
Move thread safety / locking logic from MultiplayerRoom
2020-12-30 23:27:36 +09:00
497d644a19
Move thread safety / locking logic from MultiplayerRoom
2020-12-30 20:24:50 +09:00
6596e3c5e8
Merge branch 'master' into fix-changelog-regression
2020-12-30 01:34:18 +09:00
575a00dd7d
Merge pull request #11359 from peppy/fix-error-spam-on-disconnection
2020-12-30 01:33:02 +09:00
3920dac8af
Merge branch 'master' into fix-error-spam-on-disconnection
2020-12-30 00:55:37 +09:00
3552034ffe
Update framework
2020-12-30 00:55:27 +09:00
013b9b62a1
add SV multipliers to taiko difficulty mods
2020-12-29 20:22:56 +06:00
4561911150
Merge pull request #11358 from peppy/remove-multiplayer-selection-poller
2020-12-29 13:27:33 +01:00
05f212eb3c
Merge branch 'master' into remove-multiplayer-selection-poller
2020-12-29 12:51:33 +01:00
f2163a471a
Trim missed reference to deleted member
2020-12-29 11:53:42 +01:00
33891aae12
Merge pull request #11361 from peppy/improve-failing-api-ux
2020-12-29 11:41:08 +01:00
4a85ee1374
Merge branch 'master' into improve-failing-api-ux
2020-12-29 11:01:36 +01:00
361d215ab4
Reword notification messages to match new logic
2020-12-29 10:56:59 +01:00
5d23199233
Trim redundant IsLoggedIn checks
2020-12-29 10:56:29 +01:00
ecb07ecca7
Merge pull request #11362 from peppy/remove-unused-lock-object
...
Remove unused lock object
2020-12-29 10:15:42 +01:00
cafa241ef3
Fix ready-up button getting stuck if server operation fails
2020-12-29 09:44:30 +01:00
6bbd0ecfac
Remove unused lock object
2020-12-29 17:39:00 +09:00
274730de34
Cache tracker in test scene to resolve test fails
2020-12-29 09:16:08 +01:00
e9b0652359
Move ready-up operation logic again to client
...
To salvage ready up button tests.
2020-12-29 09:16:02 +01:00
906a9b79b5
Show an error when forcefully exiting online play due to API failure
2020-12-29 16:47:36 +09:00
