Commit Graph

328 Commits

Author SHA1 Message Date
539643c72b Set loadable beatmap track to clock immediately in BDL
This reverts commit 84da247002.

Use loadable beatmap track for clock directly in BDL
2021-05-07 07:21:56 +03:00
84da247002 Fix editor clock using the wrong beatmap track on creation 2021-05-07 05:32:55 +03:00
9d8f0c854d Setup configuration item for editor hit animations 2021-04-21 18:05:40 +09:00
c6c91cd9a5 Refactor WaveformOpacityMenuItem to not receive whole config 2021-04-21 18:05:26 +09:00
7654df94f6 Merge pull request #12395 from frenzibyte/fix-cinema-ignore-settings
Fix beatmap background displayed if storyboard is hidden on "Cinema" mod
2021-04-14 14:31:03 +09:00
36510309d1 Merge EnableUserDim and IgnoreUserSettings to one bindable 2021-04-13 10:58:56 +03:00
14bd5bdc77 Merge branch 'master' into verify-tab 2021-04-12 15:14:37 +09:00
4df7ff21c7 Fix editor arrow seek snapping not updating after control point changes
The editor clock, which is responsible for performing the seek, was not
aware of changes in control points due to reading from the wrong
beatmap. `loadableBeatmap` is not actually changed by any of the editor
components; `playableBeatmap` and `editorBeatmap` are.

For now this is changed to use `playableBeatmap`. A better follow-up
would be to use `editorBeatmap`, but it would probably be best to move
the beat snap bindable into `EditorBeatmap` first.
2021-04-03 14:02:46 +02:00
690debe507 Merge pull request #12030 from LeNitrous/editor-platform-clipboard-copy 2021-03-29 19:31:16 +09:00
d58ef5310b Add verify tab
Currently empty, but works.
2021-03-28 17:36:22 +02:00
c96321206a fix appveyor complaints 2021-03-26 16:17:24 +08:00
2bea69456e remove implementations 2021-03-26 15:24:33 +08:00
51e0304c54 properly format strings per ruleset 2021-03-17 18:31:09 +08:00
133ff085a5 refactor code 2021-03-17 18:06:40 +08:00
8046b5a818 set text to platform clipboard on copy 2021-03-17 17:35:49 +08:00
3b6a1180b6 Remove non-accessed field 2021-03-17 17:02:11 +09:00
c7740d1181 Fix opening the editor occasionally causing a hard crash due to incorrect threading logic
Setting one of the global screen `Bindable`s (in this case, `Beatmap`)
is not valid from anywhere but the update thread. This changes the order
in which things happen during the editor startup process to ensure
correctness.

Closes #11968.
2021-03-17 15:52:25 +09:00
c70dd2edfc Merge pull request #11569 from peppy/fix-editor-new-beatmap-crash
Fix a potential crash when exiting the editor before a new beatmap is added to the database
2021-02-01 21:01:51 +09:00
4ac362ee1a Move cloning local to editor 2021-01-25 18:29:00 +09:00
b44bd8c4ee Remove unused using statement 2021-01-22 18:03:33 +09:00
a9c8f9bd4a Fix a potential crash when exiting the editor before a new beatmap is added to the database 2021-01-22 17:47:38 +09:00
2cfd1e8b47 Merge branch 'master' into fix-control-point-pollution 2021-01-08 00:02:45 +09:00
b3f08b29ca Ensure that all changes to screen backgrounds are on the correct thread 2021-01-05 15:22:50 +09:00
b4a779108e Ensure working beatmap is reloaded on exiting the editor 2021-01-04 16:37:49 +09:00
83f1350d7d Fix editor background not being correctly cleaned up on forced exit
Closes #11214. Should be pretty obvious why.
2020-12-21 17:49:11 +09:00
e84dab8589 Move new beatmap construction above beat divisor binding 2020-12-02 14:36:52 +09:00
2b268ee012 Fix editor beat snapping not working correctly when starting with a new beatmap 2020-12-01 16:16:26 +09:00
d4c6d6275e Fix volume not being adjustable in the editor using alt-scroll
We do this in other places so I think it's fine to handle like this for
now (until we come up with a better global solution).

Closes #10958.
2020-11-25 16:46:22 +09:00
e078b78dcc Ensure callbacks don't fire when restoring default beatmap 2020-11-07 20:59:57 +01:00
7e4314684b Add editor waveform opacity selection to menu 2020-11-03 16:01:14 +09:00
351acce698 Merge branch 'master' into fix-editor-bindable-crash 2020-10-28 13:34:54 +09:00
01b576c861 Fix editor crash on exit when forcing exit twice in a row 2020-10-28 13:32:39 +09:00
e0ad005cc1 Move editor sample disabling logic to editor class (and support screen switching) 2020-10-27 14:33:44 +09:00
aea31d1582 Fix editor not seeking by full beat when track is playing
This is expected behaviour as my osu-stable, and I still stand behind
the reasoning behind it.

Closes #10519.
2020-10-16 13:07:00 +09:00
ecfb7e94c5 Merge branch 'master' into fix-editor-batch-handling 2020-10-09 20:06:06 +09:00
68039cff40 Set beatmap to sane default on exiting editor 2020-10-09 13:12:48 +09:00
38babf3de5 Update usages of ChangeHandler to EditorBeatmap where relevant 2020-10-08 18:04:07 +09:00
09f5e9c9eb Use batch change application in many places that can benefit from it 2020-10-06 22:10:07 +09:00
3ce234d552 Seek at 4x normal speed when holding shift
This matches osu-stable 1:1. Not sure if it feels better or not but
let's stick with what people are used to for the time being.
2020-10-06 17:47:25 +09:00
9ca0e48acc Change exit logic to be more test-friendly 2020-10-04 23:57:28 +09:00
02e4f3ddaf Fix the editor saving new beatmaps even when the user chooses not to 2020-10-04 23:47:16 +09:00
d6f3beffb6 Use existing bindable flow instead 2020-09-29 12:50:17 +09:00
4f0c0ea5f9 Fix hit samples playing while paused / seeking in the editor 2020-09-28 18:17:47 +09:00
e828cf1607 Merge branch 'master' into editor-load-audio 2020-09-25 14:49:54 +09:00
44a6637c36 Use SingleOrDefault 2020-09-25 12:20:37 +09:00
978f6edf38 Add basic track reloading support while inside the editor 2020-09-24 20:56:35 +09:00
158d307126 Avoid destroying editor screens when changing between modes 2020-09-24 17:03:54 +09:00
3062fe4411 Add editor key bindings to switch between screens 2020-09-22 15:55:25 +09:00
692f2c8489 Simplify debounced update pathway 2020-09-14 14:58:00 +09:00
320e314356 Use minimum start time to handle SelectedHitObjects not being sorted 2020-09-13 22:53:30 +09:00