ec040ff3fc
Fix leak due to not properly unbinding SourceChanged event on disposal
2021-06-22 05:05:41 +03:00
caa90bccc6
Fix default skin potentially added twice in RulesetSkinProvidingContainer
2021-06-22 03:45:43 +03:00
627c857da8
Propagate SourceChanged events from SkinManager down in the ruleset skin container
2021-06-22 03:45:24 +03:00
9e5bb146d3
Add xmldoc to SkinManager
...
The `<summary>` part comes from `BeatmapManager`, which I believe works correctly here as well, as this does handle the "storage and retrieval" of skins.
2021-06-22 03:07:31 +03:00
97dbc7f20e
Add back SkinManager.DefaultSkin to the ruleset skin lookup sources
2021-06-22 02:54:34 +03:00
d53a43cf3c
Isolate RulesetSkinProvidingContainer from falling back to parent skin sources
...
For simplicity of lookup order, and which sources are used for the lookup.
2021-06-22 02:53:22 +03:00
ebe0d43790
Add ability to disallow falling back to parent skins
2021-06-22 02:51:17 +03:00
11b78ad849
Make TestPlayer skin assigning logic not flaky
2021-06-21 06:46:00 +03:00
5cfd0e3223
Remove implicit LegacySkin check and refactor anything using it
2021-06-21 04:16:58 +03:00
780388d174
Fix incorrect return value
2021-06-17 03:48:29 +03:00
74ad6f9117
Remove default skin from the ruleset skin sources
...
That one doesn't need any changes to it, can be fetched from the `SkinManager` instead.
2021-06-16 17:24:31 +03:00
52ddf08532
Consider not adding legacy skin transformers to non-legacy skins
2021-06-16 17:24:16 +03:00
5ebf570ec4
Revert GetRulesetTransformedSkin accessibility change
...
This reverts commit 521077b714
2021-06-16 16:49:38 +03:00
521077b714
Make getRulesetTransformedSkin private
2021-06-16 17:44:18 +09:00
4b45d8318e
Merge branch 'master' into transformers-per-skin
2021-06-16 16:37:28 +09:00
b24730efdb
Merge pull request #13512 from smoogipoo/add-localisation-example
...
Localise parts of the beatmap listing overlay
2021-06-16 16:03:40 +09:00
5be00ad0a9
Merge pull request #13502 from smoogipoo/gh-actions
...
Add GitHub actions workflow
2021-06-16 15:29:18 +09:00
cb80577922
Merge pull request #13509 from bdach/fix-seasonal-backgrounds
...
Fix seasonal backgrounds not cycling
2021-06-16 15:26:46 +09:00
68fa7d68cc
Merge pull request #13511 from smoogipoo/fix-possible-nullref-2
...
Fix possible nullref in difficulty recommender
2021-06-16 15:20:45 +09:00
f802679d38
Merge pull request #13497 from smoogipoo/fix-present-score
...
Make PresentScore() use replay hash as fallback
2021-06-16 15:18:01 +09:00
4c5268694e
Localise some of the BeatmapListingOverlay
2021-06-16 13:46:13 +09:00
fa00d07107
Upgrade osu-resources
2021-06-16 13:26:36 +09:00
451ce04d19
Make Resharper inspections fail CI job
...
As per https://github.com/ppy/osu-framework/pull/4514 .
2021-06-16 13:22:50 +09:00
a5261f0cb3
Add difficulty recommender instantly
2021-06-16 11:48:49 +09:00
6be41e497a
Fix possible nullref in difficulty recommender
2021-06-16 11:27:38 +09:00
022b1a28d5
Add missing equality implementation for seasonal backgrounds
...
The equality operator is used to determine whether the next background
in the cycle should be loaded, to avoid pointless loads of the same
background several times (see #13362 and #13393 ). Its omission in the
latter pull caused seasonal backgrounds to no longer cycle.
Closes #13508 .
2021-06-15 23:21:48 +02:00
30703d518c
Add failing assert for seasonal background equality
2021-06-15 23:19:33 +02:00
81c43bcf19
Merge pull request #13503 from frenzibyte/legacy-spinner-background-colour
2021-06-15 20:18:20 +02:00
1fb343b432
Merge branch 'master' into legacy-spinner-background-colour
2021-06-15 19:40:44 +02:00
3ef3e33876
Merge branch 'master' into gh-actions
2021-06-15 18:37:39 +02:00
819e3afbfb
Merge pull request #13504 from smoogipoo/fix-malformed-database-test
...
Fix malformed database test failing in single-threaded mode
2021-06-16 01:34:45 +09:00
7fdf456178
Merge pull request #13500 from smoogipoo/remove-cake
...
Remove cake
2021-06-16 01:25:16 +09:00
e79e1bbcc0
Fix malformed database test failing in single-threaded mode
2021-06-15 22:53:43 +09:00
a4c4867d6a
Add scripts for running inspections locally
2021-06-15 22:40:31 +09:00
52145c9237
Assign skinnable colour to spinner-background with correct default
2021-06-15 16:17:05 +03:00
a85a592f70
Add lookup for spinner background colour
2021-06-15 16:16:25 +03:00
5283948a6d
Fix incorrect directory
2021-06-15 22:05:13 +09:00
04e8703eee
Add github actions workflows
2021-06-15 21:59:18 +09:00
9fcf105364
Remove cake
2021-06-15 21:46:23 +09:00
e29e2328f8
Inline inspection actions into appveyor.yml
2021-06-15 21:45:02 +09:00
f39dbb8b6e
Upgrade cfs
2021-06-15 21:42:09 +09:00
b871ee4e71
Merge pull request #13463 from Pasi4K5/enhance-mod-settings-text-box-visibility
...
Enhance text box visibility in mod settings
2021-06-15 17:01:39 +09:00
e9d4ee3c87
Merge branch 'master' into enhance-mod-settings-text-box-visibility
2021-06-15 16:09:55 +09:00
579a4aa9c8
Remove comment
2021-06-15 14:10:09 +09:00
eb4c093371
Use hash as fallback
2021-06-15 14:06:17 +09:00
1ddcb352c5
Merge pull request #13449 from ekrctb/refactor-scrolling-hoc-1
...
Refactor `ScrollingHitObjectContainer` and expose more useful methods
2021-06-15 11:21:26 +09:00
f6c6eea6dc
Make PresentScore() only consider replay hash
2021-06-15 11:16:35 +09:00
62959c4b21
Merge branch 'master' into refactor-scrolling-hoc-1
2021-06-15 10:46:07 +09:00
f3ca134e1e
Merge pull request #13496 from bdach/disable-dotnet-format
...
Temporarily disable `dotnet format` to unblock CI
2021-06-15 08:26:22 +09:00
9d9c5902bb
Temporarily disable dotnet format to unblock CI
2021-06-14 22:54:16 +02:00
