ec61a94dc9
Merge branch 'master' into no-gameplay-clock-gameplay-offset
2022-08-23 17:36:06 +09:00
51e607e834
Merge pull request #19911 from smoogipoo/multi-spectator-clock-cleanup
...
Invert creation of clocks in multi-spectator
2022-08-23 14:26:06 +09:00
553897f2f0
Remove AddClock method to CreateManagedClock
2022-08-23 13:52:43 +09:00
1191b6c080
Remove unused Source_Set implementation on ISpectatorPlayerClock
2022-08-23 13:44:41 +09:00
c59298f0ce
Enable NRT
2022-08-22 21:55:04 +09:00
489e172a76
Simplify track start/stop/paused tracking
2022-08-22 19:43:18 +09:00
5d3d8681d4
Invert creation of clocks in multi spectator
2022-08-22 19:14:06 +09:00
3fb3a18e68
Merge pull request #19906 from peppy/fix-editor-crash-mobile
...
Fix editor crashing on mobile releases
2022-08-22 16:31:19 +09:00
058d67f8e8
Merge pull request #19695 from naoei/ruleset-localization
...
Change most ruleset-accessible string types to Localisable strings
2022-08-22 16:13:23 +09:00
19bba143ee
Fix editor crashing on mobile releases
2022-08-22 15:57:24 +09:00
0815b01b75
Merge pull request #19783 from bdach/mod-select/presets-dont-open-customisation
...
Fix selecting preset containing Difficulty Adjust automatically opening customisation panel
2022-08-22 15:44:00 +09:00
2bc0a68911
Merge pull request #19830 from peppy/test-ruleset-compatibility
...
Test ruleset compatibility during initial startup to avoid runtime errors
2022-08-22 15:24:46 +09:00
d199b3b100
Update GetVariantName to also support localisation
2022-08-22 14:51:00 +09:00
9d31f61ca9
Don't throw when a ruleset type is completely missing
2022-08-22 14:35:44 +09:00
594353fca1
Merge pull request #19905 from smoogipoo/fix-text-boldening
...
Fix language change removing mod column bold text
2022-08-22 14:15:22 +09:00
e6b669db8e
Elaborate with example of GameplayClockContainer managing its own Stop state
2022-08-22 14:14:44 +09:00
af2e82d7d5
Move operation of setting GameplayClockContainer.StartTime to Reset call
2022-08-22 14:11:06 +09:00
17a1df281c
Fix incorrect implicit null specification for user audio offset bindable
2022-08-22 14:03:51 +09:00
ba23ce75c2
Make FramedBeatmapClock.Track non-null
2022-08-22 14:02:41 +09:00
85d0b7fc57
Reword class xmldoc to better explain that offset application is optional
2022-08-22 14:02:20 +09:00
b81c7ffc60
Merge pull request #19868 from peppy/fix-test-deadlocks
...
Add safeties to avoid deadlock in `SubmittingPlayer`
2022-08-22 13:17:41 +09:00
e1fa959f0b
Fix language change removing mod column bold text
2022-08-22 13:00:47 +09:00
3ef6c60d1f
Merge pull request #19898 from bdach/mod-select/fix-difficulty-multiplier-rounding
...
Adjust rounding in mod select difficulty multiplier to match song select footer
2022-08-22 11:18:34 +09:00
aa15e84bea
Adjust rounding in mod select difficulty multiplier to match song select footer
...
The 0.01 `Precision` spec on `DifficultyMultiplierDisplay.Current` would
cause the difficulty multiplier to use a different midpoint rounding
strategy than `double.ToString()`, which is the one that the song select
footer relies on. For example, a value of 0.015 would be rounded down
to 0.01 by `double.ToString()`, but rounded up to 0.02
by `BindableDouble`.
Fix the discrepancy by just deleting the `Precision` spec. Since the
value of the bindable would go through `ToLocalisableString(@"N2")`
anyway, it was redundant as is.
Fixes #19889 .
2022-08-21 23:15:49 +02:00
29ef1c8db8
Check if StatisticItem.Name is null or empty
2022-08-20 21:48:53 -04:00
9386d352b8
Make StatisticItem.Name not nullable
2022-08-20 21:48:35 -04:00
189a407cb1
Merge branch 'master' into ruleset-localization
2022-08-20 21:39:10 -04:00
513ba69f6f
Merge pull request #19865 from OliBomby/fix-slider-flip
...
Fix flipping a slider sometimes changing the curve type from "Perfect" to "Bezier"
2022-08-21 00:04:35 +09:00
7732fb21d5
fix code quality
2022-08-20 16:09:02 +02:00
614ae815c0
Added tests for making sure flipping and rotating retains perfect control point type
2022-08-20 15:57:39 +02:00
8566e93c72
Guard against SubmittingPlayer potentially getting stuck waiting on request forever
2022-08-20 17:19:17 +09:00
a1e849c4db
Ensure that DummyAPIAccess runs all queued tasks on disposal
2022-08-20 16:22:35 +09:00
cbdd870ecf
Merge pull request #19693 from its5Q/editor-localisation
...
Add localisation support for beatmap editor setup
2022-08-20 11:51:57 +09:00
36e202c70e
Add inline comment explaining necessity to use AddRange for slider transform operations
2022-08-20 11:38:43 +09:00
65f7ecec83
moving all controlpoints at once for slider
2022-08-20 00:26:04 +02:00
339f0b0cd2
Merge branch 'master' into no-gameplay-clock-gameplay-offset
2022-08-19 23:01:09 +09:00
4ef8e00a78
Merge pull request #19851 from peppy/update-framework
...
Update framework and resources
2022-08-19 22:03:55 +09:00
7bf318541c
Reword comment to hopefully read better
2022-08-19 20:57:55 +09:00
c3c44c19cd
Use CompositeComponent in various locations
2022-08-19 20:43:15 +09:00
41321521e5
Update resources
2022-08-19 20:40:05 +09:00
426c4c9bf7
Update framework
2022-08-19 20:39:53 +09:00
3f0da14065
Delay start operation by one frame to allow children to see initial start time
2022-08-19 17:39:51 +09:00
4c24d8ed58
Improve string consistency
2022-08-19 03:17:05 +10:00
e7d4962128
Merge branch 'master' into no-gameplay-clock-gameplay-offset
2022-08-19 01:50:14 +09:00
3eb1cda6aa
Reorganise call order of Start / Reset to make more sense
2022-08-19 01:46:36 +09:00
15d49b0357
Update TestSceneSpectator to user new assert style
2022-08-19 01:46:19 +09:00
1d774f3f12
Remove redundant ProcessFrame calls
...
Of note, I'm not sure whether the `IsPaused` check was meaningful, but
it's not reimplemented in the new `FramedBeatmapClock`.
2022-08-19 01:39:02 +09:00
7bc96431a7
Remove unnecessary virtual spec from GameplayClockContainer.Seek
2022-08-19 01:39:01 +09:00
0e228791c0
Remove unnecessary Reset call in MultiSpectatorScreen
2022-08-19 01:39:01 +09:00
cc86909633
Increase lenience on TestSceneLeadIn tests
...
I've gone through these in detail and can't find an issue with the
actual flow of things. For whatever reason, the new structure has a
slightly higher delay, likely due to performing less `Seek` calls
(previously a `Seek` was called after the clock start which may have
been making this more accurate on the first `Player.Update`).
I don't think it really matters that this is slightly off, but we'll see
how this plays out.
2022-08-19 01:39:00 +09:00
