Commit Graph

41314 Commits

Author SHA1 Message Date
ece63b9ba1 Remove unused using directive 2021-06-22 12:03:55 +03:00
31cbb36a64 Implement FindProvider and AllSources properly on all test ISkinSources 2021-06-22 12:03:14 +03:00
c1284940e1 Fix potentially providing the same skin instance twice in AllSources 2021-06-22 10:49:37 +03:00
d0cdc07b11 Reuse AllSources when looking up on FindProvider 2021-06-22 10:49:21 +03:00
b12adc6073 Remove all test skinning changes in favour of the ISkinSource.AllSources path 2021-06-22 10:48:03 +03:00
14bdcef26b Add missing newline 2021-06-22 16:20:09 +09:00
0ad189e357 Expose skin sources via ISkinSource and revert to consuming based on hierarchy 2021-06-22 16:19:55 +09:00
1b0aadcc6f Merge branch 'master' into transformers-per-skin 2021-06-22 16:03:15 +09:00
ec040ff3fc Fix leak due to not properly unbinding SourceChanged event on disposal 2021-06-22 05:05:41 +03:00
caa90bccc6 Fix default skin potentially added twice in RulesetSkinProvidingContainer 2021-06-22 03:45:43 +03:00
627c857da8 Propagate SourceChanged events from SkinManager down in the ruleset skin container 2021-06-22 03:45:24 +03:00
9e5bb146d3 Add xmldoc to SkinManager
The `<summary>` part comes from `BeatmapManager`, which I believe works correctly here as well, as this does handle the "storage and retrieval" of skins.
2021-06-22 03:07:31 +03:00
97dbc7f20e Add back SkinManager.DefaultSkin to the ruleset skin lookup sources 2021-06-22 02:54:34 +03:00
d53a43cf3c Isolate RulesetSkinProvidingContainer from falling back to parent skin sources
For simplicity of lookup order, and which sources are used for the lookup.
2021-06-22 02:53:22 +03:00
ebe0d43790 Add ability to disallow falling back to parent skins 2021-06-22 02:51:17 +03:00
5b9bf54f1f Merge pull request #13545 from frenzibyte/legacy-spinner-approach-circle
Add support for legacy spinner approach circles
2021-06-21 18:52:06 +09:00
999bf27eae Remove unnecessary abstraction of ApproachCircle property 2021-06-21 12:07:00 +03:00
ba15f7c19b Move ApproachCircle out of the scale container and revert relevant changes 2021-06-21 10:47:38 +03:00
7d31943ff5 Merge pull request #13597 from Joehuu/fix-beatmap-discussion-links
Fix beatmap discussion links wrongly leading to beatmap page
2021-06-21 14:52:55 +09:00
036b745425 Remove no longer needed LegacySpinnerApproachCircle 2021-06-21 08:41:10 +03:00
42edbe4fb9 Move ApproachCircle implementation into per-style 2021-06-21 08:40:38 +03:00
6fda5e569a Fix beatmap discussion links wrongly leading to beatmap page 2021-06-20 21:37:00 -07:00
8b2110c048 Add failing discussion links test 2021-06-20 21:36:08 -07:00
68e28f4903 Implement IHasApproachCircle in DrawableHitCircle as well 2021-06-21 07:35:07 +03:00
11b78ad849 Make TestPlayer skin assigning logic not flaky 2021-06-21 06:46:00 +03:00
2d1794f7d8 Merge pull request #13596 from Joehuu/update-rulesets-link
Update custom rulesets directory link in readme
2021-06-21 12:09:34 +09:00
e4705abee2 Update custom rulesets directory link in readme 2021-06-20 20:07:46 -07:00
5cfd0e3223 Remove implicit LegacySkin check and refactor anything using it 2021-06-21 04:16:58 +03:00
01478d780d Generalize IHasSpinnerApproachCircle from being spinner-specifc 2021-06-21 03:43:11 +03:00
72155a7c52 Replace if pattern-matching check with switch cases instead 2021-06-21 03:37:50 +03:00
c624ec79b1 Merge pull request #13575 from bdach/realm-on-xamarin
Add direct references to Realm from Xamarin projects
2021-06-20 21:51:25 +09:00
70d3a882f8 Merge pull request #13591 from smoogipoo/revert-gc-change
Remove high performance GC setting
2021-06-20 21:11:11 +09:00
32bd3107e1 Remove high performance GC setting 2021-06-20 17:07:41 +09:00
1f383532f2 Move FodyWeavers configuration to solution root 2021-06-20 10:05:49 +02:00
46b9fd9ac8 Remove and ignore FodyWeavers schema files 2021-06-20 10:05:42 +02:00
c3217fd8b1 Remove leftover approach circle skin component 2021-06-19 20:10:32 +03:00
c04b09520d Replace spinner approach circle proxying logic with hooking up to OnSkinChange in mod 2021-06-19 20:06:28 +03:00
fa87aa6be5 Add autogenerated FodyWeavers files to Xamarin projects 2021-06-19 11:11:30 +02:00
805e6cca75 Add direct references to Realm from Xamarin projects
Fixes crashes on launch due to missing `realm-wrapper` transitive
dependency.
2021-06-19 11:07:13 +02:00
b6e07ff59c Merge pull request #13572 from bdach/fix-unsupported-locales
Fix game crashes due to attempting localisation load for unsupported locales
2021-06-19 17:09:39 +09:00
afcc3e14f4 m 2021-06-19 16:16:29 +09:00
b47774b55a Remove Tagalog language for now
Rationale given in inline comment.
2021-06-19 08:07:37 +02:00
76db87f9cb Try-catch around localisation store registration
Some platforms (android, older windows versions) will throw exceptions
at runtime when an unsupported `CultureInfo` is attempted to be
instantiated, leading to nasty crashes. Add a preventative try-catch
registration to prevent the crash, and log the errors for visibility.
2021-06-19 08:02:30 +02:00
3f336d88ec Merge pull request #11461 from peppy/realm-key-binding-store
Add initial realm database implementation with KeyBindingStore migration
2021-06-19 02:49:41 +09:00
d6b9436151 Proxy spinner approach circle before the spinner overlay components 2021-06-18 20:34:25 +03:00
843c8bd7a4 Move spinner approach circle to its own SkinnableDrawable 2021-06-18 20:33:50 +03:00
f7b5341663 Merge branch 'master' into legacy-spinner-approach-circle 2021-06-18 19:50:52 +03:00
89c27dcb10 Merge pull request #13517 from ekrctb/initial-entry
Allow setting `Entry` of `PoolableDrawableWithLifetime` (including `DrawableHitObject`)
2021-06-19 00:03:41 +09:00
65014aeb7a Merge pull request #13556 from bdach/editor-hit-circle-animation-regression
Fix editor hit circle animation toggle not working
2021-06-19 00:03:06 +09:00
fa838ba253 Merge pull request #13528 from gagahpangeran/last-lang
Add remaining non-rtl language
2021-06-19 00:00:33 +09:00