Commit Graph

26233 Commits

Author SHA1 Message Date
f777741ca7 Simplify instantiation 2021-06-28 14:51:27 +09:00
e8e9fdd533 Dispose ResourcesSkin before clearing skin sources 2021-06-26 12:34:30 +03:00
e5eea503db Remove finalizer logic from ResourcesSkin 2021-06-26 12:21:49 +03:00
a98b5618b8 Convert RulesetResourcesSkin to plain ResourcesSkin and pass non-null resources 2021-06-24 10:07:38 +03:00
d484469906 Handle case where SkinManager sources aren't part of AllSources
In tests.
2021-06-23 10:44:23 +03:00
53fa229880 Add ruleset resources skin before SkinManager.DefaultSkin 2021-06-23 10:09:25 +03:00
2e6800f586 Enable NRT in RulesetResourcesSkin 2021-06-23 09:52:00 +03:00
0db06c727b Dispose resource stores on finalizer 2021-06-23 09:41:45 +03:00
ee84364d7c Resolve conflict issues 2021-06-22 20:38:24 +03:00
896c1dc202 Merge branch 'master' into ruleset-resources-skin 2021-06-22 20:36:49 +03:00
bdc440f11c Merge pull request #13605 from aitani9/overlay-item-sound-edge
Empty the space between `OverlayStreamItem`s
2021-06-22 22:13:39 +09:00
4cb9c6a842 Merge pull request #13423 from frenzibyte/transformers-per-skin
Refactor ruleset skin transforming logic to be per-`ISkin` rather than one `ISkinSource`
2021-06-22 21:24:56 +09:00
e39ce6cc67 Merge pull request #13610 from gagahpangeran/markdown-heading-font-size
Change osu markdown heading to use actual font size
2021-06-22 20:58:48 +09:00
c436f9f0fa Merge pull request #13615 from peppy/mod-utils-check-duplicate-mods
Ensure duplicate mods cannot be defined
2021-06-22 20:28:40 +09:00
883b3e56f4 Merge branch 'master' into markdown-heading-font-size 2021-06-22 20:21:25 +09:00
71e2815e7e Update and improve code documentation
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-06-22 12:05:17 +03:00
31cbb36a64 Implement FindProvider and AllSources properly on all test ISkinSources 2021-06-22 12:03:14 +03:00
b8126e3ca8 Update framework 2021-06-22 17:59:24 +09:00
c4fde635c6 Ensure duplicate mods cannot be defined 2021-06-22 17:41:20 +09:00
c1284940e1 Fix potentially providing the same skin instance twice in AllSources 2021-06-22 10:49:37 +03:00
d0cdc07b11 Reuse AllSources when looking up on FindProvider 2021-06-22 10:49:21 +03:00
b12adc6073 Remove all test skinning changes in favour of the ISkinSource.AllSources path 2021-06-22 10:48:03 +03:00
1fff9a93b9 Merge branch 'master' into skin-editor-closest-anchor 2021-06-22 16:41:51 +09:00
4b3165084d Move scoped functionality into local function 2021-06-22 16:40:56 +09:00
ffac32a848 Reword xmldoc 2021-06-22 16:40:48 +09:00
14bdcef26b Add missing newline 2021-06-22 16:20:09 +09:00
0ad189e357 Expose skin sources via ISkinSource and revert to consuming based on hierarchy 2021-06-22 16:19:55 +09:00
1b0aadcc6f Merge branch 'master' into transformers-per-skin 2021-06-22 16:03:15 +09:00
5c3129f1a2 add font size in HeadingTextFlowContainer 2021-06-22 12:24:56 +07:00
f89c154e18 change GetFontSizeByLevel to return actual font size 2021-06-22 12:24:25 +07:00
ec040ff3fc Fix leak due to not properly unbinding SourceChanged event on disposal 2021-06-22 05:05:41 +03:00
caa90bccc6 Fix default skin potentially added twice in RulesetSkinProvidingContainer 2021-06-22 03:45:43 +03:00
627c857da8 Propagate SourceChanged events from SkinManager down in the ruleset skin container 2021-06-22 03:45:24 +03:00
9e5bb146d3 Add xmldoc to SkinManager
The `<summary>` part comes from `BeatmapManager`, which I believe works correctly here as well, as this does handle the "storage and retrieval" of skins.
2021-06-22 03:07:31 +03:00
97dbc7f20e Add back SkinManager.DefaultSkin to the ruleset skin lookup sources 2021-06-22 02:54:34 +03:00
d53a43cf3c Isolate RulesetSkinProvidingContainer from falling back to parent skin sources
For simplicity of lookup order, and which sources are used for the lookup.
2021-06-22 02:53:22 +03:00
ebe0d43790 Add ability to disallow falling back to parent skins 2021-06-22 02:51:17 +03:00
36e459e97e Use margin instead of padding 2021-06-21 13:42:15 -07:00
6fda5e569a Fix beatmap discussion links wrongly leading to beatmap page 2021-06-20 21:37:00 -07:00
11b78ad849 Make TestPlayer skin assigning logic not flaky 2021-06-21 06:46:00 +03:00
5cfd0e3223 Remove implicit LegacySkin check and refactor anything using it 2021-06-21 04:16:58 +03:00
c624ec79b1 Merge pull request #13575 from bdach/realm-on-xamarin
Add direct references to Realm from Xamarin projects
2021-06-20 21:51:25 +09:00
32bd3107e1 Remove high performance GC setting 2021-06-20 17:07:41 +09:00
1f383532f2 Move FodyWeavers configuration to solution root 2021-06-20 10:05:49 +02:00
46b9fd9ac8 Remove and ignore FodyWeavers schema files 2021-06-20 10:05:42 +02:00
b6e07ff59c Merge pull request #13572 from bdach/fix-unsupported-locales
Fix game crashes due to attempting localisation load for unsupported locales
2021-06-19 17:09:39 +09:00
afcc3e14f4 m 2021-06-19 16:16:29 +09:00
b47774b55a Remove Tagalog language for now
Rationale given in inline comment.
2021-06-19 08:07:37 +02:00
76db87f9cb Try-catch around localisation store registration
Some platforms (android, older windows versions) will throw exceptions
at runtime when an unsupported `CultureInfo` is attempted to be
instantiated, leading to nasty crashes. Add a preventative try-catch
registration to prevent the crash, and log the errors for visibility.
2021-06-19 08:02:30 +02:00
3f336d88ec Merge pull request #11461 from peppy/realm-key-binding-store
Add initial realm database implementation with KeyBindingStore migration
2021-06-19 02:49:41 +09:00