Commit Graph

59704 Commits

Author SHA1 Message Date
fbb15fff26 Update framework 2023-04-17 23:03:16 +09:00
7aeab174eb Merge pull request #23185 from bdach/nested-result-revert
Invoke `RevertResult` on parent DHO when nested DHO is reverted
2023-04-12 23:08:10 +09:00
c326a98af5 Merge pull request #23189 from bdach/do-not-lookup-local-beatmaps
Do not look up metadata from online sources for locally-modified beatmaps on save
2023-04-12 21:55:10 +09:00
e72f103c17 Do not look up metadata for locally-modified beatmaps on save 2023-04-11 23:14:35 +02:00
db86ced4b4 Invoke RevertResult on parent DHO when nested DHO is reverted
The behaviour described above was removed in
812a4b412a, thus henceforth
contradicting `RevertResult`'s xmldoc. As it is relied on by some
external rulesets, bring it back to unbreak them.
2023-04-11 18:29:08 +02:00
0cc92ce5f9 Add failing test case
Covering nested object reverts not firing the parent's `RevertResult`
event in accordance with what the xmldoc of the event states.
2023-04-11 18:24:34 +02:00
e58e1151f3 Merge pull request #23178 from Joehuu/fix-count-not-updating-when-deleting
Fix song select beatmap difficulty count not updating when deleting
2023-04-11 09:46:41 +09:00
52bb7891f7 Merge branch 'master' into fix-count-not-updating-when-deleting 2023-04-11 09:04:02 +09:00
f80de08f24 Adjust BeatmapSetsChanged xmldoc
Co-Authored-By: Dean Herbert <pe@ppy.sh>
2023-04-10 11:28:23 -07:00
c7dea71793 Use existing BeatmapSetsChanged action 2023-04-10 11:26:18 -07:00
8757276c37 Merge pull request #23156 from Micha-ohne-el/editor-selection-rotation-snapping
Add rotation snapping to editor selection
2023-04-11 00:45:44 +09:00
52c4703261 Merge pull request #23103 from Joehuu/normalise-overlay-padding
Normalise horizontal padding on overlays
2023-04-10 23:48:59 +09:00
184f6d2dd4 Merge pull request #23087 from cdwcgt/gd-onlinesetoverlay
Show guest difficulty author in beatmap overlay
2023-04-10 16:30:10 +02:00
1f2c96c8e8 Merge branch 'master' into gd-onlinesetoverlay 2023-04-10 15:35:03 +02:00
6e08105e2c Remove usage of "diff" vernacular 2023-04-10 15:27:10 +02:00
11fd93a2ba Inline disturbing getGuestMapper() method
Disturbing because name suggests pure method, but it is in fact `void`
and also performs side effects by about the most confusing means
possible.
2023-04-10 15:20:43 +02:00
1255d489fc Merge pull request #23133 from peppy/editor-inspector
Add hit object inspector to editor
2023-04-10 15:13:33 +02:00
73bd0feef5 Fix incorrectly implemented localisation 2023-04-10 15:03:33 +02:00
6fec476147 Simplify snap implementation 2023-04-10 14:55:30 +02:00
ead5e9f027 Merge branch 'master' into editor-inspector 2023-04-10 14:29:05 +02:00
0d696f8938 Merge pull request #23177 from smoogipoo/progressive-dt-multiplier
Add progressive DT/HT mod multipliers
2023-04-10 21:27:48 +09:00
60358c7203 Perform first inspector text update immediately
Provides better and more consistent initial state for the inspector.
2023-04-10 14:13:53 +02:00
641415ca32 Unify displayed duration format for single/multiple selection 2023-04-10 14:05:32 +02:00
ad51f880e0 Remove overrides on DC/NC mods 2023-04-10 17:49:29 +09:00
7f5b99c91b Fix song select beatmap difficulty count not updating when deleting 2023-04-09 22:12:51 -07:00
bfb7ead689 Add failing text box beatmap difficulty count test 2023-04-09 22:12:50 -07:00
15f6bc155e Add progressive score multiplier for HT 2023-04-10 13:35:48 +09:00
c923482976 Add progressive score multiplier for DT 2023-04-10 13:31:48 +09:00
8d2e852ffd Fix overbearing key down handling 2023-04-08 22:30:36 +09:00
a1fc4def1d Remove redundant method override 2023-04-08 22:18:07 +09:00
3c4a25e53f Fix tooltip text not resetting when ending an editor rotation 2023-04-08 14:28:52 +02:00
580d5745c0 Add "(snapped)" to the tooltip when snap-rotating in the editor 2023-04-08 14:15:49 +02:00
a86a968fac Use public BeatmapSet to match other usages 2023-04-07 21:16:36 -07:00
ed208ef127 Fix more typos and adjust font size to match web 2023-04-07 21:10:37 -07:00
f72dd86b42 Fix code quality issues and avoid updating bindable twice per operation 2023-04-08 10:40:36 +09:00
c827c2810b Improve editor selection rotation value wrapping
This fixes two issues the previous algorithm had:
1.  A half-turn rotation used to show up as -180°.
2.  Rotating more than 180° in one drag event would overwhelm it
    and cause the value to go outside its range.

This comes at the cost of a negligible performance hit,
since a division (modulo) is performed instead of just addition/subtraction.
2023-04-08 01:30:29 +02:00
f1de560d57 Snap editor selection rotation when holding shift 2023-04-08 01:30:29 +02:00
ad717d2368 Fix scheduled calls piling up during transactions 2023-04-06 23:39:36 +09:00
628c23afae Merge pull request #23146 from EVAST9919/ruleset-samples-dispose
Fix `SampleStore` in `DrawableRulesetDependencies` isn't being disposed
2023-04-06 21:02:39 +09:00
ed565b1e59 Fix SampleStore isn't being disposed 2023-04-06 11:40:04 +03:00
e6872629f3 Merge pull request #22868 from peppy/no-epilepsy-warning-storyboard-disable
Don't show epilepsy warning when storyboards are disabled
2023-04-06 12:32:38 +09:00
92b8a0eaf4 Merge pull request #22872 from Terochi/update-skinnable-sound-before-playing
Fix pause and fail screen samples not updating when skin is changed during gameplay
2023-04-05 23:39:10 +02:00
ba753a8aac Merge branch 'master' into update-skinnable-sound-before-playing 2023-04-05 22:56:25 +02:00
8a52658c1f Merge pull request #22858 from peppy/fix-old-beatmap-crash-on-load
Fix crash on attempting to load some old beatmaps which specify background images incorrectly
2023-04-05 22:28:05 +02:00
27055919a3 Merge branch 'master' into fix-old-beatmap-crash-on-load 2023-04-05 21:39:42 +02:00
a4e68e1845 Merge pull request #22654 from ItsShamed/gameplay/key-counter-abstraction
Introduce common structure for key counters
2023-04-05 21:07:30 +02:00
6df7614b9d Add tests for suppressing epilepsy warning when storyboard disabled 2023-04-05 20:56:50 +02:00
02c6126be7 Ensure storyboards are enabled in existing epilepsy warning tests 2023-04-05 20:53:54 +02:00
e5d57a65c9 Fix incorrect indent 2023-04-05 19:47:25 +02:00
432f698697 Merge branch 'master' into gameplay/key-counter-abstraction 2023-04-05 19:45:14 +02:00