b5f145cfa9
Use null propagation for animation lookups
2021-06-06 23:01:37 +09:00
39f99bf785
Move FindProvider
to ISkinSource
2021-06-06 12:17:32 +09:00
c065f761c7
Merge branch 'master' into legacy-skin-default-fallback
2021-06-02 19:08:52 +09:00
2e2281c7d2
Revert disabling taiko sample tests and fix logic
2021-06-01 18:57:19 +09:00
3a6d081d82
Remove duplicated taiko fallback
2021-06-01 18:04:49 +09:00
ea4644be90
Revert "Fix weird taiko logic failing for weird reasons that probably should not have been a thing"
...
This reverts commit 69c4ccad05
.
2021-06-01 18:04:49 +09:00
69c4ccad05
Fix weird taiko logic failing for weird reasons that probably should not have been a thing
2021-05-31 21:29:47 +09:00
282c5a9177
Fix potential nullref in SkinProvidingContainer
2021-05-31 21:29:47 +09:00
3ff9f9c89d
Make FindProvider
non-default
2021-05-31 21:29:47 +09:00
8e489754cc
Add ability for LegacySkin
s to customise the fallback provider
2021-05-31 21:29:47 +09:00
88ed95e012
Add FindProvider
lookup function
2021-05-31 21:29:47 +09:00
1d30791ab0
Add potential pathway for legacy lookups
2021-05-31 21:29:47 +09:00
4b27d43e26
Add new parameter for default fallback logic in LegacySkin
2021-05-31 21:29:47 +09:00
02d18c7a49
Merge branch 'master' into remove-hud-component-lookup
2021-05-31 09:23:04 +03:00
fb81e5133f
Merge branch 'master' into catch-hide-combo-workaround
2021-05-30 14:16:46 +03:00
caa2c5638e
Fix legacy combo counter not accounting for song progress bar
2021-05-23 16:46:57 +09:00
43094425e2
Merge branch 'legacy-beatmap-skin-hud-fallback' into catch-hide-combo-workaround
2021-05-19 23:18:27 +03:00
c98d036b48
Merge branch 'master' into catch-hide-combo-workaround
2021-05-18 17:47:20 +03:00
08ee1e4853
Remove HUD skin component lookup in favour of MainHUDComponents
target system
2021-05-18 12:37:23 +03:00
10c730b37d
Add new default locations for hit bar error displays
2021-05-18 15:50:50 +09:00
f667ea3fd0
Replace AllowDefaultHUDComponentsFallback
with a temporary override at LegacyBeatmapSkin
2021-05-17 21:34:53 +03:00
da0913ca2d
Make SongProgress
a skinnable component
2021-05-17 18:52:56 +09:00
4c25fe750f
Disallow beatmap skin to fall back to default HUD components
...
This should become a more generalized `AllowDefaultSkinFallback` when default legacy skin fallback is supported.
2021-05-15 14:32:16 +03:00
2f025f1967
SkinnableTargetWrapper -> SkinnableTargetComponentsContainer
2021-05-13 18:54:30 +09:00
8b9ac86d4b
Merge branch 'master' into skin-serialisation
2021-05-13 12:35:06 +09:00
4464204e33
Mark all skin ctors used via reflection in SkinInfo.CreateInstance()
2021-05-12 23:23:42 +02:00
117d6d731d
Move cross-component layout dependencies for legacy skin to LegacySkin
2021-05-11 18:39:14 +09:00
4769a95b49
Fix encapsulation and remove target lookup overhead
2021-05-11 18:39:14 +09:00
b248b2e5e3
Hook up full save/load flow
2021-05-11 18:39:14 +09:00
004798d61d
Update Legacy components to not require skin in ctor
2021-05-11 18:39:14 +09:00
9be8d3f0d2
Add overridable combo colour retrieval method and handle in legacy skin
2021-05-05 07:15:07 +03:00
6aa0c9d8fd
Merge branch 'master' into legacy-sprite-text-fonts
2021-03-25 14:52:01 +03:00
073dba5330
Remove local workarounds to attempt to avoid crashes on skin change
2021-03-22 14:05:37 +09:00
68aaf90702
Fix disposal rather than performing some weird hack
2021-03-19 20:30:52 +09:00
b419d2c2e2
Fix invalid xmldoc indent
2021-03-18 19:52:38 +01:00
64d1cb5193
Remove text skin components in favour of plain LegacySpriteText
s
2021-03-13 06:05:36 +03:00
f48e017ac9
Move nested class to bottom of file
2021-02-22 18:34:05 +09:00
0bda9e4b79
Implement some new methods
2021-02-22 18:31:33 +09:00
487a39eea9
Update interface implementations with framework changes
2021-02-18 18:52:34 +09:00
880fe82073
Add sample wrapper in LegacySkin to keep a reference and avoid GC death
2021-02-18 18:32:51 +09:00
4aff54412a
Move dispose method to end of file
2021-02-18 18:32:39 +09:00
00574a5288
Use ISample everywhere in Skin GetSample lookup path
2021-02-18 18:32:28 +09:00
de9d075f94
Initial sample + samplechannel rework
2021-01-19 17:11:40 +09:00
3c1a86d11d
Trim braces for consistency
2021-01-15 22:04:45 +01:00
ebbc32adfa
Change conditional used to decide legacy judgement animation to match stable
...
In stable, the type of legacy judgement to show is based on the presence
of particle textures in the skin. We were using the skin version
instead, which turns out to be incorrect and not what some user skins
expect.
Closes #11078 .
2021-01-15 14:51:27 +09:00
13ef097a53
Annotate potentially null parameters in protected ctor of LegacySkin
2020-12-22 12:08:40 +09:00
a5bcf1dc20
Expose resources to skin via interface (and share common pieces with beatmap)
2020-12-21 15:18:52 +09:00
2108844319
apply ScorePosition to the judgement container
2020-12-13 22:01:08 +06:00
9d04ce75cc
Make particles additive and consume in judgement explosions
2020-11-19 15:47:02 +09:00
85c5c68dfa
Provide particle drawable as a function (for future use)
2020-11-19 13:20:21 +09:00