0eea026afb
Remove null checks on CreateInstance() calls
2021-11-24 12:23:09 +09:00
e8dea0138c
Fix one more issue
2021-09-16 18:34:13 +09:00
67a99c83a3
Tidy bindable changed code up
2021-05-14 16:24:52 +09:00
19800f5f7f
Move IBeatmap arg into context
2021-05-13 11:24:22 +02:00
b37cb3bdbe
Change interpreted difficulty from bindable to regular value
...
There's no reason for why checks would need this to be bindable. A 1-directional binding is more appropriate.
2021-05-13 09:00:30 +02:00
4eeeaf6a1a
Keep track of local bound copy
2021-05-13 07:57:32 +02:00
e7c7786db3
Merge branch 'master' into beatmap-verifier-context
2021-05-13 07:40:33 +02:00
b81f86bd4d
Move DI resolution to inside BDL parameters
2021-05-13 13:54:06 +09:00
c6648112e5
Simplify binding flow in InterpretationSection
2021-05-13 13:51:41 +09:00
cdcbaf4291
Tidy up specification of SettingsSection
2021-05-13 13:45:10 +09:00
47948d7b34
Set default for bindable in object initializer
...
Fixes the CI failure.
2021-05-13 06:08:48 +02:00
fb305130de
Also refresh when interpreted difficulty changes
2021-05-13 06:00:21 +02:00
ee0a6ba93e
Use local bound copy in InterpretationSection as well
...
Else we're relying on the `VerifyScreen`'s bindable instance, and by extension the `VerifyScreen` instance itself.
2021-05-13 05:59:49 +02:00
e80d8f6922
Keep track of local bound copy
2021-05-13 05:46:47 +02:00
04c1585eb2
Use more consistent lambda discards
2021-05-13 05:38:45 +02:00
e86834b740
Use local bound copy for HiddenIssueTypes
2021-05-13 05:25:20 +02:00
c8d21f2c3f
Isolate refreshing to IssueList
2021-05-13 05:25:02 +02:00
fbb76ba598
Split ShowIssueTypes dict into hidden and configurable lists
...
This way `VerifyScreen` is decoupled from which options `VisibilitySection` provides.
Bindings are a bit less neat, though.
2021-05-13 04:50:32 +02:00
dd8423c4c4
Set interpreted difficulty to correct default
2021-05-13 04:36:20 +02:00
6806e40ad9
Remove unnecessary local variable
...
This now exists in `VerifyScreen`, which we can access from here.
2021-05-13 04:30:40 +02:00
56bd897666
Move ShowIssueTypes to VerifyScreen
2021-05-13 04:29:27 +02:00
d2e0e8ad94
Reverse direction of binding to allow for better abstract class definitions
2021-05-12 16:53:58 +09:00
17e3764576
Rename Settings to have a more localised name
2021-05-12 16:38:04 +09:00
64d96b06a6
Add interpreted difficulty info to BeatmapVerifierContext
...
Enables checks to make use of the difficulty level as shown in the settings UI.
2021-05-12 02:30:21 +02:00
c13b93e6f1
Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks
...
This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.
See next commit for example.
2021-05-12 02:29:18 +02:00
4aeaec6ecc
Add InterpretationSection and its bindable in IssueList
...
We'll eventually connect that bindable so that checks can access it.
2021-05-12 01:32:18 +02:00
ad78aec1ef
Refresh IssueList on changes in VisibilitySection
2021-05-12 01:30:45 +02:00
1bb7d412da
Add IssueList filtering based on those bindables
2021-05-12 01:29:46 +02:00
2e4399f0c1
Add VisibilitySection and its bindables in IssueList
2021-05-12 01:27:21 +02:00
01b8794757
Add abstract Section class
...
Similar to `Section` in the timing screen, but does not make use of checkboxes, nor specific to control points.
So there's a lot of things that differ, hence new class instead of factoring that out.
2021-05-12 01:26:12 +02:00
1de35f880b
Separate IssueList into own class
2021-05-12 01:23:31 +02:00
d3c1ec55ee
Take IssueList in IssueSettings constructor
...
We'll be using this for bindables later.
2021-05-12 01:22:32 +02:00
97bd482d4d
Factor out load from settings into new Settings class
2021-05-12 01:21:38 +02:00
3e1b6b3b34
Simplify verifier run call args
...
Uses the resolved working beatmap instead of resolving it every time.
Also uses the EditorBeatmap itself as playable beatmap, as it is of type `IBeatmap` already, and `.PlayableBeatmap` forwards everything anyway.
2021-04-20 13:34:12 +02:00
496df411a7
Remove now unused import
2021-04-20 02:39:11 +02:00
0e6b66f457
Merge branch 'master' into bg-audio-quality-checks
2021-04-20 02:36:13 +02:00
8656176ab8
Add the playable beatmap as check argument
...
This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor.
So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`.
This should be preferred over `workingBeatmap.Beatmap`.
2021-04-20 01:31:51 +02:00
e143afb598
Split out rounded content screen from SetupScreen for use in other places
2021-04-19 14:28:32 +09:00
ef65c8910f
Fix resolved fields
2021-04-18 01:15:13 +02:00
448574e7e6
Use WorkingBeatmap instead of IBeatmap
...
This lets us access things like the background, track, etc. which are necessary for quality and filesize checks.
Also improves the structure of the `CheckBackgroundTest` class in the process.
2021-04-17 17:33:53 +02:00
21e8e5fbca
Move common table layout logic into EditorTable abstract class
2021-04-13 23:26:19 +09:00
0edc1a850d
Split out common EditorTable base class
2021-04-13 23:05:58 +09:00
464fc02875
Fix some styling issues with the verify screen layout
2021-04-13 19:55:17 +09:00
03ba04e8ce
Split out general checks into its own verifier class (and remove static usage)
2021-04-13 19:50:22 +09:00
60c2494b31
Make BeatmapVerifier an interface
2021-04-13 10:40:56 +02:00
008dbc7dd6
Reverse IssueType ordering
...
Reversed both in the enum and where it's displayed, so ends up the same in the end.
2021-04-12 15:49:13 +02:00
1c69829ad4
Fix Template.Origin -> Check
2021-04-12 15:47:58 +02:00
a2fc9c398f
Rename CreateChecker -> CreateBeatmapVerifier
2021-04-12 10:08:30 +02:00
65ebdd8f7a
Move check origin from IssueTemplate to Issue
...
As a result we can also make check an interface, and need to provide the check itself when constructing an issue.
2021-04-12 10:08:08 +02:00
8bf85d737c
Change Metadata into a get property
2021-04-12 15:52:29 +09:00
