0f09a7feb9
Avoid semaphore potentially getting held forever
2021-01-25 17:17:04 +09:00
994fb2667d
Call DisposeAsync instead of StopAsync
2021-01-25 17:11:04 +09:00
c05ae3497a
Make connect/disconnect private
2021-01-25 17:02:24 +09:00
13e0423ed8
Merge branch 'master' into fix-multiplayer-client-connection-reliability
2021-01-25 17:00:35 +09:00
dee0d3c33a
Merge branch 'master' into apply-sv-to-taiko-hr-ez
2021-01-25 14:28:06 +09:00
360f26c13d
Merge branch 'master' into scroll-to-20
2021-01-22 19:58:36 +01:00
f3192877fe
Update outdated comment
2021-01-22 19:48:33 +01:00
61fcb486a8
Trim unnecessary parentheses
2021-01-22 19:47:38 +01:00
26779a9403
Merge pull request #11567 from peppy/fix-chat-local-echo-effect
...
Fix local echo messages remaining permanently dimmed when chatting via multiplayer
2021-01-22 21:58:55 +09:00
a5f7ca485b
Fix unintended xmldoc tag edit
2021-01-22 16:53:31 +09:00
bfabb1fdea
Change offset value to 10%
2021-01-22 16:50:22 +09:00
fca6b15d2f
Fix local echo messages remaining permanently dimmed when chatting via multiplayer
2021-01-22 16:05:45 +09:00
65b7075984
Limit the effect of parallax when outside the bounds of the ParallaxContainer
...
This fixes the visual issues that still remain when mouse confining
fails. I think it also feels more correct in general.
2021-01-22 15:43:19 +09:00
d24d236468
Make OperationCanceledException throwing behaviour consistent
2021-01-22 14:34:58 +09:00
9f89b4e6d7
Rewrite connection logic to better handle failure cases
...
The main goal here is to ensure the connection is built each connection
attempt. Previously, the access token would never be updated, leading to
outdated tokens failing repeatedly (in the connection retry loop) and
never being able to establish a new connection as a result.
Due to threading considerations, this isn't as simple as I would hope it
to be. I'm open to proposals as to a better way of handling this.
Also, keep in mind that this logic will need to be abstracted and
(re)used in `SpectatorClient` as well. I've intentionally not done that
yet until we agree that this is a good direction forward.
2021-01-22 14:25:23 +09:00
2eba2a9abf
Rename FriendsButton to FollowersButton
2021-01-21 23:40:23 +03:00
c631354b57
Rename property
2021-01-21 23:39:19 +03:00
4555b9ff70
Make ProfileHeaderButton height defined
2021-01-21 22:56:12 +03:00
e87197c7fc
Adjust text size
2021-01-21 22:48:31 +03:00
343166f158
Make CreateIcon a property
2021-01-21 22:47:44 +03:00
a7c22ebe88
Implement MappingSubscribersButton component
2021-01-21 22:02:54 +03:00
966440f109
Add MappingFollowerCount field to User
2021-01-21 22:02:19 +03:00
2aa1df9ea4
Implement ProfileHeaderStatisticsButton component
2021-01-21 21:38:52 +03:00
05d3914fee
Rename friends tooltip to followers
2021-01-21 21:26:33 +03:00
0fa0e70bff
Merge branch 'master' into leave-channel-on-exiting-multiplayer
2021-01-21 19:04:33 +09:00
04095cd5b9
Merge branch 'master' into fix-editor-scroll-interruption
2021-01-21 17:46:18 +09:00
9eb74e86ed
Apply comment suggestion
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2021-01-21 17:40:15 +09:00
e6980688f6
Leave the multiplayer channel when leaving multiplayer
2021-01-21 15:42:23 +09:00
8853ac04d9
Rename some variable and add xmldoc for scroll centre position
2021-01-21 15:08:36 +09:00
c650cbd2a7
Rename variable to something slightly better
2021-01-21 15:01:23 +09:00
9daf29fedc
Extract out commonly used variables
2021-01-21 15:01:23 +09:00
a85f952a38
Inline single use function
2021-01-21 15:01:23 +09:00
e5eec27e95
Simplify selected section resolution
2021-01-21 15:01:23 +09:00
6d167b7865
Remove the need to store the smallest section
2021-01-21 14:40:55 +09:00
555abcdc36
Replace nan usage with nullable float
2021-01-21 14:31:31 +09:00
8f9089d1ae
Move constant to a better place
2021-01-21 14:30:22 +09:00
0fcf61d352
Replace null check with assert
2021-01-21 14:29:49 +09:00
a6516e3be5
Merge branch 'master' into scroll-to-20
2021-01-21 14:28:17 +09:00
7c4a072568
Merge branch 'master' into scroll-to-20
2021-01-21 13:48:26 +09:00
c3675293fa
Merge branch 'master' into beatmapset-refactor
2021-01-21 12:38:34 +09:00
1d9aaac2c2
Fix HOC not propagating DHO results applied on kill
...
`DrawableHitObject.OnKilled()` calls `UpdateResult()` to clean up a
hitobject's state definitively with regards to the judgement result
before returning the DHO back to the pool.
As it turns out, if a consumer was relying on this code path (as taiko
was in the case of nested strong hit objects), it would not work
properly with pooling, due to `HitObjectContainer` unsubscribing from
`On{New,Revert}Result` *before* calling the DHO's `OnKilled()`.
This in turn would lead to users potentially getting stuck in gameplay,
due to `ScoreProcessor` not receiving all results via that event path.
To resolve, change the call ordering to allow hit result changes applied
in `OnKilled()` to propagate normally.
2021-01-21 00:05:37 +01:00
7da7079ef2
Merge pull request #11537 from Mysfit/mp-initial-creation-screen-fix
...
Fix match/playlist room screen showing briefly behind initial room settings window on creation.
2021-01-20 22:05:14 +09:00
95f52ae054
Merge pull request #11536 from rednir/sort-skins-alphabetically
...
Sort SkinSection in alphabetical order
2021-01-20 21:49:31 +09:00
455383c3c0
Merge pull request #11528 from peppy/fix-autoplay-in-multiplayer
...
Fix multiplayer mod select showing autoplay as a choice
2021-01-20 21:49:16 +09:00
12f2067357
Merge branch 'master' into sort-skins-alphabetically
2021-01-20 21:15:16 +09:00
eb85efcea2
Add check to playlists too
2021-01-20 20:59:28 +09:00
250727cbd1
Merge branch 'master' into mp-initial-creation-screen-fix
2021-01-20 20:53:33 +09:00
2ca3ccad06
Move all the content to BeatmapSetHeaderContent drawable
2021-01-20 04:56:46 +03:00
94fee3800d
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmapset-refactor
2021-01-20 04:32:56 +03:00
2fabfe54a0
Merge pull request #11546 from bdach/mark-test-as-abstract
...
Mark legacy beatmap skin colour test as abstract
2021-01-20 10:03:40 +09:00