175d666906
Use getters of OriginalX and XOffset
2021-07-06 15:32:32 +09:00
ae1b1cbec9
Allow serialization of catch hit objects
2021-07-06 15:32:32 +09:00
d07c469a89
Merge pull request #13783 from smoogipoo/smooth-auto-gen
...
Make osu! auto generator interpolate during key-up frames
2021-07-06 15:04:40 +09:00
2cd1bde2bf
Merge pull request #13790 from PercyDan54/remove-redundant-arg
...
Remove redundant arguments
2021-07-06 14:00:59 +09:00
af02a1efcb
Bump redundant argument default value inspection severity to warning
2021-07-05 21:02:40 +02:00
686dd2b5ce
Remove unused constant
2021-07-05 20:35:14 +02:00
8e102280b7
Revert & disable case with two contradicting inspections
...
Leaving the `false` default value without the suppression triggers
`RedundantArgumentDefaultValue`, while removing it triggers
`BaseMethodCallWithDefaultParameter`.
Disable the former, because a single redundant parameter is less bad
than silent breakage if the default value of `propagateChildren` in the
base method ever changes.
2021-07-05 20:21:44 +02:00
e1c646b9b2
Remove redundant arguments
2021-07-05 23:52:39 +08:00
c7f03dd9f7
Merge pull request #13789 from PercyDan54/disable-inspections
...
Disable IDE0057 and IDE0042 inspection
2021-07-06 00:41:01 +09:00
a4545051f2
Suppress IDE0042
2021-07-05 23:36:15 +08:00
fdfdfeecab
Suppress IDE0057
2021-07-05 23:36:10 +08:00
01961fe4f9
Merge pull request #13747 from ekrctb/catcher-flip
...
Don't flip catcher plate contents when catcher changes direction
2021-07-06 00:02:23 +09:00
d247b8042e
Fix default skin catcher not flipping catcher plate
...
When legacy beatmap skin is present but catcher is not provided, it was using the legacy setting (always false).
2021-07-05 20:05:08 +09:00
991db4611e
Merge pull request #13784 from peppy/fix-incorrect-filename
...
Fix remaining incorrect filename
2021-07-05 20:02:56 +09:00
28faa8c330
Merge pull request #13780 from peppy/disable-foreign-keys
...
Disable foreign key enforcing at an sqlite level
2021-07-05 19:08:10 +09:00
2398859b66
Merge pull request #13781 from peppy/fix-multi-spec-test-failures
...
Fix master clock becoming incorrectly paused when all spectator players are too far ahead
2021-07-05 19:01:51 +09:00
cd2916f778
Fix remaining incorrect filename
2021-07-05 18:56:59 +09:00
bf4be2dfc7
Merge pull request #13782 from peppy/fix-incorrect-filename
...
Fix incorrect filename
2021-07-05 18:53:41 +09:00
8b7ccdc8b5
Adjust comment
2021-07-05 18:51:23 +09:00
7d6ab08bb3
Remove unnecessary conditional
2021-07-05 18:49:09 +09:00
695af31c58
Start alternating at 225BPM as previously
2021-07-05 18:43:27 +09:00
7645da7d37
Fix incorrect filename
2021-07-05 18:20:04 +09:00
2b8efe21ca
Don't ease with 0 time difference
2021-07-05 17:52:10 +09:00
229bba14e6
Fix master clock becoming incorrectly paused when all spectator players are too far ahead
2021-07-05 17:45:08 +09:00
12ca845e55
Use marker class (cleanup)
2021-07-05 17:24:23 +09:00
6a2c0f772e
Always apply easing, adjust heuristic a bit
2021-07-05 17:22:48 +09:00
96c0ab8ded
Adjust last frame position when not waiting
2021-07-05 17:11:59 +09:00
1e4beddd2d
Disable foreign key enforcing at an sqlite level
2021-07-05 15:41:48 +09:00
b7180f16c5
Merge pull request #13778 from Henry-YSLin/fix-unimplemented-mod-test
...
Use a mock ruleset and mod to test unimplemented mods in mod select overlay
2021-07-05 13:54:14 +09:00
8f82ceefe8
Merge pull request #13774 from LumpBloom7/fix-incorrect-first-window
...
Fix nested HitWindows not being considered if parent HitWindow is empty
2021-07-05 13:54:00 +09:00
6b76c54aee
Merge pull request #13756 from PercyDan54/playlist-empty-romanised
...
Fix playlist item displays empty string if no unicode title is present
2021-07-05 13:53:50 +09:00
b82afaddc1
Merge pull request #13767 from peppy/fix-realm-refresh-race
...
Fix thread safety of realm `Refresh` operation
2021-07-05 13:53:29 +09:00
3c37140426
Remove an unused local variable
2021-07-05 09:52:13 +08:00
bfb603cfeb
Change the test for unimplemented mod to use a mock ruleset and mod
2021-07-05 09:51:24 +08:00
f510ef9153
Move previousContext assign within lock to make things look safer
...
Not an actual requirement, but no harm.
2021-07-05 10:49:56 +09:00
b6542a835b
Merge pull request #13757 from peppy/fix-import-optimisation
...
Fix incorrect `base` call causing import optimisation to not work
2021-07-05 10:26:52 +09:00
5f10edee39
Merge branch 'master' into playlist-empty-romanised
2021-07-05 10:20:33 +09:00
cc877f88e2
Fix inspection (create a new ruleset every time)
2021-07-05 10:13:01 +09:00
216e52d6d0
Avoid using single letter variable names
2021-07-04 23:24:17 +02:00
1facdcf483
Apply changes to tests
2021-07-04 23:23:24 +02:00
6d2ffe3a94
Add basic tests
2021-07-04 22:51:35 +02:00
32b068fbdc
Fix typo causing nested windows to be ignored
2021-07-04 21:50:58 +02:00
0fb16cb55f
Merge pull request #13746 from ekrctb/move-caught-object-vertical-offset
...
Move caught object stack vertical offset logic
2021-07-04 18:10:34 +02:00
ff56a554f3
Merge branch 'master' into move-caught-object-vertical-offset
2021-07-04 17:26:24 +02:00
f3cd0be230
Merge pull request #13765 from peppy/fix-initial-volume-display-when-zero
...
Fix volume metre not correctly showing volume when initially zero
2021-07-04 16:55:24 +02:00
356f5dceef
Add more test case
2021-07-04 22:34:31 +08:00
5e148b273e
Merge branch 'master' into fix-initial-volume-display-when-zero
2021-07-04 16:16:01 +02:00
a7de3dd81c
Merge pull request #13766 from peppy/fix-zero-hit-score-submit
...
Don't attempt to submit score when nothing has been hit
2021-07-04 16:10:55 +02:00
44d540eb53
Add test
2021-07-04 22:09:23 +08:00
c143a50b73
Merge branch 'master' into fix-zero-hit-score-submit
2021-07-04 15:31:38 +02:00
