Commit Graph

9099 Commits

Author SHA1 Message Date
73f41439ae Remove redundant qualifiers 2022-08-25 13:34:58 +09:00
5cddc7ed1f Code cleanup (CPS) 2022-08-24 17:13:23 +02:00
c9ff39f8c3 Add HitResult.LegacyComboIncrease 2022-08-24 19:46:41 +09:00
5129716612 Merge branch 'master' into kps 2022-08-24 18:18:45 +09:00
ddccf4defe Remove dollar sign 2022-08-24 17:17:59 +09:00
27b57947e4 Rename PlayerArea.GameplayClock to SpectatorPlayerClock for clarity 2022-08-24 17:13:14 +09:00
5f01f461b3 Ensure elapsed time is always non-zero when advancing SpectatorPlayerClock 2022-08-24 17:13:14 +09:00
5079e0d83d Merge branch 'master' into no-gameplay-clock-gameplay-offset 2022-08-24 16:52:10 +09:00
adea29c106 Fix test failures 2022-08-24 03:37:33 -04:00
d33d705684 Make WaitingOnFrames non-bindable 2022-08-24 16:03:38 +09:00
c7d4c739aa Add a basic NaN control point test for LegacyBeatmapDecoder 2022-08-24 02:53:55 -04:00
995e6664b6 Rename spectator clock sync classes 2022-08-24 15:13:08 +09:00
31f657fe01 Remove ISpectatorPlayerClock interface
Too many levels of redirection.

One interface with one implementation is not useful, IMO.
2022-08-24 15:12:57 +09:00
46d000b8ce Fix test regressions on windows due to Reset never being called
I'm not sure this is great. Without calling `Reset`, the correct initial
time may not be set (ever). In practice this doesn't happen anywhere in
the gameplay flow, but something worth noting.

This change is required now that `Reset` isn't called in the
constructor. It couldn't be called in the constructor because it would
cause the audio track to reset its position too early.

What an ordeal.
2022-08-24 11:50:20 +09:00
ec61a94dc9 Merge branch 'master' into no-gameplay-clock-gameplay-offset 2022-08-23 17:36:06 +09:00
9a579871c0 Remove pointless initial import 2022-08-23 17:33:53 +09:00
a62deae3cc Use local realm rather than fetching from dependencies 2022-08-23 17:33:53 +09:00
690e048864 Ensure all initial imports are completed before running playlist overlay tests steps 2022-08-23 17:33:53 +09:00
553897f2f0 Remove AddClock method to CreateManagedClock 2022-08-23 13:52:43 +09:00
a81672f3dc Use an infinite tick distance instead of directly disabling tick generation for SliderEventGenerator 2022-08-22 23:31:24 -04:00
9f08c474ca Treat NaN slider velocity timing points as 1.0x but without slider ticks 2022-08-22 21:58:38 -04:00
e8d4bc4497 Allow NaN during beatmap parsing if desired 2022-08-22 21:04:26 -04:00
5d3d8681d4 Invert creation of clocks in multi spectator 2022-08-22 19:14:06 +09:00
b597049524 Code cleanup for CPS tests
- Remove null-forgiving operator usages
- Fix code quality issues mentionned by NVika
2022-08-22 10:47:37 +02:00
058d67f8e8 Merge pull request #19695 from naoei/ruleset-localization
Change most ruleset-accessible string types to Localisable strings
2022-08-22 16:13:23 +09:00
0815b01b75 Merge pull request #19783 from bdach/mod-select/presets-dont-open-customisation
Fix selecting preset containing Difficulty Adjust automatically opening customisation panel
2022-08-22 15:44:00 +09:00
af2e82d7d5 Move operation of setting GameplayClockContainer.StartTime to Reset call 2022-08-22 14:11:06 +09:00
c56390cd7b Use less custom classes for CPS tests 2022-08-22 00:03:24 +02:00
Nao
189a407cb1 Merge branch 'master' into ruleset-localization 2022-08-20 21:39:10 -04:00
3ac6500423 Add new test resources for CPS counter 2022-08-21 03:00:51 +02:00
da407aa827 Merge branch 'master' into kps 2022-08-20 15:24:58 +09:00
15d49b0357 Update TestSceneSpectator to user new assert style 2022-08-19 01:46:19 +09:00
3de35a1518 Update calculator and tests to match changes on clocks 2022-08-18 18:40:02 +02:00
cc86909633 Increase lenience on TestSceneLeadIn tests
I've gone through these in detail and can't find an issue with the
actual flow of things. For whatever reason, the new structure has a
slightly higher delay, likely due to performing less `Seek` calls
(previously a `Seek` was called after the clock start which may have
been making this more accurate on the first `Player.Update`).

I don't think it really matters that this is slightly off, but we'll see
how this plays out.
2022-08-19 01:39:00 +09:00
2eba8650ca Update TestSceneLeadIn to use new assert style 2022-08-18 19:26:19 +09:00
43879633db Ensure setting a StartTime on a GameplayClockContainer always resets to the new time 2022-08-18 18:54:10 +09:00
728cd96508 Update TestSceneLeadIn to use new assert style 2022-08-18 18:54:10 +09:00
fa167b1d12 Merge pull request #19779 from peppy/no-gameplay-clock
Remove all remaining usage of `GameplayClock`
2022-08-18 18:52:57 +09:00
7878231a73 Merge pull request #19817 from peppy/various-test-fixes
Refactor some tests
2022-08-18 14:39:43 +09:00
e7ddbc41c8 Merge branch 'master' into no-gameplay-clock 2022-08-17 22:21:10 +09:00
11301f52b7 Merge pull request #19814 from peppy/update-framework
Update framework (and other dependencies)
2022-08-17 19:24:01 +09:00
553ae4781f Remove unnecessary local implementation in TestScenePlaybackControl 2022-08-17 19:21:54 +09:00
4ef4d66f49 Add some extra initial state checks to TestSceneEditorSeekSnapping 2022-08-17 19:21:46 +09:00
3a0017c87b Fix flaky quick retry test 2022-08-17 17:09:44 +09:00
a5ac69a554 Update various dependencies 2022-08-17 16:57:56 +09:00
20256aad11 Merge branch 'master' into no-gameplay-clock 2022-08-17 15:21:20 +09:00
24fd411720 Merge pull request #19594 from BlauFx/improve_retry_behaviour
Skip song intro on quick restart
2022-08-16 20:18:12 +09:00
9a1a7bae89 Make test actually test things 2022-08-16 14:40:02 +09:00
6761f869f9 Modify flow to avoid weird bindable and value resetting 2022-08-16 14:17:35 +09:00
a15e6f19aa Fix running TestScenePlayerLoader interactively leaving volume in a bad state 2022-08-16 13:40:46 +09:00