32b4f5fbd6
Do not store direct references to original bindable
...
`DifficultyAdjustSettingsControl` and its inner `SliderControl` were
holding different references to `DifficultyBindable`s from the
difficulty adjust mod, therefore leading to bindings being lost to the
framework-side automatic unbind logic if the mod was toggled off and
back on in rapid succession.
Resolve by adding a shadowed implementation of `GetBoundCopy()` and
using it to isolate the controls from the mod bindable.
2021-07-11 15:28:13 +02:00
79d546afa2
Add missing osu!catch difficulty adjust attributes
2021-07-11 10:14:42 +09:00
b705213ea9
Update test to match expectations after refactor
2021-07-10 11:44:32 +02:00
6f89f8e572
Merge branch 'master' into da-mod-refactor
2021-07-10 11:41:54 +02:00
e8005e3bfb
Merge pull request #13841 from peppy/update-song-progress-keyboard-handling
...
Move handling of replay seek operations out of progress bar
2021-07-10 11:17:40 +02:00
6ae631b03a
Remove previous seek testing logic from common test scene
2021-07-09 16:52:03 +09:00
9083b28114
Add test coverage of seeking and pausing
2021-07-09 14:47:11 +09:00
6a5f0e8237
Move handling of replay seek operations out of progress bar
...
This is in order to avoid using the now obsoleted property
`SliderBar.AllowKeyboardInputWhenNotHovered`
(see https://github.com/ppy/osu-framework/pull/4579 ).
2021-07-09 14:28:59 +09:00
741062a6da
Simplify bindable update methods
2021-07-09 13:58:44 +09:00
e0277763d0
Refactor DifficultyAdjustSettingsControl to help with readability
2021-07-09 13:50:07 +09:00
51bd83b3f4
Update override matching test to match expectations
2021-07-09 13:30:14 +09:00
f9cd7f10d8
Allow null values for ReadCurrentFromDifficulty
...
As long as this isn't a constructor parameter it feels best to
gracefully handle omission. Realistically having it in the ctor is the
best move, but it doesn't feel great in line with the other parameters
passed in via object initalisers.
2021-07-09 13:26:01 +09:00
90326f8864
Standardise variables
2021-07-09 13:24:26 +09:00
f3b68a4fbf
Fix storage wrapping logic setting logger too early in startup sequence
2021-07-09 13:17:25 +09:00
dbfeea9880
Merge pull request #13831 from nekodex/add-dropdown-sound-to-profile
...
Change profile section expansion button to use dropdown sounds
2021-07-09 11:58:48 +09:00
2eb12a59b7
Rename function to be more accurate
2021-07-09 11:16:47 +09:00
bd3f8b78cc
Merge pull request #13827 from peppy/fix-mod-select-cross-talk
...
Fix cross talk between `ModSelectOverlay`s
2021-07-08 20:31:55 +02:00
3e21eeb7c2
Merge branch 'master' into fix-mod-select-cross-talk
2021-07-08 19:53:50 +02:00
1c7854b846
Merge pull request #13830 from nekodex/volume-control-switching-sound
...
Add sound for switching between volume controls
2021-07-09 01:03:36 +09:00
b7803b889e
Rename control class to be more descriptive
2021-07-08 20:37:38 +09:00
8746ef0ba9
Avoid double playback of sample
2021-07-08 20:36:25 +09:00
546f55d341
Change profile section expansion to use dropdown sounds
2021-07-08 20:23:11 +09:00
93eb385dd4
Add sound for switching between volume controls
2021-07-08 20:01:39 +09:00
7153983dd4
Add test coverage
2021-07-08 18:29:54 +09:00
af270cccc4
Fix cross talk between ModSelectOverlays
2021-07-08 17:59:04 +09:00
ba939c0b65
Simplify serialisation edge case by moving to Value override
2021-07-08 17:49:00 +09:00
52ea62e3b2
Add more comments and xmldoc
2021-07-08 17:49:00 +09:00
533db01cc0
Add comprehensive tests of difficulty adjust settings
2021-07-08 17:49:00 +09:00
88b00123f6
Use existing reflection methods to avoid manual binding of ExtendedLimits
2021-07-08 17:49:00 +09:00
bd7c334588
Avoid the need for per-settings control classes
2021-07-08 17:49:00 +09:00
a6e94dd491
Add back extended limits support
2021-07-08 17:49:00 +09:00
c4313d6e96
Initial implementation of new flow (only working for approach rate)
2021-07-08 17:48:08 +09:00
fcee69ffe6
Fix ShowsDefaultIndicator not actually being consumed
2021-07-08 17:48:08 +09:00
d540156e94
Remove now unnecessary BeatmapDifficulty.ID
2021-07-08 14:31:25 +09:00
0e4f4a6fde
Initial storage changes
2021-07-08 14:28:13 +09:00
8d94e8f534
Enable tests and update expectations
2021-07-08 14:28:05 +09:00
341cb09c6e
Update terminology in README
...
At some point we'll want to replace the link to the outdated blog post (or just remove it?) with the gantt or otherwise.
2021-07-08 12:06:52 +09:00
64a02fe10f
Merge pull request #13813 from ekrctb/catch-selection-alive
...
Fix catch selection blueprint not displayed after copy-pasted
2021-07-07 21:54:32 +09:00
e612d7568c
Merge pull request #13771 from LumpBloom7/volume-meter-switch
...
Add ability to navigate between volume meters via Alt+Left/Right arrows
2021-07-07 21:50:44 +09:00
ddca132ab5
Add difficulty adjustment mod tests
2021-07-07 21:38:38 +09:00
7d405f04fb
Fix selected volume control not updating correctly on mouse move
2021-07-07 21:17:31 +09:00
cbe4114e90
Adjust visuals and make base opacity 100%
2021-07-07 21:07:00 +09:00
f1aa99e103
Fix catch selection blueprint not displayed after copy-pasted
2021-07-07 21:03:26 +09:00
83283a706e
Add test scene
2021-07-07 20:51:13 +09:00
e42609f092
Merge pull request #8038 from thewildtree/adjust-rankings-overlay
...
Adjust rankings overlay elements to better match osu-web
2021-07-07 20:24:11 +09:00
f7dc689832
Merge pull request #13804 from bdach/migrate-directory-selector
...
Migrate file/directory selectors to use framework component instead of local implementation
2021-07-07 20:10:26 +09:00
4d7c744101
Fix failing test
2021-07-07 12:59:31 +02:00
f53f6690e3
Remove extra blank line
2021-07-07 12:01:47 +02:00
9a5b322a2b
Merge pull request #13812 from ekrctb/catch-editor-border
...
Add playfield border to catch editor
2021-07-07 18:56:20 +09:00
8b1876bc2a
Disallow removing items from SelectionCycleFillFlowContainer
2021-07-07 11:43:54 +02:00
