35d4b12a4f
Remove single local usage of AllSources
2021-07-07 13:52:52 +09:00
eb8b14a931
Reorder methods to make more sense
2021-07-07 13:51:51 +09:00
523546d8b6
Use List to guarantee lookup order
2021-07-06 22:51:56 +09:00
255f7b7b53
Add failing test scene
2021-07-06 22:44:23 +09:00
d75d67577a
Fix regressed tests
2021-07-06 17:37:34 +09:00
cd4885e450
Add xmldoc and remove any question of how the intitial flow is being run
2021-07-06 17:18:45 +09:00
032c285ede
Move private downwards
2021-07-06 17:07:29 +09:00
1232925f93
Make source manipulation methods protected
2021-07-06 17:06:00 +09:00
b4240d3ca4
Simplify lookups to avoid a second dictionary fetch
2021-07-06 17:04:59 +09:00
ec1224218c
Localise source changed flow for better clarity
2021-07-06 16:57:19 +09:00
935fbe7cc6
Remove double fetch/binding of parent source
2021-07-06 16:51:29 +09:00
93ef783339
Remove BindableList usage
2021-07-06 16:40:23 +09:00
fe70b52086
Merge pull request #13793 from ekrctb/catch-hit-object-serialization
...
Fix copy-and-paste not working in osu!catch editor
2021-07-06 16:38:05 +09:00
32e6c9c5d3
Merge pull request #13786 from peppy/multiplayer-test-fixes
...
Fix multiplayer test failures due to leaderboard load process
2021-07-06 16:33:41 +09:00
4366be5c1f
Merge pull request #13792 from peppy/fix-migration-cleanup-failure
...
Fix potential failure during cleanup of files in migration tests
2021-07-06 15:39:04 +09:00
175d666906
Use getters of OriginalX and XOffset
2021-07-06 15:32:32 +09:00
ae1b1cbec9
Allow serialization of catch hit objects
2021-07-06 15:32:32 +09:00
7f7cf0b927
Fix potential failure during cleanup of files in migration tests
2021-07-06 15:08:00 +09:00
d07c469a89
Merge pull request #13783 from smoogipoo/smooth-auto-gen
...
Make osu! auto generator interpolate during key-up frames
2021-07-06 15:04:40 +09:00
0658cfb986
Throw exceptions rather than silently failing if attempting to add a clock for a non-tracked user
2021-07-06 14:56:00 +09:00
1a6b8b2c73
Populate UserScores as early as possible to avoid weird ordering requirements
2021-07-06 14:53:31 +09:00
2cd1bde2bf
Merge pull request #13790 from PercyDan54/remove-redundant-arg
...
Remove redundant arguments
2021-07-06 14:00:59 +09:00
af02a1efcb
Bump redundant argument default value inspection severity to warning
2021-07-05 21:02:40 +02:00
686dd2b5ce
Remove unused constant
2021-07-05 20:35:14 +02:00
8e102280b7
Revert & disable case with two contradicting inspections
...
Leaving the `false` default value without the suppression triggers
`RedundantArgumentDefaultValue`, while removing it triggers
`BaseMethodCallWithDefaultParameter`.
Disable the former, because a single redundant parameter is less bad
than silent breakage if the default value of `propagateChildren` in the
base method ever changes.
2021-07-05 20:21:44 +02:00
f5ddd2a53b
Fix critical failure causing scores to not update on the leaderboard
2021-07-06 01:15:30 +09:00
e1c646b9b2
Remove redundant arguments
2021-07-05 23:52:39 +08:00
c7f03dd9f7
Merge pull request #13789 from PercyDan54/disable-inspections
...
Disable IDE0057 and IDE0042 inspection
2021-07-06 00:41:01 +09:00
a4545051f2
Suppress IDE0042
2021-07-05 23:36:15 +08:00
fdfdfeecab
Suppress IDE0057
2021-07-05 23:36:10 +08:00
01961fe4f9
Merge pull request #13747 from ekrctb/catcher-flip
...
Don't flip catcher plate contents when catcher changes direction
2021-07-06 00:02:23 +09:00
0253d753af
Merge branch 'master' into multiplayer-test-fixes
2021-07-05 21:51:53 +09:00
f1014af284
Move LoadComplete content to run after user retrieval has completed
...
Feels safer, I think.
2021-07-05 21:35:41 +09:00
459f9a0465
Handle nulls and fix missing documentation
2021-07-05 21:35:37 +09:00
d247b8042e
Fix default skin catcher not flipping catcher plate
...
When legacy beatmap skin is present but catcher is not provided, it was using the legacy setting (always false).
2021-07-05 20:05:08 +09:00
991db4611e
Merge pull request #13784 from peppy/fix-incorrect-filename
...
Fix remaining incorrect filename
2021-07-05 20:02:56 +09:00
77adf687c6
Consume ability to lookup multiple users in MultiplayerGameplayLeaderboard
...
Avoids syncrhonously blocking on asynchronous operations (which was
leading to LCA starvation in tests).
2021-07-05 19:56:37 +09:00
9c311a6d8a
Add ability to lookup multiple users at once to UserLookupCache
2021-07-05 19:56:16 +09:00
10e7c846e5
Add local UserLookupCache to avoid online requests being fired from multiplayer tests
2021-07-05 19:41:00 +09:00
9c2fed4806
Move setup steps to SetUpSteps and add empty test case
2021-07-05 19:10:27 +09:00
28faa8c330
Merge pull request #13780 from peppy/disable-foreign-keys
...
Disable foreign key enforcing at an sqlite level
2021-07-05 19:08:10 +09:00
2398859b66
Merge pull request #13781 from peppy/fix-multi-spec-test-failures
...
Fix master clock becoming incorrectly paused when all spectator players are too far ahead
2021-07-05 19:01:51 +09:00
cd2916f778
Fix remaining incorrect filename
2021-07-05 18:56:59 +09:00
bf4be2dfc7
Merge pull request #13782 from peppy/fix-incorrect-filename
...
Fix incorrect filename
2021-07-05 18:53:41 +09:00
8b7ccdc8b5
Adjust comment
2021-07-05 18:51:23 +09:00
7d6ab08bb3
Remove unnecessary conditional
2021-07-05 18:49:09 +09:00
695af31c58
Start alternating at 225BPM as previously
2021-07-05 18:43:27 +09:00
7645da7d37
Fix incorrect filename
2021-07-05 18:20:04 +09:00
2b8efe21ca
Don't ease with 0 time difference
2021-07-05 17:52:10 +09:00
229bba14e6
Fix master clock becoming incorrectly paused when all spectator players are too far ahead
2021-07-05 17:45:08 +09:00
