Commit Graph

50166 Commits

Author SHA1 Message Date
762de3cc97 Replace invalidation logic with local realm notification subscription 2022-04-01 16:01:33 +09:00
9c3dad9fbf Add proof of concept flow to ensure RealmBackedResourceStore is invalidated on realm file changes
I'm not at all happy with this, but it does work so let's go with it for
now.
2022-04-01 16:01:33 +09:00
66f5eae530 Hook up a dropdown to show all available sprites for the current skin 2022-04-01 15:01:43 +09:00
fca9faac9b Add SkinnableSprite for arbitrary sprite additions 2022-04-01 14:36:36 +09:00
3a16483214 Add prioritised user lookups for default skin
This allows user resources to be consumed before falling back to the
game bundled assets.
2022-04-01 14:36:36 +09:00
6b9f5812a5 Merge pull request #17579 from CenTdemeern1/clock-button
Make the toolbar clock feel more like a button
2022-04-01 13:12:48 +09:00
10f15f2bdb Merge pull request #17559 from bdach/mod-overlay/sheared-toggle
Implement sheared toggle button
2022-04-01 13:06:22 +09:00
338a21f4f0 Merge pull request #17581 from CenTdemeern1/remove-bpm-slider
Remove BPM slider
2022-04-01 11:59:16 +09:00
912b6ae8ff Merge pull request #17194 from hlysine/extract-random-mod-logic-2
Extract the hit object positioning logic of random mod to a separate class
2022-04-01 11:28:53 +09:00
058350dfd8 Fix failing test due to incorrect sizing specification 2022-04-01 10:53:16 +09:00
86d262a355 Merge branch 'ppy:master' into clock-button 2022-03-31 23:08:30 +02:00
d5b0c0ba8c Merge pull request #17575 from peppy/runtime-clock-weight
Increase font weight for runtime clock
2022-03-31 22:30:08 +02:00
1c7b259f8e Merge branch 'master' into mod-overlay/sheared-toggle 2022-03-31 22:20:20 +02:00
e180db145d Add constructor argument to facilitate fixed width/autosizing 2022-03-31 22:19:08 +02:00
b3896257ca Move shear amount to constant 2022-03-31 22:09:03 +02:00
48df34d0a8 Merge branch 'master' into runtime-clock-weight 2022-03-31 21:24:45 +02:00
e14d5b8adb Remove unused using directives 2022-03-31 21:20:30 +02:00
a6875383fc Rebind SaveState() to bpmTextEntry 2022-03-31 21:06:05 +02:00
bdb21b17f7 Fix my code according to the changes @bdach requested 2022-03-31 20:39:26 +02:00
52d723aaa6 Remove BPM slider 2022-03-31 20:11:07 +02:00
c64a90b39e Remove a newline to comply with codefactor 2022-03-31 17:21:50 +02:00
f1aa60c0f1 Make the clock feel more like a button 2022-03-31 16:26:53 +02:00
46be6bcadc Merge pull request #17574 from peppy/fix-tournament-bracket-invalid-ruleset-id
Fix tournament bracket parsing's ruleset refetch logic not working correctly
2022-03-31 19:18:18 +09:00
0a34ce2509 Increase font weight for runtime clock
Fonts this small are required to be `SemiBold` by design guidelines.
Somehow missed this.
2022-03-31 19:07:30 +09:00
a06b0a4966 Fix tournament bracket parsing's ruleset refetch logic not working correctly
Due to equality being based on `ShortName`, it was feasible that the
re-fetch exited early (in bindable shortcutting logic) causing the
ruleset's `OnlineID` to remain `-1` or something equally wrong.

Resolves issue pointed out at
https://github.com/ppy/osu/discussions/17538#discussioncomment-2471746.
2022-03-31 18:41:00 +09:00
a7a7584d3e Add test coverage ensuring ruleset ID is correct after bracket read
Historically, tournament client may have written incorrect `OnlineID`
values. We wanted to use `ShortName` to re-fetch the ruleset. This test
ensures this flow is working correctly.
2022-03-31 18:39:58 +09:00
bc4d6a3ace Merge pull request #17570 from peppy/fix-settings-textbox-focus
Focus focus not being transferred correctly to parent settings panel on exiting nested panel
2022-03-31 18:07:51 +09:00
140eaa6039 Merge pull request #17572 from peppy/fix-multi-sounds-explosion
Fix multiplayer sounds playing too much after gameplay
2022-03-31 16:52:24 +09:00
ef5e37c47a Fix multiplayer sounds playing too much after gameplay
Regressed in https://github.com/ppy/osu/pull/15936.

Closes #17295.
2022-03-31 16:18:28 +09:00
ad14b7cac5 Merge pull request #17565 from smoogipoo/fix-gameplay-leaderboard-allocations
Remove ScoreInfo allocations in multiplayer leaderboard
2022-03-31 15:48:14 +09:00
496e025fae Merge pull request #17569 from Joehuu/ignore-line-ending-rev
Ignore line ending normalisation commit from blame
2022-03-31 15:31:53 +09:00
726b49fdf3 Focus focus not being transferred correctly to parent settings panel on exiting nested panel
Seemingly harmless schedule delay ommission meant that the textbox may
not be in a state it can handle the incoming focus event. Regressed in
https://github.com/ppy/osu/pull/14345#discussion_r690697501.
2022-03-31 15:24:21 +09:00
e8a295a61b Add test coverage of textbox focus in settings panels when switching between nested panels 2022-03-31 15:24:21 +09:00
538e553455 Merge pull request #17568 from Joehuu/fix-logo-clicking-when-exiting
Fix osu! logo being clicked when exiting via cmd-q on initial state
2022-03-31 14:12:15 +09:00
615e4f0f3b Ignore line ending normalisation commit from blame 2022-03-30 21:58:39 -07:00
ff4745be59 Merge branch 'master' into extract-random-mod-logic-2 2022-03-31 13:42:47 +09:00
36c02573a8 Fix osu! logo being clicked when exiting via cmd-q on initial state 2022-03-30 21:26:30 -07:00
d17cf0631f Merge pull request #17509 from peppy/fix-autoplay-mod-user-id
Fix autoplay avatar being clickable on results screen
2022-03-31 12:56:42 +09:00
9c19ae1df8 Remove no longer necessary ruleset field 2022-03-31 06:40:38 +03:00
6e94a9780b Remove ScoreInfo allocations in multi leaderboard 2022-03-31 12:23:00 +09:00
e0d434b89f Remove unused using statement 2022-03-31 11:34:32 +09:00
0cac935939 Shorten class name of ModCreatedReplayUser 2022-03-31 11:34:23 +09:00
2c1ccc7d36 Update obsolete message to match targeted developers' use case
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-03-31 11:33:26 +09:00
234bec45cc Remove unnecessary logging 2022-03-31 11:32:00 +09:00
6874cdf0c8 Remove unnecessary public prefix in interface method 2022-03-31 01:50:46 +03:00
3ac0da2da3 Implement sheared toggle button 2022-03-30 22:50:21 +02:00
f4184cb6fe Fix typo in step name 2022-03-30 22:04:55 +02:00
436dec68c9 Use provided extension method instead of reimplementing locally 2022-03-30 22:04:54 +02:00
83bae81095 Fill out ICreateReplayData xmldocs 2022-03-30 22:04:54 +02:00
9621a7f9cb Merge branch 'master' into fix-autoplay-mod-user-id 2022-03-30 21:41:45 +02:00