7b274083d3
Fix phantom beatmap sets appearing on carousel after delete/update
...
Regressed in c40c70509e
.
As it turns out, `item.Item.Filtered.Value` is not the only condition
that should be checked to determine if a carousel item should be hidden
or not - `item.Item.State.Value != CarouselItemState.Collapsed` should
also be true. This was even available as the `item.Item.Visible`
convenience property, which is used in this commit.
Failing to check `item.Item.State.Value` led to setting non-zero alpha
on collapsed carousel items, leading to phantom beatmap sets appearing,
as the alpha was set in the entire carousel's `Update()` method, thus
firing every frame.
2022-11-20 10:08:34 +01:00
b3667821eb
Add failing test case
2022-11-20 10:07:32 +01:00
9724c6bb53
Merge pull request #21205 from Samaoo/fix-tablet-aspect-ratio-values
...
Fix incorrect rounding of tablet aspect ratio values
2022-11-19 15:08:53 +01:00
0c671a2a82
Merge branch 'master' into fix-tablet-aspect-ratio-values
2022-11-19 14:32:24 +01:00
8bde669de1
Merge pull request #21266 from peppy/editor-test-play-dont-retain-test-time
...
When returning to the editor after test play, use the original editor time rather than the point of exit
2022-11-19 12:41:25 +01:00
c05c1625f2
Merge branch 'master' into editor-test-play-dont-retain-test-time
2022-11-19 12:09:04 +01:00
130f776427
Merge pull request #21267 from peppy/catch-file-enumeration-errors
...
Catch and gracefully handle file/directory enumeration failures during stable import
2022-11-19 15:38:40 +09:00
866b8b640a
Merge pull request #21310 from frenzibyte/fix-present-beatmap-test
...
Fix intermittent present beatmap test failures
2022-11-19 15:38:07 +09:00
5fda702267
Merge pull request #21306 from frenzibyte/fix-editor-seeking-state
...
Fix editor not always playing hitsounds with clock offsets applied
2022-11-19 15:08:53 +09:00
ca67689a36
Fix intermittent present beatmap test failures
2022-11-19 07:44:43 +03:00
016de2f5a0
Fix editor not always playing hitsounds with clock offsets applied
2022-11-19 05:15:22 +03:00
4648e7bee0
Merge pull request #21299 from frenzibyte/perform-from-runner-load-state
...
Fix "perform from screen" invoking action on non-loaded screens
2022-11-19 09:55:21 +09:00
d587f29351
Update tests to reflect desired behaviour
2022-11-18 21:03:30 +01:00
8943819ee7
Add test coverage
2022-11-18 17:49:03 +03:00
1be8c6bd9c
Fix "perform from screen" not considering screen load state
2022-11-18 17:23:10 +03:00
b86b45b6d2
Fix excess string interpolation
2022-11-18 21:13:21 +09:00
da0de7c39e
Merge pull request #21191 from Piggey/gameplay-leaderboard-fix
...
Display - symbol when tracked in-game leaderboard score is below 50
2022-11-18 20:23:21 +09:00
9ad484a0f4
Merge branch 'ppy:master' into gameplay-leaderboard-fix
2022-11-18 12:11:22 +01:00
e4fc14faee
Merge pull request #21270 from peppy/auto-advance-bindings
...
Auto-advance binding for ruleset key bindings
2022-11-18 16:19:54 +09:00
9d33a6568e
Merge pull request #21292 from peppy/fix-binding-two-keys-single-binding
...
Fix being able to bind two non-modifier keys to the same binding
2022-11-18 16:19:38 +09:00
d8e99d811d
Merge pull request #21293 from frenzibyte/fix-timeline-extent-scrolling
...
Fix timeline potentially scrolling at extents while not dragging
2022-11-18 16:19:30 +09:00
7c08cff297
Make new test more resilient to false passes
2022-11-18 16:10:32 +09:00
d59befc9d3
Fix initial visual state of positions before sort
runs
2022-11-18 16:08:27 +09:00
0a520c979e
Update test to split out per-type tests
2022-11-18 16:03:40 +09:00
aff218dfd5
Redirect through validity function rather than overriding Sort
2022-11-18 16:03:40 +09:00
20af8217f4
Tidy up bindable flow
2022-11-18 15:50:41 +09:00
e4f522aad1
Fix inspections / typos
2022-11-18 15:47:37 +09:00
d17c091d63
Move constant to a better location
2022-11-18 15:47:31 +09:00
e2aca8dc90
Suppress nullable warning for now
2022-11-18 09:46:50 +03:00
3faa7f5f74
Merge branch 'master' into gameplay-leaderboard-fix
2022-11-18 15:44:30 +09:00
90cd386323
Fix timeline potentially scrolling at extents while not dragging
2022-11-18 09:43:16 +03:00
bab5be8dee
Merge pull request #21290 from smoogipoo/multiplayer-test-debug
...
Add some debugging for multiplayer test failures
2022-11-18 15:39:33 +09:00
e658efbefa
Fix being able to bind two non-modifier keys to the same binding
2022-11-18 15:34:41 +09:00
cb8275ee75
Add failing test coverage to TestSceneKeyBindingPanel
for multiple non-modifiers being bound
2022-11-18 15:34:41 +09:00
45f5849301
Add more test coverage to TestSceneKeyBindingPanel
2022-11-18 15:33:14 +09:00
c2a127dc68
Merge pull request #21289 from peppy/fix-triangle-button-flash
...
Fix triangle button flash effect looking incorrect
2022-11-18 15:26:43 +09:00
219d049edf
Merge pull request #21140 from maromalo/long-standard
...
Standardise scores to `long` type
2022-11-18 15:26:33 +09:00
cc434c9113
Merge pull request #21288 from peppy/fix-no-network-slow-gameplay-load
...
Fix entering gameplay while network connection is in a bad state taking too long
2022-11-18 15:24:31 +09:00
7e9d2ecaf5
Merge pull request #21287 from peppy/fix-null-ref-persistent-endpoint-connector
...
Fix potential incorrect connection state resulting in null reference
2022-11-18 15:08:33 +09:00
b0faa009c1
Add some debugging for multiplayer test failures
2022-11-18 14:52:11 +09:00
5fc0d45675
Fix triangle button flash effect looking incorrect
2022-11-18 14:30:59 +09:00
57b8495c7a
Merge branch 'master' into long-standard
2022-11-18 14:24:04 +09:00
d47c46d144
Compute raw score in-line
...
Saves on an allocation (though it seems to only be a ValueType so it
shouldn't be a big deal) and a tail-call.
2022-11-18 14:22:28 +09:00
964ceddf83
Fix API queue only being flushed once while in a failing state
2022-11-18 14:21:37 +09:00
e4d134a820
Reduce time waited on a score submission token from 60 to 30s
2022-11-18 14:07:40 +09:00
2fb93fd46c
Merge pull request #21268 from peppy/fix-path-change-expected-length
...
Fix sliders not correctly taking on full available length after changing curve type
2022-11-18 14:06:50 +09:00
1b1fed723d
Merge pull request #21269 from peppy/fix-key-bindings-keyword
...
Move "keybindings" keyword to correct section
2022-11-18 14:05:08 +09:00
551192b413
Refactor a bit for readability
2022-11-18 13:55:37 +09:00
005e475801
Merge pull request #21286 from frenzibyte/fix-test-failure
...
Fix beatmap options test failure due to no beatmap selected
2022-11-18 13:47:06 +09:00
a5d22195f2
Fix potential incorrect connection state resulting in null reference
2022-11-18 13:45:46 +09:00