Commit Graph

22573 Commits

Author SHA1 Message Date
69ac22dd7f Fix incorrectly copy pasted xmldoc 2021-01-07 19:06:10 +09:00
8f52a83b29 Share hover sound debounce across all instances via SessionStatics 2021-01-07 18:47:20 +09:00
6620eadec3 Reduce default hover sound debounce interval 2021-01-07 18:47:03 +09:00
303cc62ee7 Transfer flags indicating if settings were changed 2021-01-06 22:46:46 +01:00
4998aaaa98 Remove outdated warning disable
Does not trigger any more on Rider 2020.3.2.
2021-01-06 18:38:25 +01:00
68352782db Change .StartsWith() to .Equals()
In line with planned-but-delayed breaking change.
2021-01-06 18:38:24 +01:00
9cc63e8dce Remove obsoleted IHasEndTime 2021-01-06 18:38:24 +01:00
539785e422 Remove obsoleted IHasCurve 2021-01-06 18:38:24 +01:00
09742998cd Fix mistaken obsoletion notice
It was added in c9f38f7bb6, which
specified 2021 in another place (and was committed in October of 2020
anyway). Update the year so that it doesn't get culled prematurely.
2021-01-06 18:38:24 +01:00
a761ec952a Merge branch 'master' into remove-osu-direct 2021-01-06 17:32:12 +01:00
866fb28d6c Merge pull request #11411 from LavaDesu/feature/discord-presence-toggle
Add ability to toggle discord rich presence
2021-01-07 00:52:38 +09:00
4c2caec72e Merge branch 'master' into remove-osu-direct 2021-01-06 16:49:38 +01:00
35be7ec0e1 Add back button but rename to "browse" 2021-01-06 23:28:14 +09:00
cfbfb8d58b Revert "Remove related events"
This reverts commit 59025e9d50.
2021-01-06 23:21:46 +09:00
283c69a68f Update enum name in line with changes 2021-01-06 23:12:56 +09:00
59025e9d50 Remove related events 2021-01-06 23:09:58 +09:00
32accc8eab Remove "osu!direct" button 2021-01-06 22:56:10 +09:00
7651d4554a Merge branch 'master' into fix-transform-carousel 2021-01-06 13:49:05 +01:00
43b9fde457 Add some nullability annotations for good measure 2021-01-06 13:15:15 +01:00
99701a6d9b Add null check on beatmapContainer for safety 2021-01-06 21:06:33 +09:00
ffafdf2209 Merge branch 'master' into fix-transform-carousel 2021-01-06 21:03:22 +09:00
25b4628672 Merge branch 'master' into fix-transform-mutation-from-background 2021-01-06 11:04:51 +01:00
07cff70387 Add specific messaging for when there's no background stack available 2021-01-06 18:19:03 +09:00
6572bb18de Merge branch 'master' into fix-transform-mutation-display-settings 2021-01-06 10:09:14 +01:00
550ef3f133 Aggressively dispose ownedBackground if it was not used, because we can 2021-01-06 15:28:01 +09:00
e9d4e4d1d5 Add xmldoc and throw a local exception on null background 2021-01-06 15:26:44 +09:00
11a0c637bc Mark background properties as nullable 2021-01-06 15:26:00 +09:00
15dd7a87a6 Move gameplay preview event binding to LoadComplete 2021-01-06 15:19:12 +09:00
52687fc37c Merge branch 'master' into fix-transform-mutation-loading-layer 2021-01-05 23:10:51 +01:00
0880e76da8 Mark background dim layer as possibly-null 2021-01-05 22:56:53 +01:00
ac1d6d4444 Make auto-property get-only 2021-01-05 22:56:53 +01:00
2b253f6d01 Remove now-unused fields & locals 2021-01-05 22:56:53 +01:00
fbbc26d7d8 Merge branch 'master' into fix-carousel-centering-on-window-resize 2021-01-05 21:30:39 +01:00
847d2d8deb Merge branch 'master' into fix-transform-mutation-from-disposal-thread 2021-01-05 19:52:10 +01:00
4b539b01c1 Match code between updateSelectedBeatmap/Ruleset 2021-01-05 20:38:58 +09:00
83dbba3cbf Fix carousel beatmap set panels applying transforms to difficulties while they are loading 2021-01-05 18:41:45 +09:00
d0d2e41b28 Fix display settings binding to configuration bindables in async load 2021-01-05 18:19:28 +09:00
0639429a23 Fix test (and remove no longer valid test) 2021-01-05 18:10:39 +09:00
3b98782964 Merge pull request #11420 from kyekiller/master
Fix to toolbar tooltips
2021-01-05 17:43:32 +09:00
0b1ee2e267 Remove unused dispose logic 2021-01-05 17:42:19 +09:00
54982dcdd7 Refactor LoadingLayer to avoid applying effects to external drawables
In theory this seemed like a good idea (and an optimisation in some
cases, due to lower fill rate), but in practice this leads to weird edge
cases.

This aims to do away with the operations on external drawables by
applying a dim to the area behind the `LoadingLayer` when required.
I went over each usage and ensured they look as good or better than
previously.

The specific bad usage here was the restoration of the colour on dispose
(if the `LoadingLayer` was disposed in a still-visible state).

I'm aware that the `BeatmapListingOverlay` will now dim completely during
load. I think this is fine for the time being.
2021-01-05 17:31:45 +09:00
5d8c153c1e Move schedule logic to buttons rather than section
It turns out there's some quite convoluted scheduling / order of
execution requirements of ModSelectOverlay and ModSection. Applying
scheduling causes a runaway condition ending in zero frames after many
mod button changes.

I wanted to avoid rewriting the whole component, so have just moved the
schedule to guard against the part where drawables are actually changed.
2021-01-05 16:41:05 +09:00
4d6c13f169 Privatise ModSelectOverlay methods that may be unsafe to be called externally 2021-01-05 16:18:13 +09:00
9bac791a57 Fix deselection of autoplay mod failing 2021-01-05 16:17:58 +09:00
57a8cd7461 Schedule deselection operations for safety 2021-01-05 16:17:58 +09:00
60fc60fa00 Merge pull request #11415 from frenzibyte/fix-ready-button-crash
Fix multiplayer ready button crashing when deleting selected beatmap set
2021-01-05 15:58:09 +09:00
b3f08b29ca Ensure that all changes to screen backgrounds are on the correct thread 2021-01-05 15:22:50 +09:00
a3e4e2f6c3 Switch ResultsScreen and SongSelect inheritance and remove local implementation 2021-01-05 15:22:50 +09:00
962c95dc01 Fix ModSelection making unsafe advances of ModSection 2021-01-05 15:19:37 +09:00
ed6ffe2ef1 Remove hacky code 2021-01-05 14:54:59 +09:00