7cc4fd4efc
Use the exact method stable uses for generating storyboard filenames
2023-01-26 15:09:36 +09:00
d15f8c2f3a
Fix beatmaps with multiple osb files potentially reading the storyboard from the wrong one
...
In stable, the storyboard filename is fixed. In lazer, we were always
looking for the first `.osb` in the database. In the case a beatmap
archive housed more than one `.osb` files, this may load the incorrect
one.
Using `GetDisplayString` here feels like it could potentially go wrong
in the future, so I'm open to hard-coding this locally (or using string
manipulation to remove the ` [creator_name]` portion of the beatmap's
filename). Open to opinions on that.
Fixes storyboard playback in https://osu.ppy.sh/beatmapsets/1913687#osu/3947758
2023-01-25 17:11:15 +09:00
4674956ccf
Merge pull request #22318 from naoey/fix-copy-difficulty-moving-collections
...
Fix creating a copy of a difficulty in the editor removing the original beatmap from user collections
2023-01-25 15:06:46 +09:00
73d7043201
Merge pull request #22383 from jai-x/wikimarkdown-update-tests
...
Update `WikiMarkdownContainer` tests
2023-01-25 14:20:47 +09:00
6efab635d8
Merge branch 'master' into fix-copy-difficulty-moving-collections
2023-01-25 14:11:32 +09:00
392ff2ffea
Reword comment regarding hash transfer to make more sense
2023-01-25 14:11:02 +09:00
741ca96853
Make transferCollections argument to private method explicitly required
2023-01-25 14:09:13 +09:00
739ec8d81d
Add argument hint for nondescript bool
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2023-01-25 14:04:30 +09:00
b182178340
Merge pull request #22325 from sw1tchbl4d3r/sv_scaling
...
Move fixed scroll speed change out of classic mod for taiko
2023-01-25 12:55:43 +09:00
7e9b3fb253
Merge pull request #22400 from frenzibyte/fix-ios-ci
...
Fix iOS workflow still targeting old Xcode version
2023-01-25 10:30:23 +09:00
4d4dfd9e8b
Fix iOS workflow still targeting old Xcode version
2023-01-25 02:15:08 +03:00
a3bb6d1fab
Revert a few more relative to absolute changes
...
Because not sure why they were changed in the first place.
2023-01-25 00:00:23 +01:00
4d7cd59df3
Fix TestAbsoluteImage() no longer actually testing absolute image URL
2023-01-24 23:58:39 +01:00
c991aa5ca4
TestSceneWikiMarkdownContainer: Revert CurrentPath changes and update markdown img links only
2023-01-24 22:01:53 +00:00
edb9c76edf
Merge pull request #22385 from peppy/touchscreen-settings-keyword
...
Fix touch input handler settings not matching search for "touchscreen"
2023-01-24 20:50:53 +01:00
054938be02
Merge pull request #22387 from peppy/beatmap-leaderboard-cancel-request-eagerly
...
Fix beatmap leaderboard potentially showing incorrect leaderboard
2023-01-24 19:49:11 +01:00
d56f528a3d
Merge pull request #22390 from Joehuu/fix-changelog-depth
...
Fix changelog overlay potentially showing up behind mod select overlay
2023-01-24 18:35:00 +09:00
b9291cb116
Change some order and assert for positive visibility before scheduling an operation in changelog overlay
2023-01-24 17:59:25 +09:00
c6bf755e68
Remove IsPresent override from ChangelogOverlay
2023-01-24 00:22:29 -08:00
df895c4fd6
Always make settings footer build display clickable
2023-01-24 00:21:39 -08:00
a966d6c330
Merge pull request #18402 from ggliv/mod-accuracy-challenge
...
Add accuracy challenge mod
2023-01-24 16:00:55 +09:00
b46ef67a14
increase min minimum accuracy to 60%
2023-01-24 00:31:46 -05:00
bb15ee50e0
Fix beatmap leaderboard potentially showing incorrect leaderboard
2023-01-24 13:52:59 +09:00
3cd810f332
Merge pull request #22265 from Wleter/SliderEnd-Snap
...
Add snapping sliderends with nearby objects
2023-01-24 13:43:43 +09:00
fc558278cc
Fix touch input handler settings not matching search for "touchscreen"
2023-01-24 13:37:12 +09:00
bc717b1f25
Merge pull request #22381 from Susko3/fix-osu-touch-with-screen-scaling
...
Fix touches not being handled outside `OsuTouchInputMapper` when using screen scaling
2023-01-24 11:07:11 +09:00
949610c8a4
Add commentary as to why ReceivePositionalInputAt override is required
2023-01-24 11:06:54 +09:00
2454eb8cd9
TestSceneWikiMarkdownContainer: Add visual test for inline and fenced code syntax
2023-01-24 00:53:45 +00:00
f067a84631
TestSceneWikiMarkdowContainer: Update image paths
2023-01-24 00:51:07 +00:00
e6de167adb
Revert split and make collections boolean internal to BeatmapManager
2023-01-24 07:27:26 +09:00
a992682276
Fix OsuTouchInputMapper not handling all touches when using screen scaling
2023-01-23 21:46:01 +01:00
7483967157
Merge branch 'master' into SliderEnd-Snap
2023-01-23 21:33:16 +01:00
1f40b2daf6
Clean up xmldocs
2023-01-23 21:22:18 +01:00
9f2ed853eb
Merge pull request #22371 from peppy/more-settings-keywords
...
Add more keywords to settings based on feedback
2023-01-23 20:19:53 +01:00
d695214ae1
Merge pull request #22277 from stanriders/level-badge-colour
...
Add tiered level badge colouring
2023-01-23 16:21:28 +09:00
432e0a6a37
Merge branch 'master' into level-badge-colour
2023-01-23 15:46:15 +09:00
736965e009
Fix test scene potentially overflowing visible region
2023-01-23 15:45:44 +09:00
9c2494383f
Rename fetch method to be non-plural to match all others
2023-01-23 15:43:52 +09:00
e3932c077b
Merge pull request #22032 from frenzibyte/fix-potential-difficulty-failure-alt
...
Fix advanced statistics display potentially performing invalid difficulty calculation
2023-01-23 15:39:47 +09:00
7ebd31d42f
Add more keywords to settings based on feedback
2023-01-23 15:14:16 +09:00
2ed9fe3747
Add support for externally specified keywords in SettingsButtons
2023-01-23 15:10:26 +09:00
73f083a316
Refactor how additional points are provided to avoid confusion
2023-01-23 14:13:46 +09:00
f87bb589a2
Merge pull request #22340 from EXtremeExploit/groups-modes
...
Add modes text to groups tooltip
2023-01-23 01:10:25 +09:00
9a89dfb7d1
Merge pull request #22339 from shinobu-uwu/fix-fail-sample-playing-after-leaving-dialog
...
Fix skin fail sound continuing to play after leaving gameplay
2023-01-22 22:27:26 +09:00
e1acf85bb3
Merge branch 'master' into groups-modes
2023-01-22 10:09:34 +01:00
9bde1ef9bf
Privatise setter
2023-01-22 10:09:08 +01:00
b98da506c1
Fix code quality inspection
2023-01-22 10:07:47 +01:00
31e7d7333b
Merge branch 'master' into fix-fail-sample-playing-after-leaving-dialog
2023-01-22 09:35:37 +01:00
06aa3f7798
Rename Stop{SampleAndRemoveFilters -> }()
...
Now that just one method for stopping samples is left, let's just
repurpose st as the general "stop global effects" method rather than
have it there with a hyperspecific name. It also has good symmetry, as
there already was a `Start()` method in the class.
2023-01-22 09:29:22 +01:00
9e4e85e3e3
Inline StopSample() into StopSampleAndRemoveFilters()
...
The first method no longer has any callers except for the second one.
2023-01-22 09:26:01 +01:00
