Commit Graph

37602 Commits

Author SHA1 Message Date
8d4ff867bf Fix barlines showing up in the osu!mania editor's timeline 2021-03-25 16:30:31 +09:00
41cf261286 Merge pull request #12177 from peppy/fix-comment-parsing-regression
Don't strip comments from metadata during parsing
2021-03-25 15:02:10 +09:00
e0b12abcc1 Merge pull request #12173 from frenzibyte/osk-ignore-case 2021-03-25 14:58:09 +09:00
cfc65d5226 Merge pull request #12152 from peppy/solo-score-submission
Add solo score submission flow
2021-03-25 14:24:43 +09:00
0324bfa857 Change checks back to Contains 2021-03-25 14:14:38 +09:00
4269cb7124 Extract majority of token retrieval code out of LoadComponentAsync for legibility 2021-03-25 13:48:41 +09:00
ff139c2056 Merge branch 'master' into solo-score-submission 2021-03-25 13:46:29 +09:00
4f8edcd336 Don't strip comments from metadata during parsin 2021-03-25 13:35:54 +09:00
e22650293d Remove unnecessary second call to StripComments in skin parsing logic 2021-03-25 13:35:42 +09:00
6e103fca99 Merge pull request #12176 from peppy/issue-template-improvements
Include blurb in issue template to hopefully help people find existing reports
2021-03-25 13:05:15 +09:00
f8f461a7a4 Include blurb in issue template to hopefully help people find existing reports 2021-03-25 12:33:07 +09:00
8753d45b71 Remove duplicate crash report issue template 2021-03-25 12:32:51 +09:00
35810bb2fb Add test coverage 2021-03-24 22:55:15 +03:00
fc5719e445 Fix SkinManager not handling extensions casing comparsion properly 2021-03-24 21:31:53 +03:00
6a37fb41cc Merge pull request #12161 from MiraiSubject/tournament-disable-rawinput 2021-03-24 14:54:43 +09:00
93921af82d Merge pull request #12163 from owen-young/default-fullscreen 2021-03-24 14:54:03 +09:00
5ad8dc316f Add inline comment and improve linq robustness 2021-03-24 14:09:15 +09:00
f95175983a Make code more concise and move method to a more appropriate place 2021-03-24 13:37:37 +09:00
d55324585d Change RoomSubmittingPlayer's request implementation to return null on RoomID missing, rather than silently succeeding 2021-03-24 13:23:23 +09:00
84b2f9a848 Make token private 2021-03-24 13:20:44 +09:00
a0c6c4da35 Rename and refactor token request process to be easier to understand 2021-03-24 13:17:29 +09:00
e372e355ef Reorder overrides in SoloPlayer to better follow chronological request order 2021-03-24 13:12:51 +09:00
8bed7748d6 Rename token request method to avoid double Request terminology 2021-03-24 13:02:37 +09:00
a1c35677ef Add more xmldoc 2021-03-24 13:02:17 +09:00
c8542d2434 Merge branch 'master' into default-fullscreen 2021-03-23 19:44:22 -05:00
437dadc85f Changed comment on GetFrameworkConfigDefaults() to be more accurate 2021-03-23 19:37:55 -05:00
67a03ebc23 Fixed formatting issues to be in line with osu coding standards 2021-03-23 19:31:16 -05:00
fbb992fc7e Added a comment to new method 2021-03-23 19:18:32 -05:00
d17c431faf Disable relative mode for TournamentGame 2021-03-23 23:22:17 +01:00
217f6083ca Merge branch 'master' into solo-score-submission 2021-03-23 21:12:52 +09:00
bb6e50eb27 Merge pull request #12151 from peppy/fail-dummy-api-requests
Fail all API requests sent to DummyAPIAccess
2021-03-23 20:54:04 +09:00
578128f803 Merge branch 'master' into fail-dummy-api-requests 2021-03-23 20:14:56 +09:00
ade542191a Merge pull request #12154 from peppy/fix-hitcircle-glow-fade-out
Fix default skin's glow resetting fade on miss
2021-03-23 20:14:51 +09:00
5f956971cc Merge pull request #12153 from peppy/fix-appproach-circle-fade-out
Always fade out approach circles at a HitObject's start time to better match stable
2021-03-23 20:04:38 +09:00
d10ff615fe Fix default skin's glow resetting fade on miss 2021-03-23 19:28:08 +09:00
64e85ba995 Always fade out approach circles at a HitObject's start time to better match stable 2021-03-23 19:19:07 +09:00
e649a330a4 Implement SoloPlayer's request construction 2021-03-23 18:23:25 +09:00
242b847516 Add flow for allowing gameplay to continue even when an error occurs with token retrieval 2021-03-23 18:23:25 +09:00
3cd8bf2d7f Move token request construction to LoadAsyncComplete to better allow DI usage 2021-03-23 18:20:55 +09:00
571124669d Remove all references to "score submission" from Player 2021-03-23 18:20:55 +09:00
194b2d05d3 Update SoloPlayer to derive SubmittingPlayer 2021-03-23 18:20:55 +09:00
12f050264a Further split out a player class which submits to "rooms" 2021-03-23 18:20:55 +09:00
7045fce555 Move score submission logic in general out to its own Player type 2021-03-23 18:20:55 +09:00
6cb14e91c9 Make Player abstract and introduce SoloPlayer 2021-03-23 18:18:49 +09:00
5267fb74c4 Add submission requests 2021-03-23 18:18:49 +09:00
aeff9bd853 Add return bool to HandleRequest to better trigger failures 2021-03-23 18:17:29 +09:00
ce452565f4 Avoid firing any kind of failures after success 2021-03-23 17:50:31 +09:00
9e38d580ca Merge pull request #12139 from peppy/fix-editor-spinner-looping-too-long
Fix spinners playing looping sound too long in the editor
2021-03-23 17:44:07 +09:00
f5ba746ae5 Fail all API requests sent to DummyAPIAccess
Until now, API requests sent to dummy API were just lost in the void. In most cases this somehow worked as expected, but any logic which is waiting on a request to finish will potentially never get a response.

Going forward, I'm not 100% sure that every `Wait` on a web response will have local timeout logic (I think there is a certain amount of assumption that this is being managed for us by `APIAccess`), so I've made this change to better handle such cases going forward. Now, rather than nothing happening, requests will trigger a failure via the existing exception logic rather than silently pretending the request never arrived.
2021-03-23 17:37:45 +09:00
3594c42b79 Merge pull request #12141 from smoogipoo/perfect-curve-failure-testcase 2021-03-23 17:23:00 +09:00