Commit Graph

34540 Commits

Author SHA1 Message Date
330af7ec74 Handle osu:// scheme links via IPC in desktop game 2022-06-20 21:26:22 +02:00
92011124d1 Implement IPC channel for osu:// scheme links 2022-06-20 20:08:36 +02:00
34f1c80b7c Add and use ILinkHandler interface 2022-06-20 20:04:21 +02:00
43ead5820a deal with test 2022-06-21 00:54:50 +09:00
5a5cc523ce Let F to -1 temporary 2022-06-20 23:43:33 +08:00
577a87bcad Merge branch 'master' into importer-post-import-rename 2022-06-20 13:37:16 +02:00
ba394f2831 Remove IPostsImports interface (and move to IModelImporter) 2022-06-20 18:53:48 +09:00
e732c5a2d7 Add PostImport method matching PreImport 2022-06-20 18:40:23 +09:00
45c5013f09 Remove default value of RealmArchiveModelImporter.HandledExtensions
Not used anywhere and probably not wanted ever.
2022-06-20 18:40:23 +09:00
dbae4c6f5a PostImport -> PresentImport 2022-06-20 18:36:29 +09:00
ebcee21f6f Remove necessity to provide BeatmapDifficultyCache as a function to ScoreManager 2022-06-20 17:52:42 +09:00
c402e90598 Merge pull request #18777 from peppy/output-directory-on-import-failure
Silence exception and provide more log output when import fails due to empty `.osu` files
2022-06-20 17:36:21 +09:00
e0c82d11ab Convert == usages to ReferenceEquals 2022-06-20 16:56:19 +09:00
16281f4a48 Properly annotate method to allow null 2022-06-20 16:56:19 +09:00
ca287d0936 Fix group deselected when table is recreated 2022-06-20 16:56:19 +09:00
d38defada4 Silence exception and provide more log output when import fails due to empty .osu files 2022-06-20 16:07:10 +09:00
4aa32038c3 Add note about stream provided to ImportTask being disposed implicitly 2022-06-20 15:38:44 +09:00
882e1c69e5 Move nested task back outside try-catch to avoid double-error 2022-06-20 15:36:44 +09:00
678b18dde6 Ensure any non-MemoryStream streams are closed as part of ImportTask 2022-06-20 15:29:56 +09:00
a922ea9b01 Fix selection by directly comparing control points
Previously, all control points would get replaced, which led to
performance issues that was worked around in this PR. By comparing
control points, we're able to get good performance without requiring the
workaround.
2022-06-20 15:29:29 +09:00
03ab6fc141 Implement IEquatable on ControlPoint 2022-06-20 15:27:43 +09:00
dd93c7359e Update xmldoc for importFromArchive method 2022-06-20 15:25:43 +09:00
92f1a2958c Rename Import(TModel) to ImportModel to differentiate from other import methods 2022-06-20 15:18:07 +09:00
a6c8a832aa Remove Import(ArchiveReader) and redirect existing usages to Import(ImportTask) 2022-06-20 15:14:57 +09:00
7daab2d45b Merge branch 'master' into skin-editor-transform-fix 2022-06-20 14:10:01 +09:00
329f1a0822 Add test coverage of original fail case and improve test reliability and code quality 2022-06-20 14:08:05 +09:00
468e5fcbed Merge branch 'master' into editor-controlpoint-undo-redo 2022-06-20 13:47:01 +09:00
a5bc769243 clear skineditor selected components on hide 2022-06-19 14:34:52 -04:00
36df1da57f Revert "stop component transform when skineditor is hidden"
This reverts commit 48ffd6aeb5.
2022-06-19 14:26:02 -04:00
3ab8158b92 Do not try to set ruleset from beatmap if it's a dummy 2022-06-19 20:08:39 +02:00
93b3ede2a0 Always use beatmap ruleset in editor gameplay test mode
Fixes cases where opening a convertible beatmap (so any osu! beatmap)
with the game-global ruleset being set to anything but osu! would result
in opening the editor gameplay test mode with the game-global ruleset
rather than the beatmap's.
2022-06-19 19:30:40 +02:00
9a6f4ef76d Save score button on failed screen 2022-06-19 23:59:37 +09:00
9023fdc947 Merge branch 'master' into reidrect-graceful-exit 2022-06-19 13:43:15 +02:00
495d747da5 Fix mismatching braces in comment 2022-06-19 13:42:45 +02:00
98d69c846c Reset spectator speed at last frame 2022-06-19 17:12:20 +09:00
6515b249ec Change data migration to do an immediate exit, rather than attempted exit 2022-06-19 12:39:58 +09:00
50e40756c4 Rename GracefullyExit to AttemptExit 2022-06-19 12:34:44 +09:00
a2e17941e5 Merge branch 'master' into timing-offset-adjust-seek-only-at-start 2022-06-19 01:27:44 +03:00
2a95715652 Merge branch 'master' into fix-input-regression 2022-06-18 19:44:53 +02:00
f7fc456bb1 Merge branch 'master' into reidrect-graceful-exit 2022-06-18 19:37:53 +03:00
3902dc64f0 Fix adjusting offset via button seeking to timing point's offset unexpectedly
This was added with the intention of tracking the offset when already at
the start (the most common case when you're using the tap timing
wizard), but was also seeking when the user may be much further beyond
or before it.

Addresses https://github.com/ppy/osu/discussions/18741#discussioncomment-2975051.
2022-06-19 01:35:45 +09:00
b2663d9399 Update xmldoc to suggest that GracefullyExit may be overridden 2022-06-19 01:14:48 +09:00
3fa8c19acd Merge branch 'master' into latency-certifier/hidden-cursor 2022-06-19 00:31:11 +09:00
a5e5172b91 Fix BlueprintContainer eating input from skin editor buttons 2022-06-18 18:28:36 +03:00
56abe54fe6 Redirect graceful exiting to standard exit flow
Rather than doing a completely forced exit as we were, this will now
follow a more standard flow with the ability for the user to abort along
the way. This is more in line with how I wanted this to work.

Note that this means a confirmation is now shown. It has been discussed
in the past that this confirmation should only show when there's an
ongoing action implies the user may want to cancel the exit. For now I
think this is fine.

Addresses
https://github.com/ppy/osu/discussions/18399#discussioncomment-2811311
2022-06-18 23:43:46 +09:00
5917c70127 Merge branch 'master' into multi-song-select-operation 2022-06-18 11:58:13 +02:00
f6a3047596 Merge branch 'master' into editor-metadata-name-unification 2022-06-18 10:22:52 +02:00
77e7e4ecb2 Fix selection being blocked after early return 2022-06-18 14:28:30 +09:00
bd5037fcad Fix new hitobject placements not taking on the existing sample settings
Similar to velocity / difficulty points, a user expectation is that
volume and sample settings will be transferred to newly placed objects
from the most recent one.

Closes https://github.com/ppy/osu/issues/18742.
2022-06-18 13:49:59 +09:00
8ad96fd94b Update resources 2022-06-18 10:55:24 +09:00