Commit Graph

42595 Commits

Author SHA1 Message Date
a960a28d06 Replace "end glow" terminology with "hyper-dash after-image"
Because the is "end glow" is when a hyper-dash is *started*, the name was confusing.
The "after-image" was already used in the code as a synonym of "end glow" inconsistently.
2021-07-28 19:11:22 +09:00
2b107d624a Merge pull request #14024 from ekrctb/trail-generation
Move catcher trail generation logic to `CatcherArea` to remove mutual dependency of `Catcher` and `CatcherTrailDisplay`
2021-07-28 19:06:44 +09:00
0bf04ece34 Avoid internal property by using ChildrenOfType 2021-07-28 18:13:43 +09:00
846f539428 Avoid usage of LINQ in last dash trail computation 2021-07-27 19:11:08 +09:00
da69867fd4 Move catcher trail generation logic to CatcherArea 2021-07-27 19:07:37 +09:00
de68fd12b3 Move catcher trail colouring logic to CatcherTrailDisplay 2021-07-27 19:07:37 +09:00
d9d9db6f62 Revert "Modify catcher autoplay test pattern to see more variety movement"
I found `TestSceneHyperDash` is useful for visual inspection of hyper dash trails.
This reverts commit 0fbe950a
2021-07-27 19:07:37 +09:00
6f35036f53 Merge pull request #14027 from gagahpangeran/comment-markdown
Add support for markdown in comments
2021-07-27 14:38:59 +09:00
7ae1b5bae7 Merge pull request #14022 from peppy/fix-invalid-ruleset-causing-crash
Fix invalid/unavailable ruleset causing game-wide crash
2021-07-27 02:39:26 +09:00
dc864abbd8 add link test 2021-07-26 21:08:57 +07:00
6631f0de19 add CommentMarkdownHeading 2021-07-26 21:07:35 +07:00
f80c46e2a0 add heading test 2021-07-26 21:04:08 +07:00
2a6aeb5310 use CommentMarkdownContainer in DrawableContainer 2021-07-26 18:18:55 +07:00
43100c5288 initial CommentMarkdownContainer 2021-07-26 18:18:33 +07:00
55e8a44db6 add test for DrawableComment
Can reproduce the issue at https://github.com/ppy/osu/issues/13993
2021-07-26 18:15:59 +07:00
8837340ac3 Merge pull request #14025 from ekrctb/simplify-can-catch
Remove outdated comment and simplify code in `Catcher.CanCatch`
2021-07-26 19:27:33 +09:00
8045534fa5 Remove outdated comment and simplify code 2021-07-26 18:18:24 +09:00
3a81d5e8ce Merge pull request #14023 from peppy/add-high-precision-macos-note
Add warning about using high precision mouse on non-windows platforms
2021-07-26 18:07:38 +09:00
0fbe950a3c Modify catcher autoplay test pattern to see more variety movement 2021-07-26 18:06:30 +09:00
4282442278 Make Catcher.body private as it is no longer needed by CatcherTrailDisplay 2021-07-26 17:58:34 +09:00
c08130398c Add some comments 2021-07-26 17:58:34 +09:00
bb046fa3b8 Move catcher trail generation logic to Catcher
It resolves mutual dependency of `Catcher` and `CatcherTrailDisplay`.
Trail generation logic is moved to `Catcher`.
The generation logic no longer uses delayed scheduling because the hidden state is hard to manage.
Instead, the last time a trail is generated is calculated and used.
The new logic has a different behavior when the dash key is pressed in succession under 50ms, but it is not noticeable for normal plays.
2021-07-26 17:51:59 +09:00
5984699842 Update comment to match updated string
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2021-07-26 17:40:07 +09:00
c8944b62ec Update incorrect linked comment 2021-07-26 17:28:58 +09:00
075507648a Show warning for linux as well 2021-07-26 17:28:58 +09:00
b70bd7689e Add warning about using high precision mouse on macOS 2021-07-26 17:00:06 +09:00
af9f910a12 Change WarningText to accept LocalisableString
Can't work just yet, but best to have the flow in place to maintain 100%
localisation on classes which were already localised.
2021-07-26 16:59:29 +09:00
046f30a268 Reject invalid global ruleset values 2021-07-26 16:34:38 +09:00
04c8ea2813 Add failing test for the global ruleset being set to an invalid value 2021-07-26 16:33:56 +09:00
9ae3c685db Merge pull request #14020 from peppy/multiplayer-test-request-clarification
Rename class, add commenting and avoid firing requests to create rooms for testing purposes
2021-07-26 16:29:02 +09:00
888954747c Rename class, add commenting and avoid firing requests to create rooms for testing purposes 2021-07-26 15:47:13 +09:00
488dd3ea52 Merge pull request #13980 from peppy/fix-online-song-select-background
Fix song select background not showing in multiplayer/playlists
2021-07-26 15:16:39 +09:00
5e2222cc05 Merge pull request #14018 from peppy/fix-keyboard-navigation-room-container
Fix keyboard navigation at multiplayer lounge not iterating in correct order
2021-07-26 14:55:40 +09:00
32e29d0428 Ensure lounge is loaded before continuing with tests 2021-07-26 14:29:16 +09:00
3770193ede Fix keyboard navigation at multiplayer lounge not iterating in correct order 2021-07-26 13:49:09 +09:00
971a67c669 Add failing test coverage for misordered rooms 2021-07-26 13:46:55 +09:00
9713875ce4 Merge pull request #14017 from frenzibyte/room-eating-drag
Fix rooms in online-play longue screen no longer scrollable by dragging
2021-07-26 11:58:31 +09:00
749d7a7b24 Fix DrawableRoom swallowing mouse down events before reaching its container 2021-07-26 04:41:47 +03:00
5141bf66eb Add failing test case 2021-07-26 04:41:47 +03:00
17eed2f427 Merge pull request #14009 from peppy/update-packages
Update `LocalisationAnalyser` and other packages
2021-07-25 12:33:18 +02:00
f015b2b63c Merge branch 'master' into update-packages 2021-07-25 11:49:11 +02:00
ed0e729ea4 Merge pull request #14010 from peppy/fix-direct-search-ecaping
Fix beatmap search requests double-escaping
2021-07-25 11:38:11 +02:00
bb3747ffc9 Fix beatmap search requests double-escaping
Closes #14008.
2021-07-25 17:06:40 +09:00
37cb67d9e0 Also update dotnet-tools file 2021-07-25 15:24:50 +09:00
afaf44d522 Update LocalisationAnalyser and other packages 2021-07-25 15:07:41 +09:00
dbdaddfbcc Merge pull request #14004 from Joehuu/fix-beatmap-info-mod-overflow
Fix mod selector overflowing from beatmap info overlay
2021-07-25 12:21:29 +09:00
ce30bd8cc7 Merge pull request #14003 from Game4all/localise-profile-overlay-header-stats
Localise profile overlay numeric statistics
2021-07-25 12:20:38 +09:00
f6d4ead32a Fix mod selector overflowing from beatmap info overlay 2021-07-24 15:31:01 -07:00
b0b46eed40 Apply review suggestions.
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-07-24 21:32:26 +02:00
fa68caa892 Fix CI inspections. 2021-07-24 19:34:12 +02:00