Commit Graph

37551 Commits

Author SHA1 Message Date
ade542191a Merge pull request #12154 from peppy/fix-hitcircle-glow-fade-out
Fix default skin's glow resetting fade on miss
2021-03-23 20:14:51 +09:00
5f956971cc Merge pull request #12153 from peppy/fix-appproach-circle-fade-out
Always fade out approach circles at a HitObject's start time to better match stable
2021-03-23 20:04:38 +09:00
d10ff615fe Fix default skin's glow resetting fade on miss 2021-03-23 19:28:08 +09:00
64e85ba995 Always fade out approach circles at a HitObject's start time to better match stable 2021-03-23 19:19:07 +09:00
9e38d580ca Merge pull request #12139 from peppy/fix-editor-spinner-looping-too-long
Fix spinners playing looping sound too long in the editor
2021-03-23 17:44:07 +09:00
3594c42b79 Merge pull request #12141 from smoogipoo/perfect-curve-failure-testcase 2021-03-23 17:23:00 +09:00
3ec3624ac5 Merge branch 'master' into fix-editor-spinner-looping-too-long 2021-03-23 16:45:41 +09:00
f6ed3c1b1e Merge branch 'master' into perfect-curve-failure-testcase 2021-03-23 16:44:58 +09:00
17a28f4f65 Merge pull request #12136 from peppy/remove-skin-sample-workarounds
Remove local workarounds to attempt to avoid crashes on skin change
2021-03-23 16:44:29 +09:00
08fcdc8ee4 Update difficulty calculator tests with floating point differences 2021-03-23 15:38:01 +09:00
d758343a45 Merge pull request #12149 from peppy/fix-score-token-data-type
Fix APIScoreToken's data type not matching server side
2021-03-23 14:54:02 +09:00
1171214541 Update framework 2021-03-23 14:51:22 +09:00
a5842a5485 Merge branch 'master' into remove-skin-sample-workarounds 2021-03-23 14:51:14 +09:00
5f2c6b8d59 Merge pull request #12145 from bdach/mania-auto-hold-note-release
Remove release delay for hold notes when generating autoplay
2021-03-23 14:24:56 +09:00
9c690f9545 Fix second usage 2021-03-23 14:08:00 +09:00
58c60100b4 Fix APIScoreToken's data type not matching server side 2021-03-23 14:04:47 +09:00
c89199b38b Merge pull request #12148 from Joehuu/fix-deleted-comments-trash-icon
Fix incorrect trash icon being used on deleted comments counter
2021-03-23 11:53:14 +09:00
16b3f22caf Fix incorrect trash icon being used on deleted comments counter 2021-03-22 19:32:17 -07:00
098005393e Remove unnecessary null checks and debug code 2021-03-23 10:38:37 +09:00
d612964ac8 Merge pull request #12144 from bdach/remove-osutk-run-config
Remove osuTK desktop rider run config
2021-03-23 10:19:47 +09:00
29d4162e4e Remove release delay for hold notes when generating autoplay
It was more intended for normal notes anyway (as they would be released
pretty much instantaneously, if it weren't for the delay).
2021-03-22 22:45:21 +01:00
d85929d721 Adjust autoplay generation tests to match expected behaviour 2021-03-22 22:45:21 +01:00
a65e491768 Remove osuTK desktop rider run config
No longer operational since 6eadae8.
2021-03-22 20:00:36 +01:00
779d2ed5d9 Merge pull request #12138 from smoogipoo/mania-legacy-key-fade-delay 2021-03-22 19:09:00 +01:00
e60ff45b73 Add another test for colinear perfect curves 2021-03-22 16:57:40 +09:00
5b1d9f4cf0 Fix constant case 2021-03-22 16:19:29 +09:00
690fb9224a Combine constants for readability 2021-03-22 16:18:31 +09:00
c4d08463ad Fix spinners playing looping sound too long in the editor
The `OnComplete` event was never being run due to the transform playing
out longer than the spinner's lifetime. I've matched the durations, but
also moved the `Stop()` call to what I deem a safer place to run it (I
did notice that without this it would still potentially never fire).

Note that this is more noticeable in the editor because of lifetime
extension. In gameplay, the returning of a spinner to the pool will
clean things up (but in the editor that can take longer, depending on
timeline zoom level).

Another thing worth mentioning is that the fade doesn't actually work.
This is due to https://github.com/ppy/osu-framework/pull/4212.

Closes #12119.
2021-03-22 16:04:51 +09:00
db64fac824 Delay key fade in legacy mania skins 2021-03-22 15:26:22 +09:00
7034289763 Merge pull request #12133 from bdach/hold-note-freezing-regression 2021-03-22 14:11:53 +09:00
073dba5330 Remove local workarounds to attempt to avoid crashes on skin change 2021-03-22 14:05:37 +09:00
09bc7267c0 Merge pull request #12134 from Joehuu/add-comments-count 2021-03-21 20:24:16 +01:00
9bc6cdf042 Fix singular format regression on forum post text 2021-03-21 11:19:07 -07:00
e31d583a7f Add comments count to user profile overlay 2021-03-21 11:16:59 -07:00
9a330c4c56 Fix mania hold note heads hiding when frozen
This was an insidious regression from a3dc1d5. Prior to that commit,
`DrawableHoldNoteHead` had `UpdateStateTransforms()` overridden, to set
the hold note head's lifetime. When that method was split into
`UpdateInitialStateTransforms()` and `UpdateHitStateTransforms()`, the
lifetime set was moved to the former.

Unfortunately, that override served two purposes: both to set the
lifetime, and to suppress hit animations which would normally be added
by the base `DrawableManiaHitObject`. That fact being missed led to
`UpdateHitStateTransforms()` hiding the hold note head immediately on
hit and with a slight delay on miss.

To resolve, explicitly override `UpdateHitStateTransforms()` and
suppress the base call, with an explanatory comment.
2021-03-21 18:46:41 +01:00
c4f3714385 Make hold note input tests fail due to head hiding 2021-03-21 18:39:57 +01:00
ee7370b21a Merge pull request #12125 from bdach/rollback-ef
Revert EF Core to version 2.2
2021-03-21 23:30:43 +09:00
a16c0641b2 Revert EF Core to version 2.2
This reverts commit f3faad74d5, reversing
changes made to 712e7bc7bf.

Several issues arose after migrating to 5.0, including, but possibly not
limited to, performance regressions in song select, as well as failures
when attempting to save beatmaps after metadata changes in the editor.
2021-03-21 11:05:15 +01:00
0bb6fbdd38 Merge pull request #12100 from bdach/invalid-thread-mutation-tablet
Fix transform mutations from invalid thread on tablet disconnection/reconnection
2021-03-20 21:30:12 +09:00
86b569f5f7 Fix typo in identifier 2021-03-20 12:37:51 +01:00
d28bed6ed2 Schedule adding transforms on tablet changes
Fixes `InvalidThreadForMutationException`s that pop up when
disconnecting/reconnecting tablets during the game's operation. In those
cases the value change callback executes from  an OpenTabletDriver
thread.
2021-03-20 12:37:48 +01:00
b9b351311a Merge pull request #11824 from peppy/fix-unsafe-skinnable-sample-play
Fix playing skinned samples being unsafe during skin changes
2021-03-20 11:29:34 +09:00
ca943a897a Fix back to front initialisation order 2021-03-20 10:51:58 +09:00
e630c1be50 Merge pull request #12090 from bdach/overlapping-object-selection
Fix selection blueprint misbehaving with overlapping objects
2021-03-20 10:46:29 +09:00
dd48b68f8a Ensure selected blueprints are given selection priority 2021-03-19 22:44:33 +01:00
8e0536e1e2 Add failing test scene 2021-03-19 22:44:33 +01:00
e67c759eef Mark control point visualiser as possibly-null 2021-03-19 22:44:31 +01:00
9634560d4b Fix control point visualiser crashing after deselections
`SliderSelectionBlueprint.OnDeselected()` would expire the
`ControlPointVisualiser` on deselection, leading to its removal from the
blueprint and eventual disposal, but still kept a separate reference to
said visualiser in another field.

This could lead to that stale reference to a disposed child getting read
in `ReceivePositionalInputAt()`, crashing quite a ways down over at the
framework side on futilely trying to compute the bounding box of a
drawable with no parent.
2021-03-19 21:40:22 +01:00
d54e9ab481 Merge pull request #12077 from peppy/tablet-configuration
Add tablet configuration section
2021-03-19 21:49:32 +09:00
5a6ff53837 Merge pull request #12073 from peppy/fix-crash-toggle-overlay-before-loaded
Avoid potential crash if an overlay is toggled before it has been loaded
2021-03-19 21:38:47 +09:00