Commit Graph

48758 Commits

Author SHA1 Message Date
b2efce2656 Merge branch 'master' into expandable-controls 2022-02-03 19:23:34 +09:00
dbf2a1149c Merge pull request #16675 from nekodex/songselect-random-sfx
Add audio feedback to song select 'random'
2022-02-03 19:20:07 +09:00
6d6327d3da Fix test beatmap loading potentially performing selection before carousel itself is loaded 2022-02-03 18:40:16 +09:00
e65996efc3 Rename variable to match purpose better 2022-02-03 17:14:38 +09:00
137a9a0305 Merge branch 'master' into songselect-random-sfx 2022-02-03 17:14:28 +09:00
46d180eeb5 Merge pull request #16760 from peppy/force-relayout-on-score-mode-change
Trigger a re-layout of HUD components when scoring mode is changed
2022-02-03 17:06:38 +09:00
d3e6eac02e Merge pull request #16762 from peppy/fix-carousel-ruleset-filter-test-local-database
Fix `TestSelectingFilteredRuleset` failing under visual tests due to using local database
2022-02-03 16:59:45 +09:00
41aa4b8cca Fix TestSelectingFilteredRuleset failing under visual tests due to using local database 2022-02-03 16:04:05 +09:00
cd806711f8 Merge pull request #16761 from peppy/more-dialog-overlay-wait
Wait for `DialogOverlay` load in more tests
2022-02-03 16:01:32 +09:00
6355ac6663 Wait for DialogOverlay load in more tests
Apparently the previous fix was not enough as this can still be seen
failing
(https://github.com/ppy/osu/runs/5046718623?check_suite_focus=true).

This change is copying from what other tests use seemingly reliably,
such as `TestScenePerformFromScreen`)
2022-02-03 15:10:08 +09:00
c8ce00b26a Trigger a re-layout of HUD components when scoring mode is changed
This is a simple way of fixing the layout of scoring elements
overlapping due to different score display width requirements of
different scoring modes. It will only resolve the case where a user
hasn't customsied the layout of the default skins, but as this is a very
simple / low effort implementation for the most common scenario, I think
it makes sense.

Closes https://github.com/ppy/osu/issues/16067.
2022-02-03 14:50:41 +09:00
867586f7f5 Merge pull request #16758 from smoogipoo/fix-incomplete-requests-offline
Fix API requests not completing when offline
2022-02-03 14:34:24 +09:00
a69c7a9de6 Split exceptions back out to give better messaging 2022-02-03 14:09:27 +09:00
62fa915193 Standardise exception messages for local-user-logged-out flows 2022-02-03 13:58:55 +09:00
d9a43b4c4c Fix API requests not completing when offline 2022-02-03 13:16:54 +09:00
2731d8e3c2 Merge pull request #16701 from LeNitrous/mod-alternate-osu
Add "Alternate" mod for osu! ruleset
2022-02-03 10:41:23 +09:00
be9df2ca11 Merge pull request #5774 from MaxOhn/aimassist-mod
Add "Aim Assist" mod
2022-02-03 10:40:43 +09:00
9bca597a8a Merge pull request #16751 from bdach/flashlight-decimals-display 2022-02-03 10:34:09 +09:00
82f9ad63f5 Fix flashlight size multiplier printing with too many decimal digits 2022-02-02 20:41:25 +01:00
fb353d5d45 Merge branch 'master' into aimassist-mod 2022-02-02 19:37:34 +01:00
7463744407 Fix osu! autoplay-like mods not declaring incompatibility with AimAssist 2022-02-02 19:17:33 +01:00
3a5099cf06 Merge pull request #16748 from frenzibyte/explicit-diffadjust-keyboard-step
Use `0.1` keyboard step for "Difficulty Adjust" sliders
2022-02-03 00:22:23 +09:00
074a691635 Set keyboard step to 0.1 for difficulty adjust sliders 2022-02-02 17:43:08 +03:00
f777347aaf Merge pull request #16742 from smoogipoo/fix-multi-swap-mod-crash
Fix crash when selecting non-osu! ruleset mods as freemod
2022-02-02 19:14:10 +09:00
b5fb3b7dae Fix crash when selecting swap mod as freemod 2022-02-02 18:42:22 +09:00
db0f3b7f5e Merge pull request #16738 from peppy/fix-ruleset-incorrectly-loading
Fix rulesets potentially being marked `Available` even when methods are missing
2022-02-02 18:03:04 +09:00
4f3e55a0ce Merge branch 'master' into songselect-random-sfx 2022-02-02 17:18:24 +09:00
6260c5fc13 Merge pull request #16739 from nekodex/cursor-tap
Add cursor 'tap' audio feedback
2022-02-02 17:02:33 +09:00
cb31ce812c Merge branch 'master' into cursor-tap 2022-02-02 16:34:34 +09:00
4758de226b Update resources 2022-02-02 16:27:59 +09:00
6e41a6e704 Tidy up code into a presentable state 2022-02-02 16:27:16 +09:00
2e46404fe5 Remove spinner support for now 2022-02-02 16:26:00 +09:00
987aa5a21c Add testing of different strengths 2022-02-02 16:26:00 +09:00
f07502ac5f Use simple damp easing rather than transforms 2022-02-02 16:15:06 +09:00
334ed2c9c4 Fix sliders moving before they are actually hit 2022-02-02 15:36:09 +09:00
6b31e7e9db Merge branch 'master' into aimassist-mod 2022-02-02 15:18:48 +09:00
104256a054 Add test coverage 2022-02-02 15:18:44 +09:00
e7d72f1823 Revert recent changes 2022-02-02 15:18:44 +09:00
0c5da9370a Fix rulesets potentially being marked Available even when methods are missing
Came up when running the game after the recent breaking changes
(https://github.com/ppy/osu/pull/16722), where two template rulesets I
had loaded were erroring on startup but still being marked as available,
allowing them to crash the game on attempting to initiate relpay logic.

These cases are already handled for first-time ruleset loading via the
`GetTypes()` enumeration in `RulesetStore.addRuleset`, but when
consistency checking already present rulesets the only runtime
validation being done was `ruleset.CreateInstance()`, which does not
handle missing types or methods.
2022-02-02 14:52:01 +09:00
6e60e68b80 Change from click to mousedown+mouseup and only play when cursor is visible 2022-02-02 14:44:06 +09:00
a2affefb0a Avoid checking gameplay clock time in Update method 2022-02-02 14:33:17 +09:00
c7a192cc5f Only handle LeftButton and RightButton actions
There are definitely going to be other actions used in the future, which
would immediately cause this mod to fail. Limiting handling to
left/right buttons only is the correct way forward.
2022-02-02 14:04:12 +09:00
fed63abd83 Sanitise interceptor logic to now require two separate check paths 2022-02-02 14:02:48 +09:00
0036d0e26d Move alternate mod to "conversion" category 2022-02-02 13:58:13 +09:00
6d962e7925 Merge pull request #16726 from dekrain/leaderboard-score-tooltip
Add basic tooltip for leaderboard scores
2022-02-02 13:56:45 +09:00
4b646709c1 Merge pull request #16658 from Spooghetti420/no-long-notes-mod
Add "Hold Off" mod (no long notes)
2022-02-02 13:35:44 +09:00
ddc8094a75 Update description 2022-02-02 13:34:23 +09:00
d065e32ca1 Fix crash due to MatchLeaderboardScores not having populated rulesets 2022-02-02 13:23:49 +09:00
35b7653290 Revert mod flow changes and add visual test coverage showing an overflow case 2022-02-02 09:13:19 +09:00
6033c89e7b Merge pull request #16734 from bdach/war-on-unused-params
Fix several cases of unused constructor and method parameters
2022-02-02 07:40:58 +09:00