b37cb3bdbe
Change interpreted difficulty from bindable to regular value
...
There's no reason for why checks would need this to be bindable. A 1-directional binding is more appropriate.
2021-05-13 09:00:30 +02:00
4eeeaf6a1a
Keep track of local bound copy
2021-05-13 07:57:32 +02:00
e7c7786db3
Merge branch 'master' into beatmap-verifier-context
2021-05-13 07:40:33 +02:00
5b71d8ca37
Merge pull request #12758 from Naxesss/verify-settings-ui
...
Add setting UI components to the verify screen
2021-05-13 14:35:35 +09:00
b81f86bd4d
Move DI resolution to inside BDL parameters
2021-05-13 13:54:06 +09:00
c6648112e5
Simplify binding flow in InterpretationSection
2021-05-13 13:51:41 +09:00
cdcbaf4291
Tidy up specification of SettingsSection
2021-05-13 13:45:10 +09:00
47948d7b34
Set default for bindable in object initializer
...
Fixes the CI failure.
2021-05-13 06:08:48 +02:00
fb305130de
Also refresh when interpreted difficulty changes
2021-05-13 06:00:21 +02:00
ee0a6ba93e
Use local bound copy in InterpretationSection as well
...
Else we're relying on the `VerifyScreen`'s bindable instance, and by extension the `VerifyScreen` instance itself.
2021-05-13 05:59:49 +02:00
e80d8f6922
Keep track of local bound copy
2021-05-13 05:46:47 +02:00
04c1585eb2
Use more consistent lambda discards
2021-05-13 05:38:45 +02:00
e86834b740
Use local bound copy for HiddenIssueTypes
2021-05-13 05:25:20 +02:00
c8d21f2c3f
Isolate refreshing to IssueList
2021-05-13 05:25:02 +02:00
fbb76ba598
Split ShowIssueTypes dict into hidden and configurable lists
...
This way `VerifyScreen` is decoupled from which options `VisibilitySection` provides.
Bindings are a bit less neat, though.
2021-05-13 04:50:32 +02:00
dd8423c4c4
Set interpreted difficulty to correct default
2021-05-13 04:36:20 +02:00
6806e40ad9
Remove unnecessary local variable
...
This now exists in `VerifyScreen`, which we can access from here.
2021-05-13 04:30:40 +02:00
56bd897666
Move ShowIssueTypes to VerifyScreen
2021-05-13 04:29:27 +02:00
27ca7d0f4f
Actually annotate the correct ctor
2021-05-12 23:53:39 +02:00
a6aec6e007
Fix missed InstantiationInfo setter usages
2021-05-12 23:34:25 +02:00
d31fa20e92
Merge branch 'master' into skin-instantiation-info
2021-05-12 23:23:57 +02:00
1b579dd838
Extract invariant instantiation info extension method
2021-05-12 23:23:51 +02:00
4464204e33
Mark all skin ctors used via reflection in SkinInfo.CreateInstance()
2021-05-12 23:23:42 +02:00
4e7c079560
Merge pull request #12753 from peppy/health-bar-hud-overlay-dependency
...
Remove downwards dependency from `HUDOverlay` to `HealthDisplay`
2021-05-12 19:27:02 +09:00
c6f0a6aed3
Merge pull request #12538 from smoogipoo/multiplayer-spectator-screen
...
Implement the multiplayer spectator screen
2021-05-12 17:24:35 +09:00
d2e0e8ad94
Reverse direction of binding to allow for better abstract class definitions
2021-05-12 16:53:58 +09:00
17e3764576
Rename Settings to have a more localised name
2021-05-12 16:38:04 +09:00
e1dacde314
Add combo to test streaming client
2021-05-12 14:22:15 +09:00
f4c96b2675
Only update playing user states when users are watched
2021-05-12 13:10:59 +09:00
e0e8f5ab80
Fix ordering + threading issues
2021-05-12 13:06:28 +09:00
ad11818868
Remove watched users on stop watching
2021-05-12 13:05:02 +09:00
184dbaf202
Improve safety of bindings in HealthDisplay
2021-05-12 12:53:30 +09:00
9b09361cc9
Add testable spectator streaming client
2021-05-12 12:16:41 +09:00
b7bc42e0d3
Rename "playableBeatmap" check arg to "beatmap"
...
The working beatmap is now in the context, so it's easier to distinguish beatmap type, hence no need for this prefix.
2021-05-12 02:34:16 +02:00
64d96b06a6
Add interpreted difficulty info to BeatmapVerifierContext
...
Enables checks to make use of the difficulty level as shown in the settings UI.
2021-05-12 02:30:21 +02:00
c13b93e6f1
Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks
...
This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.
See next commit for example.
2021-05-12 02:29:18 +02:00
4aeaec6ecc
Add InterpretationSection and its bindable in IssueList
...
We'll eventually connect that bindable so that checks can access it.
2021-05-12 01:32:18 +02:00
75adec57eb
Remove negligible default hidden TODO
2021-05-12 01:31:16 +02:00
ad78aec1ef
Refresh IssueList on changes in VisibilitySection
2021-05-12 01:30:45 +02:00
1bb7d412da
Add IssueList filtering based on those bindables
2021-05-12 01:29:46 +02:00
2e4399f0c1
Add VisibilitySection and its bindables in IssueList
2021-05-12 01:27:21 +02:00
01b8794757
Add abstract Section class
...
Similar to `Section` in the timing screen, but does not make use of checkboxes, nor specific to control points.
So there's a lot of things that differ, hence new class instead of factoring that out.
2021-05-12 01:26:12 +02:00
1de35f880b
Separate IssueList into own class
2021-05-12 01:23:31 +02:00
d3c1ec55ee
Take IssueList in IssueSettings constructor
...
We'll be using this for bindables later.
2021-05-12 01:22:32 +02:00
97bd482d4d
Factor out load from settings into new Settings class
2021-05-12 01:21:38 +02:00
77e422409c
Add SkinInfo.InstantiationInfo to allow creating different skin types
2021-05-11 23:37:06 +09:00
8e226319e2
Remove downwards dependency from HUDOverlay to HealthDisplay
2021-05-11 23:18:23 +09:00
048677846b
Change HealthDisplay to be a CompositeDrawable
2021-05-11 23:10:30 +09:00
9ad1e5067e
Fix spectate being entered while not having the beatmap
2021-05-11 19:22:09 +09:00
811282a975
Add failing test
2021-05-11 19:01:41 +09:00
