Commit Graph

48743 Commits

Author SHA1 Message Date
bef0a2da21 Remove return type from AddDifficultyToBeatmapSet
Also removes a pointless realm encapsulation.
2022-02-03 19:43:43 +09:00
ad47649d1c Make BeatmapModelManager.Save non-virtual 2022-02-03 19:38:53 +09:00
b94fe84712 Merge branch 'master' into new-difficulty-creation-v3 2022-02-03 10:48:20 +09:00
2731d8e3c2 Merge pull request #16701 from LeNitrous/mod-alternate-osu
Add "Alternate" mod for osu! ruleset
2022-02-03 10:41:23 +09:00
be9df2ca11 Merge pull request #5774 from MaxOhn/aimassist-mod
Add "Aim Assist" mod
2022-02-03 10:40:43 +09:00
9bca597a8a Merge pull request #16751 from bdach/flashlight-decimals-display 2022-02-03 10:34:09 +09:00
a8ffc4fc2a Add editor override to respect IsolateSavingFromDatabase 2022-02-02 21:57:21 +01:00
47429fb0c6 Fix same-name safety firing wrongly 2022-02-02 21:57:21 +01:00
afc48d86df Add failing test coverage for save after safeties addition 2022-02-02 21:57:10 +01:00
4f1aac9345 Add safeties preventing creating multiple difficulties with same name 2022-02-02 21:57:09 +01:00
87e2e83288 Add test coverage for difficulty name clash cases 2022-02-02 21:55:34 +01:00
54bb6ad40c Fix working beatmaps not seeing new difficulties after add 2022-02-02 21:55:34 +01:00
0d51c015ad Add basic test coverage for new difficulty creation 2022-02-02 21:55:34 +01:00
dc96c4888b Add support for creating new blank difficulties 2022-02-02 21:55:33 +01:00
b613aedeb8 Fix menu item width changing when hovered 2022-02-02 21:23:35 +01:00
3386f038ba Add new difficulty creation menu 2022-02-02 21:23:35 +01:00
e2fcdc394b Extract method for difficulty switch menu creation 2022-02-02 21:23:35 +01:00
82f9ad63f5 Fix flashlight size multiplier printing with too many decimal digits 2022-02-02 20:41:25 +01:00
fb353d5d45 Merge branch 'master' into aimassist-mod 2022-02-02 19:37:34 +01:00
7463744407 Fix osu! autoplay-like mods not declaring incompatibility with AimAssist 2022-02-02 19:17:33 +01:00
3a5099cf06 Merge pull request #16748 from frenzibyte/explicit-diffadjust-keyboard-step
Use `0.1` keyboard step for "Difficulty Adjust" sliders
2022-02-03 00:22:23 +09:00
074a691635 Set keyboard step to 0.1 for difficulty adjust sliders 2022-02-02 17:43:08 +03:00
f777347aaf Merge pull request #16742 from smoogipoo/fix-multi-swap-mod-crash
Fix crash when selecting non-osu! ruleset mods as freemod
2022-02-02 19:14:10 +09:00
b5fb3b7dae Fix crash when selecting swap mod as freemod 2022-02-02 18:42:22 +09:00
db0f3b7f5e Merge pull request #16738 from peppy/fix-ruleset-incorrectly-loading
Fix rulesets potentially being marked `Available` even when methods are missing
2022-02-02 18:03:04 +09:00
6260c5fc13 Merge pull request #16739 from nekodex/cursor-tap
Add cursor 'tap' audio feedback
2022-02-02 17:02:33 +09:00
cb31ce812c Merge branch 'master' into cursor-tap 2022-02-02 16:34:34 +09:00
4758de226b Update resources 2022-02-02 16:27:59 +09:00
6e41a6e704 Tidy up code into a presentable state 2022-02-02 16:27:16 +09:00
2e46404fe5 Remove spinner support for now 2022-02-02 16:26:00 +09:00
987aa5a21c Add testing of different strengths 2022-02-02 16:26:00 +09:00
f07502ac5f Use simple damp easing rather than transforms 2022-02-02 16:15:06 +09:00
334ed2c9c4 Fix sliders moving before they are actually hit 2022-02-02 15:36:09 +09:00
6b31e7e9db Merge branch 'master' into aimassist-mod 2022-02-02 15:18:48 +09:00
104256a054 Add test coverage 2022-02-02 15:18:44 +09:00
e7d72f1823 Revert recent changes 2022-02-02 15:18:44 +09:00
0c5da9370a Fix rulesets potentially being marked Available even when methods are missing
Came up when running the game after the recent breaking changes
(https://github.com/ppy/osu/pull/16722), where two template rulesets I
had loaded were erroring on startup but still being marked as available,
allowing them to crash the game on attempting to initiate relpay logic.

These cases are already handled for first-time ruleset loading via the
`GetTypes()` enumeration in `RulesetStore.addRuleset`, but when
consistency checking already present rulesets the only runtime
validation being done was `ruleset.CreateInstance()`, which does not
handle missing types or methods.
2022-02-02 14:52:01 +09:00
6e60e68b80 Change from click to mousedown+mouseup and only play when cursor is visible 2022-02-02 14:44:06 +09:00
a2affefb0a Avoid checking gameplay clock time in Update method 2022-02-02 14:33:17 +09:00
c7a192cc5f Only handle LeftButton and RightButton actions
There are definitely going to be other actions used in the future, which
would immediately cause this mod to fail. Limiting handling to
left/right buttons only is the correct way forward.
2022-02-02 14:04:12 +09:00
fed63abd83 Sanitise interceptor logic to now require two separate check paths 2022-02-02 14:02:48 +09:00
0036d0e26d Move alternate mod to "conversion" category 2022-02-02 13:58:13 +09:00
6d962e7925 Merge pull request #16726 from dekrain/leaderboard-score-tooltip
Add basic tooltip for leaderboard scores
2022-02-02 13:56:45 +09:00
4b646709c1 Merge pull request #16658 from Spooghetti420/no-long-notes-mod
Add "Hold Off" mod (no long notes)
2022-02-02 13:35:44 +09:00
ddc8094a75 Update description 2022-02-02 13:34:23 +09:00
d065e32ca1 Fix crash due to MatchLeaderboardScores not having populated rulesets 2022-02-02 13:23:49 +09:00
35b7653290 Revert mod flow changes and add visual test coverage showing an overflow case 2022-02-02 09:13:19 +09:00
6033c89e7b Merge pull request #16734 from bdach/war-on-unused-params
Fix several cases of unused constructor and method parameters
2022-02-02 07:40:58 +09:00
3674ed15ce Remove unused game host parameter
No longer used since eeccf836ec.
2022-02-01 21:53:21 +01:00
b978010b48 Remove unused allowMissing parameter in audio file check test
No longer used since 7f95400f46.
2022-02-01 21:53:21 +01:00