Commit Graph

57134 Commits

Author SHA1 Message Date
c805eb330a Merge branch 'master' into mania-argon-hold-better 2022-11-21 18:17:35 +01:00
d5e9cb2477 Merge pull request #21352 from peppy/avoid-null-audio-device-name-crahs
Avoid crashing when a system audio device provides a `null` name
2022-11-21 17:16:30 +01:00
206aece77b Merge branch 'master' into avoid-null-audio-device-name-crahs 2022-11-21 16:37:13 +01:00
7944d9cefa Merge pull request #21304 from EVAST9919/beatmap-bar
Rework BarGraph to use Quads
2022-11-21 16:24:18 +01:00
b404b87f68 Realign white line on argon hold note ends to match hit target 2022-11-21 18:26:53 +09:00
2774c1ea49 Merge pull request #21215 from jai-x/triangles-bundled-beatmap
Add winner of Triangles mapping competition as a bundled beatmap
2022-11-21 16:22:23 +09:00
981264b011 Avoid crashing when a system audio device provides a null name 2022-11-21 14:51:41 +09:00
4a79141824 Merge pull request #21338 from RATCM/fix-leaderboard-filter
Match leaderboard filter behaviour to web
2022-11-21 14:01:55 +09:00
dfa92b3de9 Merge pull request #21326 from bdach/fix-phantom-beatmap-sets
Fix phantom beatmap sets appearing on carousel after delete/update
2022-11-21 13:25:14 +09:00
92aea22cd3 Merge pull request #21340 from vegguid/MetadataLanguage-FirstSetup
Added PreferOriginalMetadataLanguage to FirstRunSetup
2022-11-21 12:16:56 +09:00
85167d8de6 Merge pull request #21343 from goodtrailer/nonsquare-smoke
Add support for nonsquare smoke textures
2022-11-21 12:06:49 +09:00
815cd56f13 Add support for nonsquare smoke textures 2022-11-20 16:50:15 -08:00
a431b793b9 Added PreferOriginalMetadataLanguage to FirstRunSetup 2022-11-20 23:18:19 +01:00
18c79dfda3 Move all the logic into BarsInfo class 2022-11-20 23:00:13 +03:00
f5fbb7c8de Changed comments 2022-11-20 19:27:40 +01:00
d20a357c0e Fixed ordering bug 2022-11-20 19:24:51 +01:00
9040dfbd4e Match leaderboard filter behaviour to web 2022-11-20 17:39:46 +01:00
1269afd0c5 Merge pull request #21307 from frenzibyte/disable-scroll-speed-on-osu
Hide scroll speed control from effects section on rulesets which don't support it
2022-11-20 16:17:55 +01:00
0f382590e6 Remove unnecessary #nullable disable 2022-11-20 15:31:51 +01:00
793d5b117e Fix timing screen test scene not creating editor beatmap properly 2022-11-20 15:20:35 +03:00
7b274083d3 Fix phantom beatmap sets appearing on carousel after delete/update
Regressed in c40c70509e.

As it turns out, `item.Item.Filtered.Value` is not the only condition
that should be checked to determine if a carousel item should be hidden
or not - `item.Item.State.Value != CarouselItemState.Collapsed` should
also be true. This was even available as the `item.Item.Visible`
convenience property, which is used in this commit.

Failing to check `item.Item.State.Value` led to setting non-zero alpha
on collapsed carousel items, leading to phantom beatmap sets appearing,
as the alpha was set in the entire carousel's `Update()` method, thus
firing every frame.
2022-11-20 10:08:34 +01:00
b3667821eb Add failing test case 2022-11-20 10:07:32 +01:00
36141cb2a4 Make BarsInfo a class 2022-11-20 05:14:07 +03:00
4b0ba86bd0 Identify scrolling rulesets using temporary DrawableRuleset instances 2022-11-20 04:12:52 +03:00
58296bd4f0 Introduce IDrawableScrollingRuleset for editor consumption 2022-11-20 04:11:10 +03:00
fcb52ee237 Make BarsInfo a readonly struct 2022-11-20 02:28:07 +03:00
fbfcf49ea6 Remove readonly modifier from struct fields 2022-11-20 02:13:54 +03:00
2cb966b47c Rework BarsInfo struct 2022-11-20 01:48:54 +03:00
6c62cfb830 Store barBreadth as a separate float 2022-11-19 23:40:02 +03:00
67ee9f3915 Naming adjustments 2022-11-19 23:34:55 +03:00
f1201454b7 Use value tuples 2022-11-19 23:29:50 +03:00
6f449a583e Handle empty values as a separate case 2022-11-19 23:27:48 +03:00
9724c6bb53 Merge pull request #21205 from Samaoo/fix-tablet-aspect-ratio-values
Fix incorrect rounding of tablet aspect ratio values
2022-11-19 15:08:53 +01:00
0c671a2a82 Merge branch 'master' into fix-tablet-aspect-ratio-values 2022-11-19 14:32:24 +01:00
8bde669de1 Merge pull request #21266 from peppy/editor-test-play-dont-retain-test-time
When returning to the editor after test play, use the original editor time rather than the point of exit
2022-11-19 12:41:25 +01:00
c05c1625f2 Merge branch 'master' into editor-test-play-dont-retain-test-time 2022-11-19 12:09:04 +01:00
60c424837b Merge branch 'master' into disable-scroll-speed-on-osu 2022-11-19 12:13:45 +03:00
2e3af97892 Remove unused using 2022-11-19 12:13:36 +03:00
0239103b6b Fix BeatmapOverlay crashing test scene 2022-11-19 11:33:14 +03:00
05992d3aa8 CI fix 2022-11-19 10:23:37 +03:00
9b8f98735c Use struct for bars description 2022-11-19 10:16:58 +03:00
7d02cbafed Merge branch 'master' into beatmap-bar 2022-11-19 09:58:10 +03:00
11f5fddc1f Remove redundant returns 2022-11-19 09:57:52 +03:00
130f776427 Merge pull request #21267 from peppy/catch-file-enumeration-errors
Catch and gracefully handle file/directory enumeration failures during stable import
2022-11-19 15:38:40 +09:00
866b8b640a Merge pull request #21310 from frenzibyte/fix-present-beatmap-test
Fix intermittent present beatmap test failures
2022-11-19 15:38:07 +09:00
5fda702267 Merge pull request #21306 from frenzibyte/fix-editor-seeking-state
Fix editor not always playing hitsounds with clock offsets applied
2022-11-19 15:08:53 +09:00
ca67689a36 Fix intermittent present beatmap test failures 2022-11-19 07:44:43 +03:00
290369db47 Hide scroll speed slider on rulesets which don't support it 2022-11-19 06:42:27 +03:00
016de2f5a0 Fix editor not always playing hitsounds with clock offsets applied 2022-11-19 05:15:22 +03:00
4648e7bee0 Merge pull request #21299 from frenzibyte/perform-from-runner-load-state
Fix "perform from screen" invoking action on non-loaded screens
2022-11-19 09:55:21 +09:00