Commit Graph

26720 Commits

Author SHA1 Message Date
1beb85a26f Bump localisation analyser packages 2021-07-06 14:56:52 +09:00
0658cfb986 Throw exceptions rather than silently failing if attempting to add a clock for a non-tracked user 2021-07-06 14:56:00 +09:00
402b527903 Add .editorconfig for localisation analyser 2021-07-06 14:54:56 +09:00
1a6b8b2c73 Populate UserScores as early as possible to avoid weird ordering requirements 2021-07-06 14:53:31 +09:00
0ecda98b39 Update prefixes to match new resx locations 2021-07-06 14:28:52 +09:00
7f2baef998 Remove all .resx files from osu project 2021-07-06 14:24:17 +09:00
686dd2b5ce Remove unused constant 2021-07-05 20:35:14 +02:00
d495196b66 Share item cycling logic with GameplayMenuOverlay 2021-07-05 19:22:55 +02:00
f5ddd2a53b Fix critical failure causing scores to not update on the leaderboard 2021-07-06 01:15:30 +09:00
e1c646b9b2 Remove redundant arguments 2021-07-05 23:52:39 +08:00
3fe875efb2 Add glow to focused meter 2021-07-05 16:38:52 +02:00
f1014af284 Move LoadComplete content to run after user retrieval has completed
Feels safer, I think.
2021-07-05 21:35:41 +09:00
459f9a0465 Handle nulls and fix missing documentation 2021-07-05 21:35:37 +09:00
77adf687c6 Consume ability to lookup multiple users in MultiplayerGameplayLeaderboard
Avoids syncrhonously blocking on asynchronous operations (which was
leading to LCA starvation in tests).
2021-07-05 19:56:37 +09:00
9c311a6d8a Add ability to lookup multiple users at once to UserLookupCache 2021-07-05 19:56:16 +09:00
28faa8c330 Merge pull request #13780 from peppy/disable-foreign-keys
Disable foreign key enforcing at an sqlite level
2021-07-05 19:08:10 +09:00
229bba14e6 Fix master clock becoming incorrectly paused when all spectator players are too far ahead 2021-07-05 17:45:08 +09:00
1e4beddd2d Disable foreign key enforcing at an sqlite level 2021-07-05 15:41:48 +09:00
8f82ceefe8 Merge pull request #13774 from LumpBloom7/fix-incorrect-first-window
Fix nested HitWindows not being considered if parent HitWindow is empty
2021-07-05 13:54:00 +09:00
6b76c54aee Merge pull request #13756 from PercyDan54/playlist-empty-romanised
Fix playlist item displays empty string if no unicode title is present
2021-07-05 13:53:50 +09:00
b82afaddc1 Merge pull request #13767 from peppy/fix-realm-refresh-race
Fix thread safety of realm `Refresh` operation
2021-07-05 13:53:29 +09:00
d119d9a0db Merge branch 'master' into adjust-rankings-overlay 2021-07-05 11:59:26 +09:00
f510ef9153 Move previousContext assign within lock to make things look safer
Not an actual requirement, but no harm.
2021-07-05 10:49:56 +09:00
b6542a835b Merge pull request #13757 from peppy/fix-import-optimisation
Fix incorrect `base` call causing import optimisation to not work
2021-07-05 10:26:52 +09:00
5f10edee39 Merge branch 'master' into playlist-empty-romanised 2021-07-05 10:20:33 +09:00
216e52d6d0 Avoid using single letter variable names 2021-07-04 23:24:17 +02:00
32b068fbdc Fix typo causing nested windows to be ignored 2021-07-04 21:50:58 +02:00
0527f669cb Merge branch 'master' into volume-meter-switch 2021-07-04 17:48:26 +02:00
69803105ef Fix volume meter requesting focus for any action 2021-07-04 17:19:44 +02:00
5e148b273e Merge branch 'master' into fix-initial-volume-display-when-zero 2021-07-04 16:16:01 +02:00
14a861003a Fix code quality errors 2021-07-04 16:06:28 +02:00
50c9e17e52 Return focus when using UP/DOWN on unfocused meter 2021-07-04 15:42:26 +02:00
d0707079b1 Remove unused method 2021-07-04 15:35:51 +02:00
e151c7ffd0 Let VolumeMeter request focus instead of taking it 2021-07-04 15:35:04 +02:00
c143a50b73 Merge branch 'master' into fix-zero-hit-score-submit 2021-07-04 15:31:38 +02:00
d1553f0864 Implement ability to switch between volume meters 2021-07-04 14:47:07 +02:00
3291f15dcc Mention GetForWrite() as another alternative to Context accesses 2021-07-04 12:08:15 +02:00
b89521314f Mention alternatives to Context when not on update thread in xmldoc 2021-07-04 12:07:34 +02:00
3ec7dc3bb9 Update tests in line with thread safety check 2021-07-04 17:59:39 +09:00
7a710ceffe Check count as well (statistics can be populated with zero counts) 2021-07-04 16:41:09 +09:00
567e9f33a9 Fix thread safety of realm Refresh operation
Due to the lack of locking, there was a chance the the update thread
`context` was retrieved just before the `flushContexts` call, followed
by `.Refresh()` being run while the blocking behaviour was invoked.

This can be seen in test failures such as
https://ci.appveyor.com/project/peppy/osu/builds/39859786/tests.

As an aside, I tried multiple different methods to avoid `lock()` on the
update thread but they felt flaky. The overhead of lock when there's no
contention is reportedly around 30-50ns, so likely not of concern. We
can address it at a later point if it becomes one.
2021-07-04 16:24:43 +09:00
ef82528309 Don't attempt to submit score when nothing has been hit 2021-07-04 15:16:18 +09:00
149a200f34 Fix volume metre not correctly showing volume when initially zero
Closes https://github.com/ppy/osu/issues/13761.
2021-07-04 14:56:17 +09:00
ec71deec51 Remove some mentions of "lazer"
I am aware there are more throughout the codebase but intentionally left
the remaining mentioned for one reason or another. The intention here is
to mainly change user-facing versioning to change the positioning of the
"lazer" term (to be where we would expect "cuttingedge" or "beta" to
be).
2021-07-04 12:41:27 +09:00
12371f7424 Fix playlist item displays as empty string if no unicode title is present 2021-07-04 08:09:38 +08:00
8a23dfa6f5 Fix optimised import path buffering events without flush 2021-07-03 17:58:12 +02:00
fbe3b447e5 Merge branch 'master' into linkify-metadata 2021-07-03 15:51:08 +02:00
6fb8ed4d07 Trim no longer used constant 2021-07-03 15:47:47 +02:00
0be75cc4ed Fix incorrect base call causing import optimisation to not work 2021-07-03 22:35:46 +09:00
7dae93ad66 Remove unused using directives 2021-07-03 15:23:26 +02:00