Commit Graph

3896 Commits

Author SHA1 Message Date
58bae9bda3 Merge pull request #16331 from stanriders/continuous-effective-misscount
Don't floor `effectiveMissCount`
2022-01-19 14:13:12 +09:00
03e4ec4214 Merge branch 'master' into realm-integration/score-and-beatmaps 2022-01-15 14:45:42 +01:00
3ab13dd78c Assign position to spinner ticks for correct positional playback 2022-01-15 14:24:52 +03:00
19467e58c1 Remove unused params from BDL methods 2022-01-15 01:06:39 +01:00
4f8d29c1c0 Merge branch 'master' into realm-integration/score-and-beatmaps 2022-01-13 18:25:09 +09:00
b245ffefc1 Merge remote-tracking branch 'upstream/master' into fix-remaining-identifier-names 2022-01-12 15:05:07 -08:00
51251e3204 Fix CI reported warnings 2022-01-12 22:39:00 +09:00
d8c52740cb Merge pull request #16354 from bdach/slider-snapping
Apply slider snapping to current beat divisor more liberally to match user expectations
2022-01-12 11:18:18 +09:00
b88a65166e Fix pp counter underflow with SpunOut mod 2022-01-11 10:22:16 +09:00
c09f6ee052 Use slider snapping more liberally to match user expectations
Previously the slider path length would be snapped using the current
beat snap setting on *every* change of the slider path. As it turns out
this is unexpected behaviour in some situations (e.g. when reversing a
path, which is expected to preserve the previous duration, even though
the slider may be technically "unsnapped" at that point in time due to a
different beat snap setting being selected afterwards).
2022-01-07 16:02:04 +01:00
ee24713002 Fix single sliders not being flippable due to incorrect precondition 2022-01-06 14:37:13 +09:00
dc755f4a7f Remove redundant casts 2022-01-05 15:07:02 +03:00
b317a95fe1 Don't floor effectiveMissCount 2022-01-05 14:36:07 +03:00
6779503e57 Refactor logic to avoid TimelineSelectionHandler having to block base calls 2022-01-05 16:56:54 +09:00
866ae3472b Add global flip hotkeys 2022-01-05 16:48:07 +09:00
408e8d5710 Fix null reference causing crash in KiaiFlashingDrawable
Can occur if there is no fallback graphics available. Previously would
work as it was only setting the `Texture`.

As reported in https://github.com/ppy/osu/discussions/16281.
2021-12-30 22:21:39 +09:00
c22a07d9fc Bump identifier typo inspection and fix remaining identifier names 2021-12-28 11:26:42 -08:00
eea0fea69f Add support for animated legacy hit circle overlay 2021-12-28 15:58:34 +01:00
448c6ed515 Generalise KiaiFlashingSprite for arbitrary drawables 2021-12-28 15:58:34 +01:00
63e0492725 Mark ShouldSerialize() methods as implicitly used 2021-12-28 09:02:03 +01:00
7de43e3aba Fix most open compound words in identifiers being closed 2021-12-27 20:26:28 -08:00
c6a5ac1c5f Fix control point additions without a drag not being undoable 2021-12-23 09:32:52 +01:00
cbda637d66 Fix drag after placement moving last placed point sometimes
More specifically, if the left mouse button was just pressed without a
drag, `OnDragEnd()` wouldn't fire, and the next drag would start moving
the last placed control point around regardless of where the mouse was.
2021-12-23 09:25:10 +01:00
b0df787b1a Move public method up and add xmldoc to second public method 2021-12-23 14:13:57 +09:00
60c9827187 Merge branch 'master' into move-many-slider-nodes-at-once 2021-12-23 14:11:04 +09:00
c3fada1926 Replace assertion with soft null check
Surrounding `OnDrag{Start,End}` methods did so already.
2021-12-22 10:33:08 +01:00
6330fa5dc5 Select newly created control point 2021-12-22 10:33:07 +01:00
e22745397d Fix right click deselecting clicked path piece with control held 2021-12-22 08:55:26 +01:00
98f044881e Merge branch 'master' into refactor-diffcalc 2021-12-22 12:31:28 +09:00
e50609c546 Rename method 2021-12-22 12:28:07 +09:00
e715bff535 Fix selections including head not correctly dragging if not started from head 2021-12-21 12:35:48 +01:00
40b3ce0ade Clean up comments 2021-12-21 14:03:24 +03:00
cca02a8016 Create PerformanceAttributes 2021-12-21 13:08:31 +03:00
05b79f864e Merge pull request #15867 from MBmasher/fl-cumulative-strain
Fix cumulative strain time calculation in Flashlight skill
2021-12-21 17:19:09 +09:00
f366cdc73e Extract initial set out of loop 2021-12-21 12:39:34 +09:00
c21b2d1662 Fix incorrect variable 2021-12-21 12:39:09 +09:00
e21dbf10ff Refactor further to remove indexing confusion 2021-12-21 12:25:32 +09:00
377cb1d9e3 Merge pull request #15728 from MBmasher/fl-decay
Remove decay factor in Flashlight skill
2021-12-21 07:59:32 +09:00
5ef4e23335 Fix selecting control points without control not deselecting other selected points 2021-12-20 22:41:24 +01:00
bf8c87e9b7 Fix releasing mouse after drag deselecting dragged point 2021-12-20 22:41:23 +01:00
d2417beeac Implement drag operation for multiple path control points 2021-12-20 21:29:57 +01:00
a9408485cc Change control point piece selection logic to allow dragging multiple 2021-12-20 21:18:38 +01:00
b0ca82e1e5 Move slider path point drag handling to visualiser 2021-12-20 20:56:06 +01:00
c71655a75e Merge branch 'master' into fl-cumulative-strain 2021-12-21 06:06:19 +11:00
6caa950c44 Rename osuPrevious to osuLoop 2021-12-20 19:16:41 +11:00
2f2006715e Slightly refactor difficulty and pp calculators 2021-12-17 23:40:23 +03:00
abb617a3df Avoid blocking Active state propagation 2021-12-16 19:57:24 +09:00
6bffeb6a24 Merge branch 'master' into fix-autopilot-touch-devices 2021-12-15 12:04:35 +09:00
e662a9f0c4 Remove redundant code. 2021-12-15 12:36:45 +13:00
4664bb1d29 Remove uneeded complexity 2021-12-15 05:16:10 +13:00