cff57d7ee9
Merge pull request #22686 from MaxKruse/fix-automatic-seeking
...
Add toggle to disable automatic seeking to object after placement
2023-02-19 23:38:23 +09:00
d9ca7102f0
Use more generic wording for future-proofing
2023-02-19 15:06:40 +01:00
8b25598d82
Rename moved test method to describe its purpose better
2023-02-19 13:54:48 +01:00
80ee917c77
Rewrite test cases
...
- Depend less on arbitrary timings
- Remove unnecessary seeks
- Change method name to make more sense
- Use nunit style assertions
2023-02-19 13:37:06 +01:00
80b329f069
Rename test scene to match contents
...
It does not only test "placement before track start" anymore.
2023-02-19 13:16:40 +01:00
aac32a2c9f
Combine config and time checks into one
...
Functionally equivalent right now, but the combined variant is more
localised to what it actually needs to do, and less error-prone if
any new code gets appended to the method.
2023-02-19 13:14:51 +01:00
723a043c43
naming change from Hitobject to HitObject
2023-02-19 10:18:22 +01:00
f3522c4162
change bindable seekToHitObject to private
2023-02-19 10:18:02 +01:00
025061ba66
fix formating in SeekOnNote test
2023-02-19 10:17:33 +01:00
55e9a71f38
Add test for seeking setting in mania placement test
2023-02-18 20:42:13 +01:00
ddd37bb319
Add setting to disable automatic seeking after object placement
2023-02-18 19:43:45 +01:00
79e1dbfb6d
Merge pull request #22671 from peppy/blueprint-labels-while-hovering
...
Only show skin blueprint labels when selected or hovering
2023-02-18 16:29:37 +01:00
ea04c487f2
Merge branch 'master' into blueprint-labels-while-hovering
2023-02-18 15:57:30 +01:00
ff5de04fb1
Merge pull request #22675 from cdwcgt/CompletionText-LocalisableString
...
Make `CompletionText` in `ProgressNotification` a `LocalisableString`
2023-02-18 14:25:21 +01:00
15d209d17e
Merge branch 'master' into CompletionText-LocalisableString
2023-02-18 13:50:58 +01:00
6b1c8195bc
Merge pull request #22672 from peppy/skin-editor-improve-toolbox-hover
...
Improve the feel of hovering components in the skin editor toolbox
2023-02-18 10:34:28 +01:00
fbea3e312f
Merge branch 'master' into skin-editor-improve-toolbox-hover
2023-02-18 10:02:02 +01:00
2aa4481f68
Fix toolbox items spontaneously contracting after briefly losing hover
...
Reproduction scenario:
1. Hover a toolbox item
2. Unhover the item, but do not hover any other item (can be done by
exiting the toolbox completely to the right)
3. Come back to the item hovered in step (1)
4. The item would spontaneously contract after a second
2023-02-17 22:54:11 +01:00
23a636b74b
Merge pull request #22648 from peppy/skinnable-clean-up-documentation
...
Refactor structure and naming of skin-related classes
2023-02-17 21:37:54 +01:00
6afa65bd3d
Merge branch 'master' into skinnable-clean-up-documentation
2023-02-17 20:59:18 +01:00
449e5fa6f8
Rename one more left-over skinnable naming
2023-02-17 22:09:55 +03:00
dbb366e279
CompletionText can be a LocalisableString
...
I can't find a reason for not doing this, probably this was forgotten in https://github.com/ppy/osu/pull/15440
2023-02-17 22:32:03 +09:00
5ed038fbb3
Improve the feel of hovering toolbox component items
2023-02-17 19:26:03 +09:00
814080d982
Only show blueprint labels when hovering or selected
2023-02-17 19:23:52 +09:00
1a63ca9ece
Add xmldoc around SkinComponentsContainerLookup
2023-02-17 14:18:05 +09:00
9f9893d93a
Merge pull request #22338 from Pasi4K5/hide-resume-overlay
...
Hide `ResumeOverlay` when `OsuModAutopilot` is enabled
2023-02-16 22:22:19 +01:00
66e9bb2581
Merge branch 'master' into hide-resume-overlay
2023-02-16 21:33:23 +01:00
bba1722725
Merge pull request #22645 from peppy/adjust-song-select-background-dim
...
Adjust song select background dimming to be more evenly applied
2023-02-16 21:27:27 +01:00
b8084a15eb
Revert ResumeOverlay setter accessibility change
2023-02-16 21:26:01 +01:00
0186062246
Merge branch 'master' into adjust-song-select-background-dim
2023-02-16 20:52:36 +01:00
ad5132ed41
Remove redundant conditional access qualifier
...
It is impossible for the callback passed to `ApplyToBackground()` to
receive a null reference. See `OsuScreen.ApplyToBackground()` - if the
background to call the callback on were `null`, then an
`InvalidOperationException` would be thrown instead.
2023-02-16 20:47:51 +01:00
7d86f49fce
Merge pull request #22658 from peppy/gameplay-sample-trigger-source-test-fix
...
Refactor `GameplaySampleTriggerSource` test to not be realtime dependent
2023-02-16 19:39:18 +01:00
5bdc5dfadd
Add one more assert to keep coverage from previous implementation
2023-02-16 19:02:51 +01:00
cb7df7282b
Apply NRT to SerialisedDrawableInfo
2023-02-16 20:01:59 +09:00
394d368f16
Fix song select potentially updating background parameters when not the current screen
2023-02-16 18:45:22 +09:00
979c079f8b
Refactor GameplaySampleTriggerSource test to not be realtime dependent
2023-02-16 17:58:44 +09:00
9d02a2ef0e
Apply NRT to GamepleSampleTriggerSource tests
2023-02-16 17:58:44 +09:00
ce9ef3bc3c
Always create ResumeOverlay, with UseResumeOverlay flag only affecting whether it is displayed or not
2023-02-16 15:47:20 +09:00
7afdcb9383
Merge branch 'master' into hide-resume-overlay
2023-02-16 15:42:14 +09:00
81dcc105a9
Rename left-over skinnable naming in SerialisedDrawableExtensions
2023-02-16 15:34:41 +09:00
76f7accd13
Standardise all local SkinComponentsContainerLookup variables to containerLookup
2023-02-16 15:33:56 +09:00
eea0cd3cf8
Reword xmldoc on ISerialisableDrawable to make less skin-centric
2023-02-16 15:31:35 +09:00
0b25f7baeb
Reword and fix typos in some new xmldoc
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2023-02-16 15:27:30 +09:00
87901bc8b1
Merge pull request #22292 from ekrctb/maximum-judgement-offset-in-hit-object
...
Move MaximumJudgementOffset to HitObject
2023-02-16 00:52:35 +01:00
c315113fde
Merge branch 'master' into maximum-judgement-offset-in-hit-object
2023-02-16 00:15:51 +01:00
768eea1ea8
Merge branch 'master' into skinnable-clean-up-documentation
2023-02-15 21:26:11 +01:00
1d5d34ba0e
Merge pull request #22647 from peppy/remove-target-component-container
...
Simplify and rename `SkinnableTargetComponentsContainer`
2023-02-15 21:25:49 +01:00
455fb7789c
Merge pull request #22646 from peppy/fix-skin-export-matching-directory
...
Fix exports failing if a directory exists with the proposed filename
2023-02-15 19:04:15 +01:00
08ed174f61
Change GameplaySkinComponentLookup's generic to always be an enum
...
And document the class better.
2023-02-15 18:48:14 +09:00
a92e42bb84
Rename SkinnableTargetContainer to SkinComponentsContainer
...
Also use full `SkinComponentsContainerLookup` instead of the sub-type.
This will potentially be useful once we bring in per-ruleset targets.
2023-02-15 18:37:41 +09:00
