Commit Graph

237 Commits

Author SHA1 Message Date
43b9fde457 Add some nullability annotations for good measure 2021-01-06 13:15:15 +01:00
99701a6d9b Add null check on beatmapContainer for safety 2021-01-06 21:06:33 +09:00
83dbba3cbf Fix carousel beatmap set panels applying transforms to difficulties while they are loading 2021-01-05 18:41:45 +09:00
c25e2c3dd5 Select recommended beatmap if last selection is filtered 2020-12-03 23:13:14 +02:00
31f7f7072d Fix song select panels not loading if partially offscreen 2020-12-03 15:13:20 +09:00
6058c66edb Move drawable carousel set movement logic into panels themselves 2020-11-26 18:32:43 +09:00
5113d4af8f Rename BeatmapDifficultyManager to BeatmapDifficultyCache 2020-11-06 13:14:29 +09:00
3090b6ccb5 Resolve CA2249 inspections
"Use `string.Contains` instead of `string.IndexOf` to improve
readability"
2020-11-01 18:54:44 +01:00
8b04cd2cb0 Fix a potential null reference when loading carousel difficulties 2020-10-25 20:28:24 +09:00
1fe987d4b3 Merge pull request #10497 from peppy/beatmap-carousel-less-diffcalc-stutter
Disable difficulty calculation for set-level difficulty icons
2020-10-20 14:57:34 +09:00
30e1fce7a4 Reduce alloc overhead of DrawableCarouselBeatmapSet using new function-based ctor 2020-10-14 15:10:50 +09:00
07e6609e6d Disable difficulty calculation for set-level difficulty icons 2020-10-14 14:16:22 +09:00
e662dc5342 Add missing licence headers 2020-10-13 20:57:26 +09:00
8057ea1097 Fix formatting issues 2020-10-13 20:50:36 +09:00
3d416f4d64 Clean up beatmapSet resolution in DrawableCarouselBeatmapSet 2020-10-13 19:31:29 +09:00
75b6a5e17e Remove unnecessary hack (fixed via framework update) 2020-10-13 19:31:29 +09:00
5d11db7753 Locallise ChildItems to DrawableCarouselBeatmapSet for clarity 2020-10-13 19:31:29 +09:00
37daefc2b5 Remove outdated comment 2020-10-13 19:12:33 +09:00
834b0186f4 Adjust fade duration to be slightly shorter 2020-10-13 18:50:10 +09:00
2346644c04 Switch DelayedLoadUnloadWrappers to DelayedLoadWrappers
Due to pooling usage, there is no time we need to unload. Switching to
DelayedLoadWrapper cleans up the code and reduces overhead
substantially.
2020-10-13 18:47:40 +09:00
4f4f222514 Remove unnecessary fade (already applied by base DrawableCarouselItem) 2020-10-13 18:28:28 +09:00
83358d487f Remove logging 2020-10-13 18:18:22 +09:00
3d9ea852ec Remove masking override (no longer needed as our size is now correct) 2020-10-13 18:14:23 +09:00
69650c16fc Simplify vertical position calculations by including spacing in height definition 2020-10-13 18:13:36 +09:00
b1ddb08a4e Fix right click context menus appearing in incorrect locations 2020-10-13 18:01:12 +09:00
d9a6a6b245 Split content out into own class 2020-10-13 18:01:12 +09:00
9b2ebb8f0f Fix main content DelayedLoadUnloadWrapper not getting a valid size before load 2020-10-13 17:45:41 +09:00
f3b937e358 Fix masking issues with certain aspect ratio displays 2020-10-13 17:37:33 +09:00
fdd4d95cdc Fix difficulties being at incorrect vertical positions after filter is applied 2020-10-13 17:37:33 +09:00
b536f571fd Move header height propagation to update for safety 2020-10-13 17:37:33 +09:00
ded09b78cb Avoid usage of AutoSize for DrawableCarouselItems in general 2020-10-13 17:37:33 +09:00
cecdf14f53 Avoid reconstructing beatmap difficulties that were recently displayed 2020-10-13 17:37:33 +09:00
1da49073ab Calculate content height automatically 2020-10-13 17:37:33 +09:00
c08b5e8d03 Align beatmap difficulties correctly 2020-10-13 17:37:33 +09:00
cfec4f4fc1 Extract header element from base DrawableCarouselItem class 2020-10-13 17:37:33 +09:00
20b54fb904 Move transform clean-up to pooling free call 2020-10-13 17:37:33 +09:00
f6aa448523 Store y positions inside items rather than in a separate array 2020-10-13 17:37:33 +09:00
b92c22ad42 Add logging 2020-10-13 17:37:33 +09:00
9814e9ba7f Split classes out to reduce loc burder on DrawableCarouselBeatmapSet 2020-10-13 17:37:33 +09:00
975cd5a840 Add back beatmap difficulty appear/disappear movement 2020-10-13 17:37:33 +09:00
fd8654cff3 Add back difficulty panel spacing 2020-10-13 17:37:33 +09:00
82f9ca3de9 Bind to filter event changes in base drawable item 2020-10-13 17:37:33 +09:00
813ee19728 Use existing event flow for rendering beatmap difficulties 2020-10-13 17:37:33 +09:00
bb03c5d77c Temporarily disable masking temporarily to fix panels disappearing at extents 2020-10-13 17:37:33 +09:00
524419d5e4 Fix filtered items being considered for height calculation 2020-10-13 17:37:33 +09:00
0a144a1388 Correctly free panels after use to avoid finalizer disposal of subtree 2020-10-13 17:37:33 +09:00
5c29aa8cce Fix multiple difficulties being expanded at once 2020-10-13 17:37:33 +09:00
5c2f134665 Add back left offset for selected set 2020-10-13 17:37:33 +09:00
3cfc0dc82d Add safeties to beatmap panel loading code 2020-10-13 17:37:33 +09:00
954d43ef56 Debounce state application events 2020-10-13 17:37:33 +09:00