Commit Graph

34788 Commits

Author SHA1 Message Date
e37c325d94 Merge pull request #11084 from bdach/fix-hidden-increased-visibility-state-2 2020-12-04 14:08:36 +09:00
2f4b3a2d4c Merge branch 'master' into fix-hidden-increased-visibility-state-2 2020-12-04 13:38:01 +09:00
aeb059bcce Merge pull request #11069 from smoogipoo/fix-hidden-mod-crash 2020-12-04 13:27:43 +09:00
48c42e4247 Merge pull request #11083 from LittleEndu/recommend-if-filtered
Select recommended beatmap if last selection is filtered
2020-12-04 13:22:34 +09:00
0134ac94a7 Merge pull request #11055 from ekrctb/catch-stateless-rng 2020-12-04 13:08:30 +09:00
5db15a6b26 Merge branch 'master' into fix-hidden-mod-crash 2020-12-04 12:50:02 +09:00
d15f947778 Merge pull request #11073 from smoogipoo/dho-remove-onparentreceived 2020-12-04 11:41:34 +09:00
5ded4b9faa Merge branch 'master' into dho-remove-onparentreceived 2020-12-04 11:04:56 +09:00
3b38e0259f Merge pull request #11085 from bdach/sampleinfo-consistent-hashcode 2020-12-04 10:31:44 +09:00
15d9147edd Ensure equality member consistency for SampleInfo
The previous implementation of `SampleInfo`'s equality members was not
completely correct in its treatment of the `sampleNames` array. While
`Equals()` compared the values of `sampleNames` using `SequenceEqual()`,
therefore performing a structural check that inspects the contents of
both arrays, `GetHashCode()` used `HashCode.Combine()` directly on the
arrays, therefore operating on reference equality. This could cause the
pooling mechanism of samples to fail, as pointed out in #11079.

To resolve, change the `GetHashCode()` implementation such that it also
considers the contents of the array rather than just the reference to
the array itself. This is achieved by leveraging
`StructuralEqualityComparer`.

Additionally, as a bonus, an array sort was added to the constructor of
`SampleInfo`. This is intended to be a "canonicalisation" processing
step for the array of sample names. Thanks to that sort, two instances
of `SampleInfo` that have the same sample names but permutated will also
turn out to be equal and have the same hash codes, given the
implementation of both equality members. This gives `SampleInfo`
set-like semantics.
2020-12-03 23:25:53 +01:00
71fa0da7f4 Add failing test cases 2020-12-03 23:13:48 +01:00
4d739f11a8 Fix spinner ticks getting increased visibility state
Regressed in #10696. The old `IsFirstHideableObject()` method did not
consider nested hitobjects, while its replacement -
`IsFirstAdjustableObject()` - did. Therefore, spinner ticks could be
considered first adjustable objects, breaking the old logic.

There is no need to match over `SpinnerBonusTick`, as it inherits from
`SpinnerTick`.
2020-12-03 22:51:59 +01:00
0bc591fef2 Add failing assertions
`GameplayBeatmap` has to be used instead of the normal bindable
`Beatmap`, beecause the former uses osu!-specific hitobjects, while
the latter returns convert objects (i.e. `ConvertSlider`s).

Similarly, the mod has to be fetched from the player instead of the
global bindable, as `Player` has its own cloned instance of the mod, to
which the beatmap is applied. The global bindable instance does not have
`FirstObject` set.
2020-12-03 22:51:59 +01:00
c25e2c3dd5 Select recommended beatmap if last selection is filtered 2020-12-03 23:13:14 +02:00
1d92800761 Merge pull request #11068 from peppy/fix-carousel-edge-masking
Fix beatmap carousel panels getting masked away when out of scroll bounds
2020-12-03 20:40:44 +09:00
09af4bbd57 Merge branch 'dho-remove-onparentreceived' into fix-hidden-mod-crash 2020-12-03 20:10:16 +09:00
0bdf99b97a Remove OnParentReceived() 2020-12-03 20:08:42 +09:00
73e99718bc Change order of OnParentReceived() 2020-12-03 20:06:26 +09:00
37d550f42a Merge pull request #11035 from smoogipoo/add-playlist-length 2020-12-03 18:39:54 +09:00
1c15c4bcee Merge pull request #11072 from peppy/update-framework 2020-12-03 18:32:45 +09:00
78417b8015 Merge pull request #10905 from smoogipoo/hit-sample-pooling
Implement hitsample pooling
2020-12-03 18:09:53 +09:00
8245bb85dc Invoke on initial bind 2020-12-03 18:06:55 +09:00
62b1e37f73 Use async overloads 2020-12-03 18:04:53 +09:00
3e62da119e Add to inspector also 2020-12-03 17:59:39 +09:00
78c43641d1 Update imagesharp namespaces (and consume System.Drawing types instead) 2020-12-03 17:43:09 +09:00
c64343c7d7 Update framework 2020-12-03 17:42:41 +09:00
d7cfaa38f1 Merge branch 'master' into hit-sample-pooling 2020-12-03 17:08:13 +09:00
3550e5b30f Add length display to room screen as well 2020-12-03 16:42:06 +09:00
1039df5e16 Merge pull request #11053 from smoogipoo/fix-banana-samples
Fix bananas not playing sounds
2020-12-03 16:01:45 +09:00
de1c628d19 Merge pull request #11070 from smoogipoo/fix-songselect-panel-load
Fix song select panels not loading if partially offscreen
2020-12-03 15:50:14 +09:00
31f7f7072d Fix song select panels not loading if partially offscreen 2020-12-03 15:13:20 +09:00
db7e82c560 Add test 2020-12-03 14:54:28 +09:00
e3bbc2b128 Rework osu! hidden mod to avoid storing hitobjects 2020-12-03 14:45:56 +09:00
897f593b37 Fix beatmap carousel panels getting masked away when out of scroll bounds
Regressed in https://github.com/ppy/osu/pull/10973 due to removed masking specification.

Closes #11067.
2020-12-03 13:26:28 +09:00
a5bb194cb8 Merge pull request #11060 from FamousPig/fix-raw-input
Fix MouseHandler not being ignored when Raw Input is enabled
2020-12-03 12:15:51 +09:00
2e8195e059 Use transformation to set fruit rotation 2020-12-03 12:13:14 +09:00
7fd385efe6 Remove unused using directive 2020-12-02 20:01:58 +01:00
a2a10d4e13 Don't use nameof(MouseHandler) 2020-12-02 19:45:59 +01:00
bbde1f6b9c Fix MouseHandler not being ignored when raw input is enabled 2020-12-02 18:56:59 +01:00
6c41830d4d Merge pull request #11054 from peppy/update-resources
Update resources
2020-12-02 18:42:02 +01:00
2b828faecb Merge branch 'master' into update-resources 2020-12-02 18:07:46 +01:00
fdcfa81e46 Make RandomSeed a property, not a bindable 2020-12-02 20:53:47 +09:00
33b88e09cd Merge pull request #11056 from smoogipoo/fix-spectator-test-failures
Fix spectator connecting not being thread-safe
2020-12-02 19:50:15 +09:00
d5dccbc3d7 Fix spectator not being thread-safe 2020-12-02 19:13:09 +09:00
5936a8ffb4 Fix drawables are added multiple times in a test scene 2020-12-02 18:06:14 +09:00
1a6b8e022c Fix formatting 2020-12-02 17:20:52 +09:00
ef741a1471 Test banana colour change based on random seed 2020-12-02 17:16:36 +09:00
08848e49de Set banana combo colour using random seed 2020-12-02 17:12:30 +09:00
beda6961e4 Add a test for fruit randomness 2020-12-02 16:55:58 +09:00
8a78c495f2 Refactor DHO testing logic to the "specimen" class 2020-12-02 16:55:37 +09:00