ee7e7f2d3a
Mark the property as non-nullable.
2022-07-19 20:39:41 +08:00
d9addebc93
Remove the nullable disable annotation in the test project and fix the api broken.
2022-07-19 20:39:41 +08:00
317558f876
Mark the shader as non-nullable because shader should always has the value.
...
And initialize the breaks to avoid get the null instance.
2022-07-19 20:39:41 +08:00
3af093cb27
Remove the null check because bindable should always have the value.
2022-07-19 20:39:41 +08:00
ce1bb206c8
Initialize some bindables for prevent get the null instance.
2022-07-19 20:39:41 +08:00
1f9f2b413e
Remove the nullable disable annotation.
...
Also, mark as nullable for some properties.
2022-07-19 20:39:41 +08:00
cf38b15332
Merge pull request #19124 from frenzibyte/song-select-metadata-search
...
Change clicking source/tags on song select to filter instead of searching online
2022-07-15 19:16:31 +09:00
603f2c3814
Merge pull request #19130 from peppy/update-framework
...
Update framework
2022-07-15 19:16:16 +09:00
e12e480393
Only expose bindable string rather than full textbox
2022-07-15 18:01:35 +09:00
5aca0e342d
Merge pull request #19090 from goodtrailer/stable-slider-followcircle-anims
...
Imitate stable's slider followcircle fade + scale animations
2022-07-15 17:58:59 +09:00
105ffdbbdd
Update framework
2022-07-15 17:57:14 +09:00
23a0e25c8c
Merge branch 'master' into stable-slider-followcircle-anims
2022-07-15 17:27:48 +09:00
7ed4eb5815
Adjust transform logic to match osu-stable (and add TODOs for remaining oversights)
2022-07-15 17:17:55 +09:00
0ade8db550
Tidy up nullability and casting
2022-07-15 16:40:48 +09:00
c1dd1cfead
Merge pull request #19082 from peppy/api-solo-score-model
...
Add and consume `SoloScoreInfo`
2022-07-15 15:20:18 +09:00
36b06f87a4
Merge pull request #19037 from frenzibyte/drawable-playlist-item-collection
...
Allow adding playlist items to beatmap collections via context menu
2022-07-15 15:04:39 +09:00
7e80a71020
Replace download tracker with local querying
2022-07-15 08:16:36 +03:00
254d22de1c
Use proper variable name
2022-07-15 07:44:56 +03:00
86d019c2b2
Enable NRT on BeatmapDetails
2022-07-15 06:52:06 +03:00
97c3eea3aa
Fix beatmap details source and tags not filtering on song select
2022-07-15 06:51:50 +03:00
eafa11555a
Allow specifying custom search action to metadata sections
2022-07-15 06:41:03 +03:00
cd085cbd97
Merge pull request #19114 from frenzibyte/fix-potential-dialog-test-failure
...
Fix dialog overlay potentially pushing dialog while not loaded
2022-07-15 12:34:19 +09:00
aea786ea0c
Fix minor typo
2022-07-15 05:56:49 +03:00
0bafafd63b
Remove unnecessary test coverage
...
RIP hours.
2022-07-15 03:20:52 +03:00
1581f1a0ff
Convert constructor in abstract class to protected
2022-07-14 17:11:01 -07:00
4453b0b3e8
Replace comment pointer with actual comment
2022-07-14 17:11:01 -07:00
66932f1af6
Move shared followcircle code into abstract base class
2022-07-14 17:11:01 -07:00
3806416541
Merge pull request #19107 from peppy/first-run-language-selection
...
Add language selection to first run overlay
2022-07-14 22:58:32 +09:00
d8ae1151c6
Merge pull request #19121 from peppy/fix-realm-multiple-online-id
...
Ensure that multiple `BeatmapSetInfo` with same `OnlineID` don't cause import failures
2022-07-14 19:01:23 +09:00
ebe0cfefd8
Ensure that multiple BeatmapSetInfo already in realm don't cause import failures
...
Really this shouldn't happen but I managed to make it happen. Until this
comes up again in a way that matters, let's just fix the LINQ crash from
`SingleOrDefault`.
I've tested this to work as expected in the broken scenario.
2022-07-14 18:21:41 +09:00
08396ba486
Adjust colouring to avoid weird banding during transition period
2022-07-14 14:47:25 +09:00
5dff48a1e0
Fix button selection animation not playing smoothly when new glyphs are loaded
2022-07-14 14:40:25 +09:00
5c6b4e498d
Protect against a potential early call to LanguageButton.Selected
2022-07-14 14:31:59 +09:00
227871e8df
Refactor hide logic a touch for better readability
2022-07-14 14:00:33 +09:00
dccd81dbc7
Use BindValueChanged to handle changes between push time and schedule execution
2022-07-14 07:07:32 +03:00
b96faedbe6
Fix dialog overlay hiding early-pushed dialog on initial PopOut call
2022-07-14 07:06:57 +03:00
c59784c49f
Always schedule popup dialog push
2022-07-14 07:06:03 +03:00
1222123541
Rename method and parameter
2022-07-14 07:05:19 +03:00
be69514002
Fix CollectionManager opening file multiple times across test scene
2022-07-14 06:21:23 +03:00
3def8428aa
Make scheduling more legible
2022-07-14 06:06:58 +03:00
f83d413b33
Fix dialog overlay potentially pushing dialog while not loaded
2022-07-14 06:05:03 +03:00
b511c9cc3f
Merge pull request #19100 from peppy/tourney-save-changes-button-ux
...
Disable tournament client "save changes" button when there's no changes to save
2022-07-14 05:09:36 +03:00
a85a70c472
Fix potential nullref in ContextMenuItems
2022-07-14 05:04:28 +03:00
2734a28115
Merge branch 'master' into tourney-save-changes-button-ux
2022-07-14 04:37:03 +03:00
24df8f6a0d
Enable NRT on save changes button
2022-07-14 04:33:07 +03:00
776d9551e2
Disable "save changes" button by default
2022-07-14 04:16:25 +03:00
cb2f0b8c67
Add test coverage for collection items
2022-07-14 03:42:03 +03:00
9ec4fbb86d
Add test coverage for details item
2022-07-14 03:41:47 +03:00
036e64382f
Add beatmap details menu item to playlist items
2022-07-14 03:41:47 +03:00
728487b7fb
Handle GetBeatmapSetRequest on test room requests handler
...
Required for `BeatmapSetOverlay` lookups to work under dummy API. Not
100% sure about it, but works for now.
2022-07-14 02:34:55 +03:00
