Commit Graph

5369 Commits

Author SHA1 Message Date
94b7e89ac0 Merge pull request #12747 from frenzibyte/current-star-rating
Allow changing current star difficulty of a `StarRatingDisplay`
2021-05-15 15:39:39 +09:00
bdcb1a624e Merge pull request #12759 from Naxesss/beatmap-verifier-context
Encapsulate check arguments in context object
2021-05-15 15:39:12 +09:00
7665bdfbbb Merge branch 'master' into null-assignment-warning-enable 2021-05-15 01:08:34 +02:00
d581e0a252 Ignore possible nulls in NotifyCollectionChangedArgs
Safe to access by the virtue of the preceding case labels on
`args.Action`.  And they're in test code anyways.
2021-05-15 00:09:34 +02:00
e62e473bb2 Ignore possible null in multiplayer test
A null value will fail the test anyhow.
2021-05-15 00:09:34 +02:00
b51d038088 Ignore possible path-related nulls
They're all in test code anyway, so any issue there will cause a test to
fail.
2021-05-15 00:09:34 +02:00
f2d0f7db99 Remove list null-checks in LogoTrackingContainer test
If the null-checks were tripped, the test would crash anyway. It is not
possible to call `.Any()` and get a valid result instead of an exception
on a null reference.
2021-05-15 00:09:34 +02:00
c9facf70f9 Use conditional nullability attribute
As it turns out, C# 8 provides an attribute that allows annotating that
an `out` parameter's nullability depends on the method's return value,
which is exactly what is desired here.
2021-05-15 00:09:34 +02:00
1c92b3a8f5 De-duplicate star rating display creation in test 2021-05-14 22:03:44 +02:00
6cc678f497 Remove nullability and transition support from star rating display 2021-05-14 16:05:40 +03:00
34aab11ff3 Add null star rating display test case 2021-05-14 14:25:46 +03:00
0655825057 Separate changing star rating display to own test 2021-05-14 14:25:13 +03:00
9069db0743 Fix case of hitObjects variables 2021-05-14 16:22:19 +09:00
48672f8afd Add very basic test logic to ensure PlayerLoader is present for playlists 2021-05-14 15:02:36 +09:00
9860e482af Use TestWorkingBeatmap instead of null in tests
Fixes the warning that #12801 will give.
2021-05-14 05:32:52 +02:00
d5b14b6b99 Merge branch 'master' into remove-skinnable-hud-classes 2021-05-13 21:06:48 +09:00
746862dcb1 Merge pull request #12750 from peppy/skin-serialisation
Add skin editor saving / loading support
2021-05-13 20:58:03 +09:00
94538b3842 Remove accidental whitespace 2021-05-13 12:56:36 +02:00
a3869c02f4 Merge branch 'master' into fix-two-hovered-handles 2021-05-13 19:24:42 +09:00
c8b7cfc753 Merge branch 'skin-serialisation' into remove-skinnable-hud-classes 2021-05-13 19:05:08 +09:00
19800f5f7f Move IBeatmap arg into context 2021-05-13 11:24:22 +02:00
e0e9106921 Enable autoplay in skin editor tests 2021-05-13 14:55:11 +09:00
e7c7786db3 Merge branch 'master' into beatmap-verifier-context 2021-05-13 07:40:33 +02:00
8b9ac86d4b Merge branch 'master' into skin-serialisation 2021-05-13 12:35:06 +09:00
5b03092968 Fix possible test failure 2021-05-13 11:53:50 +09:00
55e1f97f59 Remove unused using statement 2021-05-12 19:06:40 +09:00
0a895fff15 Remove remaining test usage of SkinnableXXX HUD components 2021-05-12 18:53:25 +09:00
80e231d90a Add failing test case 2021-05-12 11:42:55 +03:00
c6f0a6aed3 Merge pull request #12538 from smoogipoo/multiplayer-spectator-screen
Implement the multiplayer spectator screen
2021-05-12 17:24:35 +09:00
273cd18b8a Use test streaming client in gameplay leaderboard test 2021-05-12 14:19:36 +09:00
21fc0ba43b Combine test spectator streaming client implementations 2021-05-12 13:05:02 +09:00
c13b93e6f1 Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks
This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.

See next commit for example.
2021-05-12 02:29:18 +02:00
048677846b Change HealthDisplay to be a CompositeDrawable 2021-05-11 23:10:30 +09:00
f5bc389998 Fix flaky tests 2021-05-11 19:31:32 +09:00
bc4213eea1 Add test for changing back to idle on deletion 2021-05-11 19:26:58 +09:00
7fe8737d94 Add failing tests 2021-05-11 19:21:44 +09:00
811282a975 Add failing test 2021-05-11 19:01:41 +09:00
61ea3f2e64 Remove unnecessary test step creating needless skins 2021-05-11 18:39:15 +09:00
2396ba42a6 Change HealthDisplay to be a CompositeDrawable 2021-05-11 18:39:14 +09:00
004798d61d Update Legacy components to not require skin in ctor 2021-05-11 18:39:14 +09:00
10a4a5decb Merge branch 'master' into multiplayer-spectator-screen 2021-05-11 17:33:09 +09:00
7d9cdd3bc2 Merge branch 'master' into skin-components-list 2021-05-11 17:27:48 +09:00
7c8dd91674 Rename test to better match tested class 2021-05-11 09:29:15 +09:00
6bb52ebcf8 Merge pull request #12570 from frenzibyte/corner-rotation-controls
Add rotation controls to editor selection box corners
2021-05-10 23:09:44 +09:00
e7355da201 Merge branch 'master' into osu-markdown 2021-05-10 20:02:04 +09:00
2ecd638f7f Merge branch 'master' into skin-components-list 2021-05-10 18:13:10 +09:00
97e72849af Fix regressed HitErrorDisplay behaviour (and localise binding to meter implementations) 2021-05-10 15:24:13 +09:00
ca772b60b1 Use regular test steps rather than one-time set up and scheduling 2021-05-10 08:56:30 +03:00
301dab1ce8 Refactor StarRatingDisplay to be mutable with a current bindable 2021-05-10 08:56:30 +03:00
3c3500d070 Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces 2021-05-10 12:23:18 +09:00