Commit Graph

9775 Commits

Author SHA1 Message Date
3d6602b8df Ensure FailAnimation is disposed synchronously to avoid test failures 2021-10-11 14:05:31 +09:00
794b4c46cf Split score counter class into two distinct classes to simplify usages 2021-10-10 17:56:32 +09:00
06cce0119c Use localisable format string for comma separator mode 2021-10-10 17:41:16 +09:00
446f091d32 Use comma separator for tournament score displays 2021-10-10 16:06:12 +09:00
436ead421a Move low pass fail effect to FailAnimation 2021-10-08 12:27:04 +09:00
da96cc73d8 Fix dual specification of SuspensionHandler and move fields around slightly 2021-10-07 23:40:47 +09:00
310d7965b6 Merge branch 'master' into more-filter-effects 2021-10-07 20:52:38 +09:00
f8e50731b7 Merge pull request #14991 from peppy/intro-tests-no-menu-load
Allow intro screens to be created without loading a `MainMenu`
2021-10-07 20:48:54 +09:00
ef64c64f0b Merge branch 'master' into popup-filter-effect 2021-10-07 18:56:07 +09:00
bece807857 Merge pull request #14980 from peppy/difficulty-move-to-beatmap
Copy `BaseDifficulty` to `Beatmap<T>` and move the majority of write operations across
2021-10-07 18:43:44 +09:00
f98dd1b811 Merge branch 'master' into popup-filter-effect 2021-10-07 18:40:21 +09:00
cc209f0f2d Add filter effect to fail sequence 2021-10-07 17:55:30 +09:00
5c48340520 Add filter effect to beatmap loading 2021-10-07 17:55:21 +09:00
0df409c050 Move difficulty copy to BeatmapModelManager.Save 2021-10-07 17:16:45 +09:00
d50443fdf2 Merge branch 'master' into difficulty-move-to-beatmap 2021-10-07 16:50:10 +09:00
f88d898960 Allow intro screens to be created without loading a MainMenu 2021-10-07 16:38:22 +09:00
5f129ae33c Remove local overridden storage of Mods in Player
Not required and only causing headaches. Accessing mods should now be
done via `GameplayState`.

Closes #14912.
2021-10-07 14:53:39 +09:00
9705c7b546 Use cloned mods in one more place 2021-10-06 21:30:30 +09:00
433e7cd403 Fix rate mods not working if pp counter is displayed 2021-10-06 21:26:30 +09:00
4ca97bc60a Merge branch 'master' into difficulty-move-to-beatmap 2021-10-06 16:14:21 +09:00
222997f2b9 Copy difficulty settings back out to BeatmapInfo on editor changes 2021-10-06 15:19:26 +09:00
b339c149d8 Copy BaseDifficulty to Beatmap<T> and move all write operations across 2021-10-06 15:10:45 +09:00
e6aa05a4a4 Merge pull request #14978 from peppy/fix-editor-file-selector-textbox-drags
Fix dragging on an editor file selection text box causing repeated popover display
2021-10-06 13:52:08 +09:00
d9849bcf49 Fix dragging on an editor file selection text box causing repeated popover display
Local fix and no tests as this is a pretty weird usage of `TextBox`.
We'll probably want to change it to not use a textbox eventually.

Closes #14969.
2021-10-06 13:15:05 +09:00
e837a3511d Merge branch 'master' into beatmap-difficulty-more-interface-usage 2021-10-06 12:18:51 +09:00
4bbff2ebf7 Merge branch 'master' into new-interfaces 2021-10-06 11:38:17 +09:00
9491e5a547 Merge pull request #14954 from peppy/rename-result-response
Rename `APIRequest.Result` to `Response`
2021-10-06 10:52:33 +09:00
5a4474e1b2 Fix incorrect DI retrieval in ReplayDownloadButton 2021-10-06 05:29:00 +09:00
98fef6ece2 Handle judgement reverts with actual display updates 2021-10-05 19:08:30 +09:00
bd84a8b749 Merge branch 'new-interfaces' into beatmap-difficulty-more-interface-usage 2021-10-05 18:21:21 +09:00
0859c336de Also dim counter during initial calculation phase 2021-10-05 17:24:36 +09:00
f64226ded6 Fix display not displaying correctly after initial load 2021-10-05 17:10:32 +09:00
599d82e383 Avoid returning a live IEnumerable 2021-10-05 17:01:07 +09:00
fa7f11d906 Add easing to rolling counter value 2021-10-05 16:51:49 +09:00
565e888f58 Tidy up attribute retrieval code 2021-10-05 16:40:07 +09:00
45b63cbad9 Remove unnecessary dependency 2021-10-05 16:03:25 +09:00
676df55a0e Fade display out during rewind (as the value displayed is no longer valid) 2021-10-05 15:39:29 +09:00
81a13566bc Adjust default location slightly, fix alignment of "pp" subtext 2021-10-05 15:28:03 +09:00
b6af93d434 Apply some code quality refactoring 2021-10-05 15:14:49 +09:00
7176dc95e5 Revert Player.Score to protected 2021-10-05 14:55:40 +09:00
e19be8ebe4 Make GameplayState.Score immutable 2021-10-05 14:55:40 +09:00
d3b9660148 Move common interface implementations to extension methods 2021-10-05 14:41:14 +09:00
b41fa41c85 Rename APIRequest.Result to Response 2021-10-05 14:28:56 +09:00
5624dd9af6 Fix incorrect CancellationToken usage
Apparently I wrote the BDL system and don't know how this works. I
believe you need `CancellationToken?` or CanBeNull=true, however that doesn't actually
play well when actually using the token in code...
2021-10-05 12:07:41 +09:00
593da79bbc Further asyncify load process 2021-10-05 11:26:13 +09:00
d120678e30 Fix redundant default value 2021-10-04 21:13:14 +09:00
d1e7191f94 Pass score into GameplayState 2021-10-04 20:59:51 +09:00
0b0316e27e Fix missing CanBeNull 2021-10-04 20:59:31 +09:00
1837e1bf3c Share rounding with PerformanceStatistic 2021-10-04 20:35:53 +09:00
fb63e5ed87 Add todo 2021-10-04 20:35:26 +09:00