87854fc4fa
Rename variable
2020-03-28 13:23:31 +02:00
63f6269eb0
Test both ways
2020-03-28 13:10:20 +02:00
659865b457
Use understandable set id
2020-03-28 13:08:06 +02:00
0a69647efe
Merge remote-tracking branch 'origin/traversal-is-broken' into rewrite-select-next
2020-03-28 13:06:37 +02:00
6a0c5c87aa
Use already existing variable
2020-03-28 13:06:03 +02:00
fc3f9ff6fa
Don't use drawables for select next
2020-03-28 12:54:48 +02:00
3cc574e62d
Merge branch 'master' into overlay-scroll-container
2020-03-28 16:46:01 +09:00
fb4b334ce2
Add support for legacy skin sliderstartcircle / sliderstartcircleoverlay
2020-03-28 14:10:26 +09:00
c2e31f53f1
Merge remote-tracking branch 'upstream/master' into catch-hyperdash-fruit-colouring
2020-03-28 07:44:11 +03:00
45eb03bfe2
Apply review suggestions
2020-03-28 07:43:47 +03:00
96e1ab775e
Merge pull request #8475 from bdach/fix-break-overlay-z-order
...
Fix break overlay displaying in front of all other player overlays
2020-03-28 13:39:36 +09:00
944926e950
Merge branch 'master' into fix-break-overlay-z-order
2020-03-28 13:04:19 +09:00
94aa6ab5c9
Merge pull request #8474 from bdach/fix-no-break-info
...
Fix break overlay not displaying progress information
2020-03-28 12:49:39 +09:00
e9dc545429
Merge branch 'master' into fix-no-break-info
2020-03-28 12:39:37 +09:00
a317ef65b8
Remove default for argument
2020-03-28 12:18:28 +09:00
0471efc885
Merge pull request #8476 from bdach/fix-loader-tests
...
Improve robustness of loader tests
2020-03-28 11:20:19 +09:00
15fb1a099e
Modify assert to avoid false failures
...
In headless tests it was possible for TestInstantLoad() to erroneously
fail. There were two scenarios in which LoadingSpinner could be null:
1. If the test runner was quick enough, the assert could end up running
even before Loader.OnEntering() had even had a chance to, meaning
that the spinner was never even actually assigned to or instantiated
at that point in time.
2. Even if Loader.OnEntering() had managed to run, there was also
a possibility that the spinner itself wasn't loaded at the point
of checking the assertion. As the spinner is accessed through
ChildrenOfType(), which only checks InternalChildren and ignores
all currently-loading drawables, it would therefore return null.
As null != 0, both of these cases would actually fail the test (this is
best seen running headless, preferably with a [Repeat] attribute
attached).
To resolve, allow the spinner to be null at the point of asserting and
duplicate the assertion step at the end. This weakens the test, as case
(1) should probably be waited for and case (2) could be solved with
exposition as protected in the base, but when attempting to wait for
the loader itself to be loaded there were also cases where the
appropriate until step would take so much time that the spinner would
actually become visible in line with the delayed display logic, so this
is a best-effort attempt to address both points without radical
changes.
2020-03-28 00:43:57 +01:00
3a3bfe9a5e
Reorder children to fix pause overlay z-order
2020-03-27 21:19:49 +01:00
adc759771f
Hook up score processor in player
2020-03-27 19:47:42 +01:00
46af4bce32
Cover regression in autoplay test
2020-03-27 19:42:45 +01:00
7b24cc325f
Implement OverlayScrollContainer component
2020-03-27 20:57:57 +03:00
4f77850790
Merge pull request #8467 from peppy/update-framework
...
Update framework
2020-03-27 21:22:39 +09:00
6ecfeb8cc3
Merge pull request #8455 from Game4all/handle-novideo-beatmaps
...
Fix NullReferenceException when starting the no-video version of a beatmap with video
2020-03-27 21:12:40 +09:00
5be8934c8c
Merge pull request #8407 from peppy/disable-raw-input
...
Disable raw input toggle on all but windows
2020-03-27 21:10:02 +09:00
f25b1b33e3
Merge pull request #8461 from peppy/fix-minia-mod-replay-recording
...
Fix osu!mania replays recording incorrectly when key mod applied
2020-03-27 20:55:58 +09:00
4106700771
Update framework
2020-03-27 20:51:44 +09:00
3763457a1d
Merge pull request #8451 from peppy/fix-slider-end-sounds
...
Only play slider end sounds if tracking
2020-03-27 20:38:59 +09:00
fdbffbd1db
Merge pull request #8452 from peppy/add-slider-judgement-accuracy
...
Make slider judgements count towards base score / accuracy
2020-03-27 20:37:26 +09:00
6788b7f9cd
Add test for loading storyboards with missing video file.
2020-03-27 12:07:47 +01:00
abb5bb14dd
Merge pull request #8450 from peppy/reduce-fruit-spread
...
Reduce spread of stacked fruit
2020-03-27 19:57:54 +09:00
5e1cb0e9e9
Merge branch 'master' into fix-minia-mod-replay-recording
2020-03-27 19:26:41 +09:00
04b34791cd
Merge branch 'master' into add-slider-judgement-accuracy
2020-03-27 19:26:34 +09:00
005a818f32
Merge branch 'master' into fix-slider-end-sounds
2020-03-27 19:26:32 +09:00
378a957b33
Merge branch 'master' into reduce-fruit-spread
2020-03-27 19:19:23 +09:00
2bbff632c2
Merge pull request #8447 from peppy/fix-break-overlay-scaling
...
Fix break overlay scaling with gameplay
2020-03-27 19:18:51 +09:00
d36f5fb96f
Fix animated follow points not (re)animating after rewind
2020-03-27 18:03:02 +09:00
f75c082601
Fix osu!mania replays recording incorrectly when key mod applied
2020-03-27 15:50:11 +09:00
e707adb773
Increase amount of test sets
2020-03-26 21:16:10 +02:00
902734b75e
Add failing test
2020-03-26 20:32:43 +02:00
bbbaaae3ee
Write tests
2020-03-26 19:18:16 +02:00
ee112c6f50
Move and change logic
2020-03-26 18:42:08 +02:00
83410315c6
Make fields private
2020-03-26 17:18:01 +01:00
01c9112f82
Add a null check to prevent NRE when playing the "no video" version of a beatmap.
2020-03-26 17:09:22 +01:00
543f584595
Adjust user profile tabs
2020-03-26 16:44:46 +01:00
9a30ff5a00
Fix code quality issues
2020-03-26 16:11:58 +01:00
00c1ff993a
Fix merge conflicts.
2020-03-26 15:48:18 +01:00
da996ffe74
Update header breadcrumb tab control
2020-03-26 15:44:53 +01:00
46ebf6ef78
Update user profile section tabs and rename classes for better readibility
2020-03-26 15:44:22 +01:00
816418742e
Update header tab control
2020-03-26 15:43:48 +01:00
e33055e2c4
Simplify active tab font changes and expose necessary fields in OsuTabItem
2020-03-26 14:19:36 +01:00
