19800f5f7f
Move IBeatmap arg into context
2021-05-13 11:24:22 +02:00
b37cb3bdbe
Change interpreted difficulty from bindable to regular value
...
There's no reason for why checks would need this to be bindable. A 1-directional binding is more appropriate.
2021-05-13 09:00:30 +02:00
4eeeaf6a1a
Keep track of local bound copy
2021-05-13 07:57:32 +02:00
e7c7786db3
Merge branch 'master' into beatmap-verifier-context
2021-05-13 07:40:33 +02:00
b81f86bd4d
Move DI resolution to inside BDL parameters
2021-05-13 13:54:06 +09:00
c6648112e5
Simplify binding flow in InterpretationSection
2021-05-13 13:51:41 +09:00
cdcbaf4291
Tidy up specification of SettingsSection
2021-05-13 13:45:10 +09:00
47948d7b34
Set default for bindable in object initializer
...
Fixes the CI failure.
2021-05-13 06:08:48 +02:00
fb305130de
Also refresh when interpreted difficulty changes
2021-05-13 06:00:21 +02:00
ee0a6ba93e
Use local bound copy in InterpretationSection as well
...
Else we're relying on the `VerifyScreen`'s bindable instance, and by extension the `VerifyScreen` instance itself.
2021-05-13 05:59:49 +02:00
e80d8f6922
Keep track of local bound copy
2021-05-13 05:46:47 +02:00
04c1585eb2
Use more consistent lambda discards
2021-05-13 05:38:45 +02:00
e86834b740
Use local bound copy for HiddenIssueTypes
2021-05-13 05:25:20 +02:00
c8d21f2c3f
Isolate refreshing to IssueList
2021-05-13 05:25:02 +02:00
fbb76ba598
Split ShowIssueTypes dict into hidden and configurable lists
...
This way `VerifyScreen` is decoupled from which options `VisibilitySection` provides.
Bindings are a bit less neat, though.
2021-05-13 04:50:32 +02:00
dd8423c4c4
Set interpreted difficulty to correct default
2021-05-13 04:36:20 +02:00
6806e40ad9
Remove unnecessary local variable
...
This now exists in `VerifyScreen`, which we can access from here.
2021-05-13 04:30:40 +02:00
56bd897666
Move ShowIssueTypes to VerifyScreen
2021-05-13 04:29:27 +02:00
d2e0e8ad94
Reverse direction of binding to allow for better abstract class definitions
2021-05-12 16:53:58 +09:00
17e3764576
Rename Settings to have a more localised name
2021-05-12 16:38:04 +09:00
64d96b06a6
Add interpreted difficulty info to BeatmapVerifierContext
...
Enables checks to make use of the difficulty level as shown in the settings UI.
2021-05-12 02:30:21 +02:00
c13b93e6f1
Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks
...
This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.
See next commit for example.
2021-05-12 02:29:18 +02:00
4aeaec6ecc
Add InterpretationSection and its bindable in IssueList
...
We'll eventually connect that bindable so that checks can access it.
2021-05-12 01:32:18 +02:00
ad78aec1ef
Refresh IssueList on changes in VisibilitySection
2021-05-12 01:30:45 +02:00
1bb7d412da
Add IssueList filtering based on those bindables
2021-05-12 01:29:46 +02:00
2e4399f0c1
Add VisibilitySection and its bindables in IssueList
2021-05-12 01:27:21 +02:00
01b8794757
Add abstract Section class
...
Similar to `Section` in the timing screen, but does not make use of checkboxes, nor specific to control points.
So there's a lot of things that differ, hence new class instead of factoring that out.
2021-05-12 01:26:12 +02:00
1de35f880b
Separate IssueList into own class
2021-05-12 01:23:31 +02:00
d3c1ec55ee
Take IssueList in IssueSettings constructor
...
We'll be using this for bindables later.
2021-05-12 01:22:32 +02:00
97bd482d4d
Factor out load from settings into new Settings class
2021-05-12 01:21:38 +02:00
6bb52ebcf8
Merge pull request #12570 from frenzibyte/corner-rotation-controls
...
Add rotation controls to editor selection box corners
2021-05-10 23:09:44 +09:00
fc2a527e9d
Revert "Guard against potentially null track if ever"
...
This reverts commit b1134c3857
2021-05-07 09:57:08 +03:00
7c4e54a1d4
Unrevert null-colaescing/conditionals removal
2021-05-07 09:54:14 +03:00
b1134c3857
Guard against potentially null track if ever
2021-05-07 08:30:50 +03:00
37f44d2e37
Revert wrong not-null track changes
...
This reverts commit f9d99a988271547bece0
2021-05-07 08:28:44 +03:00
71547bece0
Remove any null-coalescing/conditionals in WorkingBeatmap.Track usages
2021-05-07 07:46:23 +03:00
539643c72b
Set loadable beatmap track to clock immediately in BDL
...
This reverts commit 84da247002
2021-05-07 07:21:56 +03:00
84da247002
Fix editor clock using the wrong beatmap track on creation
2021-05-07 05:32:55 +03:00
2a67361dc0
OnOperation -> TriggerOperation
2021-05-05 21:50:16 +03:00
3cac837acf
Merge branch 'master' into skin-bindables
2021-05-05 20:16:27 +02:00
1ac80d42f9
Merge branch 'master' into corner-rotation-controls
2021-05-04 23:53:23 +03:00
4185053120
Merge branch 'master' into fix-selection-handler-visibility
2021-05-04 20:21:05 +02:00
8abff4881b
Hide the corresponding rotation handle when holding scale handle
2021-05-04 07:31:55 +03:00
b2a0c2b563
Consider drag handles active using mouse down instead of when dragged
2021-05-04 06:41:26 +03:00
5f33c3514e
Move selection box control internal events to drag handles
2021-05-04 06:37:22 +03:00
fd7a6b3a7c
Finish transforms on controls load complete
2021-05-04 06:37:20 +03:00
b28e1569ca
Remove no-longer-relevant matching comment
2021-05-03 20:09:50 +09:00
840c22a3b1
Add back mis-removed fade transform
2021-05-03 12:16:40 +03:00
4f8240f19a
Merge branch 'master' into corner-rotation-controls
2021-05-03 18:02:23 +09:00
fdd0713988
Merge branch 'fix-selection-handler-visibility' into skin-bindables
2021-05-03 17:40:03 +09:00
