Commit Graph

27656 Commits

Author SHA1 Message Date
1e8badb14a Move all logic to TopLocalRank and remove CarouselBeatmapRank 2020-04-04 22:28:36 +03:00
6bde102207 Merge remote-tracking branch 'upstream/master' 2020-03-28 18:14:17 +02:00
faa2b49be4 Fix namespace for CarouselBeatmapRank, make UpdateableRank in TopLocalRank readonly 2020-03-28 18:13:39 +02:00
1c711147f3 Move all carousel rank logic into separate classes (TopLocalRank and CarouselBeatmapRank) 2020-03-28 17:22:01 +02:00
96e1ab775e Merge pull request #8475 from bdach/fix-break-overlay-z-order
Fix break overlay displaying in front of all other player overlays
2020-03-28 13:39:36 +09:00
944926e950 Merge branch 'master' into fix-break-overlay-z-order 2020-03-28 13:04:19 +09:00
94aa6ab5c9 Merge pull request #8474 from bdach/fix-no-break-info
Fix break overlay not displaying progress information
2020-03-28 12:49:39 +09:00
e9dc545429 Merge branch 'master' into fix-no-break-info 2020-03-28 12:39:37 +09:00
a317ef65b8 Remove default for argument 2020-03-28 12:18:28 +09:00
0471efc885 Merge pull request #8476 from bdach/fix-loader-tests
Improve robustness of loader tests
2020-03-28 11:20:19 +09:00
15fb1a099e Modify assert to avoid false failures
In headless tests it was possible for TestInstantLoad() to erroneously
fail. There were two scenarios in which LoadingSpinner could be null:

1. If the test runner was quick enough, the assert could end up running
   even before Loader.OnEntering() had even had a chance to, meaning
   that the spinner was never even actually assigned to or instantiated
   at that point in time.

2. Even if Loader.OnEntering() had managed to run, there was also
   a possibility that the spinner itself wasn't loaded at the point
   of checking the assertion. As the spinner is accessed through
   ChildrenOfType(), which only checks InternalChildren and ignores
   all currently-loading drawables, it would therefore return null.

As null != 0, both of these cases would actually fail the test (this is
best seen running headless, preferably with a [Repeat] attribute
attached).

To resolve, allow the spinner to be null at the point of asserting and
duplicate the assertion step at the end. This weakens the test, as case
(1) should probably be waited for and case (2) could be solved with
exposition as protected in the base, but when attempting to wait for
the loader itself to be loaded there were also cases where the
appropriate until step would take so much time that the spinner would
actually become visible in line with the delayed display logic, so this
is a best-effort attempt to address both points without radical
changes.
2020-03-28 00:43:57 +01:00
3a3bfe9a5e Reorder children to fix pause overlay z-order 2020-03-27 21:19:49 +01:00
adc759771f Hook up score processor in player 2020-03-27 19:47:42 +01:00
46af4bce32 Cover regression in autoplay test 2020-03-27 19:42:45 +01:00
4f77850790 Merge pull request #8467 from peppy/update-framework
Update framework
2020-03-27 21:22:39 +09:00
6ecfeb8cc3 Merge pull request #8455 from Game4all/handle-novideo-beatmaps
Fix NullReferenceException when starting the no-video version of a beatmap with video
2020-03-27 21:12:40 +09:00
5be8934c8c Merge pull request #8407 from peppy/disable-raw-input
Disable raw input toggle on all but windows
2020-03-27 21:10:02 +09:00
f25b1b33e3 Merge pull request #8461 from peppy/fix-minia-mod-replay-recording
Fix osu!mania replays recording incorrectly when key mod applied
2020-03-27 20:55:58 +09:00
4106700771 Update framework 2020-03-27 20:51:44 +09:00
3763457a1d Merge pull request #8451 from peppy/fix-slider-end-sounds
Only play slider end sounds if tracking
2020-03-27 20:38:59 +09:00
fdbffbd1db Merge pull request #8452 from peppy/add-slider-judgement-accuracy
Make slider judgements count towards base score / accuracy
2020-03-27 20:37:26 +09:00
6788b7f9cd Add test for loading storyboards with missing video file. 2020-03-27 12:07:47 +01:00
abb5bb14dd Merge pull request #8450 from peppy/reduce-fruit-spread
Reduce spread of stacked fruit
2020-03-27 19:57:54 +09:00
5e1cb0e9e9 Merge branch 'master' into fix-minia-mod-replay-recording 2020-03-27 19:26:41 +09:00
04b34791cd Merge branch 'master' into add-slider-judgement-accuracy 2020-03-27 19:26:34 +09:00
005a818f32 Merge branch 'master' into fix-slider-end-sounds 2020-03-27 19:26:32 +09:00
378a957b33 Merge branch 'master' into reduce-fruit-spread 2020-03-27 19:19:23 +09:00
2bbff632c2 Merge pull request #8447 from peppy/fix-break-overlay-scaling
Fix break overlay scaling with gameplay
2020-03-27 19:18:51 +09:00
f75c082601 Fix osu!mania replays recording incorrectly when key mod applied 2020-03-27 15:50:11 +09:00
01c9112f82 Add a null check to prevent NRE when playing the "no video" version of a beatmap. 2020-03-26 17:09:22 +01:00
f80efd10c2 Avoid using a miss judgement 2020-03-26 19:54:17 +09:00
6555ab6ede Only play slider end sounds if tracking 2020-03-26 17:18:27 +09:00
8e4896fbbe Make slider judgements count towards base score / accuracy 2020-03-26 17:13:53 +09:00
2949e8dc27 Reduce spread of stacked fruit 2020-03-26 16:58:23 +09:00
07462120e4 Split break tracking into its own component 2020-03-26 15:30:23 +09:00
d372ddaadd Move break overlay to a location it is not affected by gameplay scale 2020-03-26 12:50:18 +09:00
2b1245f63a Improve xmldoc in a couple of places 2020-03-26 12:50:00 +09:00
a141e2e8b7 Merge pull request #8441 from EVAST9919/fix-panel-message
Fix last seen date being visible in user panel when it shouldn't
2020-03-26 10:15:23 +09:00
454e402e88 Fix last seen message has been visible when it shouldn't 2020-03-25 21:02:45 +03:00
1e025b7c31 Add tests to cover the issue 2020-03-25 20:58:51 +03:00
1587d4b26f Merge pull request #8428 from peppy/replay-recording
Add local replay support for all rulesets
2020-03-25 22:02:04 +09:00
deec7642ff Merge branch 'master' into replay-recording 2020-03-25 21:21:20 +09:00
9f617ba301 Merge pull request #8427 from peppy/basic-replay-recorder
Add replay recorder functionality
2020-03-25 21:15:20 +09:00
8a2aac5f83 Rename conversion methods for clarity 2020-03-25 20:21:34 +09:00
800e395bc8 Merge branch 'master' into replay-recording 2020-03-25 20:20:59 +09:00
d341b16bbb Merge branch 'master' into basic-replay-recorder 2020-03-25 19:37:39 +09:00
e7f32d951d Merge pull request #8431 from peppy/fix-intro-tests
Fix intro tests not asserting pass or working at all
2020-03-25 19:25:26 +09:00
791bf95396 Merge pull request #8433 from peppy/fix-song-select-looping
Fix track looping state not being reset when entering editor from song select
2020-03-25 19:21:18 +09:00
ebe3cf2966 Merge pull request #8430 from peppy/remove-unused-transform-helpers
Remove unused text transform helpers
2020-03-25 15:50:33 +09:00
b1d4261402 Fix track looping state not being reset when entering editor from song select
Closes #8432.
2020-03-25 15:50:19 +09:00