Commit Graph

39354 Commits

Author SHA1 Message Date
c519e4f558 Merge pull request #12763 from peppy/skin-editor-default-placement-location
Give newly added skin components a centered location to make them easier to find
2021-05-13 21:42:02 +09:00
1b62947469 Merge branch 'master' into skin-editor-default-placement-location 2021-05-13 20:58:31 +09:00
746862dcb1 Merge pull request #12750 from peppy/skin-serialisation
Add skin editor saving / loading support
2021-05-13 20:58:03 +09:00
ee67c0ddc7 Merge pull request #12768 from frenzibyte/fix-two-hovered-handles
Fix rotation handle visibility logic not handling two handles hovered at one point
2021-05-13 20:57:47 +09:00
3c471837f8 Merge branch 'master' into skin-serialisation 2021-05-13 19:49:55 +09:00
a3869c02f4 Merge branch 'master' into fix-two-hovered-handles 2021-05-13 19:24:42 +09:00
b939318922 Merge branch 'skin-serialisation' into skin-editor-default-placement-location 2021-05-13 19:09:34 +09:00
e5f765d1a8 Fix broken exception message 2021-05-13 19:06:58 +09:00
2f025f1967 SkinnableTargetWrapper -> SkinnableTargetComponentsContainer 2021-05-13 18:54:30 +09:00
01bc71acd2 Improve ability to parse xmldoc of SkinnableTargetWrapper
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2021-05-13 18:40:28 +09:00
ebce3fd3c7 Use ScheduleAfterChildren to better match comment 2021-05-13 17:29:11 +09:00
3ea469813c Use interface in place of SkinnableTargetContainer 2021-05-13 17:25:51 +09:00
0959e7156a Remove outdated TODO 2021-05-13 17:22:05 +09:00
106fa97a11 Rename SkinnableElementTargetContainer to SkinnableTargetContainer 2021-05-13 17:07:38 +09:00
7921dc7ece Rename ISkinnableComponent to ISkinnableDrawable 2021-05-13 17:06:00 +09:00
cdcd31b546 Replace ISkinSerialisable with IsEditable property 2021-05-13 17:03:17 +09:00
dd6a06a302 Reword xmldoc to read better 2021-05-13 16:43:42 +09:00
9dfa48b22e Fix incorrect exception text 2021-05-13 16:42:43 +09:00
19223ba013 Remove left-over debug logging 2021-05-13 16:42:13 +09:00
5818ed4c8c Remove unused DI resolution 2021-05-13 16:41:36 +09:00
e0e9106921 Enable autoplay in skin editor tests 2021-05-13 14:55:11 +09:00
5b71d8ca37 Merge pull request #12758 from Naxesss/verify-settings-ui
Add setting UI components to the verify screen
2021-05-13 14:35:35 +09:00
b81f86bd4d Move DI resolution to inside BDL parameters 2021-05-13 13:54:06 +09:00
c6648112e5 Simplify binding flow in InterpretationSection 2021-05-13 13:51:41 +09:00
cdcbaf4291 Tidy up specification of SettingsSection 2021-05-13 13:45:10 +09:00
db19617b8b Add JsonConstructor attribute to SkinnableTargetWrapper 2021-05-13 13:16:20 +09:00
3b862798e9 Standardise naming of methods related to SkinnableInfo 2021-05-13 13:14:49 +09:00
581e7940c7 Add xmldoc to SkinnableElementTargetContainer 2021-05-13 13:13:22 +09:00
c93ed541f3 Add xmldoc and tidy up logic in Skin 2021-05-13 13:09:33 +09:00
47948d7b34 Set default for bindable in object initializer
Fixes the CI failure.
2021-05-13 06:08:48 +02:00
992a052426 Remove stray comment 2021-05-13 13:07:06 +09:00
469a7f5d2a Reorder fields in SkinEditor 2021-05-13 13:04:17 +09:00
2bf8635ffd Move field upwards in class 2021-05-13 13:03:23 +09:00
a38cb61b08 Remove duplicated call to base.GetDrawableComponent 2021-05-13 13:02:55 +09:00
fb305130de Also refresh when interpreted difficulty changes 2021-05-13 06:00:21 +02:00
ee0a6ba93e Use local bound copy in InterpretationSection as well
Else we're relying on the `VerifyScreen`'s bindable instance, and by extension the `VerifyScreen` instance itself.
2021-05-13 05:59:49 +02:00
6caf4e3879 Add xmldoc to SkinnableInfo 2021-05-13 12:57:28 +09:00
e80d8f6922 Keep track of local bound copy 2021-05-13 05:46:47 +02:00
04c1585eb2 Use more consistent lambda discards 2021-05-13 05:38:45 +02:00
8b9ac86d4b Merge branch 'master' into skin-serialisation 2021-05-13 12:35:06 +09:00
8bf05e142b Merge pull request #12754 from peppy/skin-instantiation-info
Add `SkinInfo.InstantiationInfo` to allow creating different skin types
2021-05-13 12:34:14 +09:00
fb13ed52f7 Merge pull request #12777 from smoogipoo/fix-test-failure
Fix possible multiplayer test failure
2021-05-13 12:33:59 +09:00
e86834b740 Use local bound copy for HiddenIssueTypes 2021-05-13 05:25:20 +02:00
c8d21f2c3f Isolate refreshing to IssueList 2021-05-13 05:25:02 +02:00
5b03092968 Fix possible test failure 2021-05-13 11:53:50 +09:00
fbb76ba598 Split ShowIssueTypes dict into hidden and configurable lists
This way `VerifyScreen` is decoupled from which options `VisibilitySection` provides.

Bindings are a bit less neat, though.
2021-05-13 04:50:32 +02:00
dd8423c4c4 Set interpreted difficulty to correct default 2021-05-13 04:36:20 +02:00
6806e40ad9 Remove unnecessary local variable
This now exists in `VerifyScreen`, which we can access from here.
2021-05-13 04:30:40 +02:00
56bd897666 Move ShowIssueTypes to VerifyScreen 2021-05-13 04:29:27 +02:00
27ca7d0f4f Actually annotate the correct ctor 2021-05-12 23:53:39 +02:00