185bb9c122
change initial strain from 1 to 0 to allow simpler implementations
2021-10-07 09:30:18 +01:00
d3efec3c04
Remove unnecessary clone operations
2021-10-07 17:22:10 +09:00
7dd7d35fc8
Remove unnecessary difficulty copy operation
2021-10-07 17:19:34 +09:00
0df409c050
Move difficulty copy to BeatmapModelManager.Save
2021-10-07 17:16:45 +09:00
d50443fdf2
Merge branch 'master' into difficulty-move-to-beatmap
2021-10-07 16:50:10 +09:00
d0001f760d
Group applicable comment above new addition
2021-10-07 16:50:05 +09:00
f88d898960
Allow intro screens to be created without loading a MainMenu
2021-10-07 16:38:22 +09:00
290c9755e2
Always use circles intro for OsuGame
tests
...
The triangles intro tracks video time, which is not adjusted based on
the game's playback rate (ie. it runs in realtime even for headless
tests).
Maybe we want to make the triangles video adjust its rate along with
tests?
2021-10-07 15:55:29 +09:00
a57b080f10
Avoid showing the disclaimer in game tests
...
No real performance gain, but this is handy to bypass when actually
using one of these tests to test something.
2021-10-07 15:55:15 +09:00
5f129ae33c
Remove local overridden storage of Mods
in Player
...
Not required and only causing headaches. Accessing mods should now be
done via `GameplayState`.
Closes #14912 .
2021-10-07 14:53:39 +09:00
9705c7b546
Use cloned mods in one more place
2021-10-06 21:30:30 +09:00
433e7cd403
Fix rate mods not working if pp counter is displayed
2021-10-06 21:26:30 +09:00
99fb86878e
Only detach filter on disposal if attached
2021-10-06 18:31:56 +09:00
bd0c986144
Add asserts to ensure correct state when attaching/detaching the filter
2021-10-06 17:34:24 +09:00
4ca97bc60a
Merge branch 'master' into difficulty-move-to-beatmap
2021-10-06 16:14:21 +09:00
3803f2f462
Fix leaderboard potentially displaying the wrong scores
...
Closes #14762 .
This class is ugly. I think the whole process should be clened up once
we have correctly-scheduled `SynchronizationContext`s. There's not much
saving it as long as all these interdispersed `Schedule`s around
required.
2021-10-06 16:07:29 +09:00
222997f2b9
Copy difficulty settings back out to BeatmapInfo
on editor changes
2021-10-06 15:19:26 +09:00
0ab8dcc2a0
Fix taiko weird difficulty multiplier failing on double convert
2021-10-06 15:18:06 +09:00
b339c149d8
Copy BaseDifficulty
to Beatmap<T>
and move all write operations across
2021-10-06 15:10:45 +09:00
e6aa05a4a4
Merge pull request #14978 from peppy/fix-editor-file-selector-textbox-drags
...
Fix dragging on an editor file selection text box causing repeated popover display
2021-10-06 13:52:08 +09:00
80c8612630
Merge pull request #14977 from peppy/fix-working-beatmap-cache-invalidation
...
Fix changes not being reflected immediately after exiting the editor
2021-10-06 13:51:21 +09:00
d9849bcf49
Fix dragging on an editor file selection text box causing repeated popover display
...
Local fix and no tests as this is a pretty weird usage of `TextBox`.
We'll probably want to change it to not use a textbox eventually.
Closes #14969 .
2021-10-06 13:15:05 +09:00
90fdaf18c0
Fix PushAndConfirm
potentially failing if new screen quickly pushes a child screen
2021-10-06 12:55:04 +09:00
8ffaa491e7
Fix BeatmapModelManager
not receiving WorkingBeatmapCache
2021-10-06 12:55:04 +09:00
007b33cd88
Add missing methods to interfaces
2021-10-06 12:55:04 +09:00
ffbb7a9b1a
Remove incorrect csproj change
...
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me >
2021-10-06 12:22:32 +09:00
e837a3511d
Merge branch 'master' into beatmap-difficulty-more-interface-usage
2021-10-06 12:18:51 +09:00
266e62794e
Tweak cutoff effect for new Q value
2021-10-06 11:52:05 +09:00
4bbff2ebf7
Merge branch 'master' into new-interfaces
2021-10-06 11:38:17 +09:00
df182ba92b
Set fQ to recommended value from BASS developer to prevent filter calculations from overflowing when approaching nyquist
2021-10-06 11:29:03 +09:00
9491e5a547
Merge pull request #14954 from peppy/rename-result-response
...
Rename `APIRequest.Result` to `Response`
2021-10-06 10:52:33 +09:00
007e5f174c
Merge pull request #14959 from peppy/add-screen-test-debug
...
Add various logging output in an atttempt to figure multiplayer test failure
2021-10-06 10:11:50 +09:00
4f59fc15a5
Mark BeatmapSet
as nullable for the time being
2021-10-06 05:54:37 +09:00
4d5696959b
Remove unnecessary access modifier in interface
...
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me >
2021-10-06 05:52:28 +09:00
1f6a31355c
Remove unused using statement
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2021-10-06 05:30:49 +09:00
5a4474e1b2
Fix incorrect DI retrieval in ReplayDownloadButton
2021-10-06 05:29:00 +09:00
c23acb8f05
Merge pull request #14967 from bdach/fix-accidental-json-property-rename
...
Fix "most played beatmap" request breakage after property rename
2021-10-06 05:00:12 +09:00
baa8baaa1e
Fix "most played beatmap" request breakage after property rename
2021-10-05 21:17:19 +02:00
a5b07ce4fe
Fix backwards containment check in chat channel load callback
2021-10-05 20:53:06 +02:00
12da27cde7
Add test coverage for loading process on channel join
2021-10-05 20:52:40 +02:00
6f7b8293af
Merge pull request #14919 from smoogipoo/realtime-pp-display
...
Implement real-time PP counter
2021-10-05 20:50:03 +09:00
98fef6ece2
Handle judgement reverts with actual display updates
2021-10-05 19:08:30 +09:00
5c62d3b6cb
Merge pull request #14907 from peppy/remove-local-realm-thread-switch-handling
...
Remove local handling of realm when switching thread modes
2021-10-05 19:00:19 +09:00
e6efdae7c9
Add various logging output in an atttempt to figure multiplayer test failure
2021-10-05 18:53:20 +09:00
bd84a8b749
Merge branch 'new-interfaces' into beatmap-difficulty-more-interface-usage
2021-10-05 18:21:21 +09:00
2be44188ef
Add missing null checks
2021-10-05 17:59:38 +09:00
0859c336de
Also dim counter during initial calculation phase
2021-10-05 17:24:36 +09:00
1e4da81120
Fix import notifications not showing correct text
2021-10-05 17:14:09 +09:00
f64226ded6
Fix display not displaying correctly after initial load
2021-10-05 17:10:32 +09:00
599d82e383
Avoid returning a live IEnumerable
2021-10-05 17:01:07 +09:00